From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A0D8C432C1 for ; Tue, 24 Sep 2019 15:56:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49E37214AF for ; Tue, 24 Sep 2019 15:56:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49E37214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCnBD-0001eC-Ov for qemu-devel@archiver.kernel.org; Tue, 24 Sep 2019 11:56:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49428) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCmlG-0007Hb-1W for qemu-devel@nongnu.org; Tue, 24 Sep 2019 11:29:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCmlE-0000Ki-HN for qemu-devel@nongnu.org; Tue, 24 Sep 2019 11:29:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35298) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCml6-0000I2-FI; Tue, 24 Sep 2019 11:29:44 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E0637C069B4B; Tue, 24 Sep 2019 15:29:40 +0000 (UTC) Received: from [10.3.116.249] (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D57860BFB; Tue, 24 Sep 2019 15:28:53 +0000 (UTC) Subject: Re: [RFC v2 0/9] error: auto propagated local_err To: Vladimir Sementsov-Ogievskiy , "qemu-devel@nongnu.org" References: <20190923161231.22028-1-vsementsov@virtuozzo.com> <84c9e5dd-3e0f-94e1-5da1-2c7baa594bf1@virtuozzo.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <22191b09-822a-1f54-dcaa-3726c833805b@redhat.com> Date: Tue, 24 Sep 2019 10:28:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <84c9e5dd-3e0f-94e1-5da1-2c7baa594bf1@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 24 Sep 2019 15:29:43 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "stefanha@redhat.com" , "codyprime@gmail.com" , "jan.kiszka@siemens.com" , "berto@igalia.com" , "zhang.zhanghailiang@huawei.com" , "qemu-block@nongnu.org" , "arikalo@wavecomp.com" , "pasic@linux.ibm.com" , "hpoussin@reactos.org" , "anthony.perard@citrix.com" , "samuel.thibault@ens-lyon.org" , "philmd@redhat.com" , "green@moxielogic.com" , "lvivier@redhat.com" , "ehabkost@redhat.com" , "xiechanglong.d@gmail.com" , "pl@kamp.de" , "dgilbert@redhat.com" , "b.galvani@gmail.com" , "eric.auger@redhat.com" , "alex.williamson@redhat.com" , "ronniesahlberg@gmail.com" , "jsnow@redhat.com" , "rth@twiddle.net" , "kwolf@redhat.com" , "andrew@aj.id.au" , "crwulff@gmail.com" , "sundeep.lkml@gmail.com" , "michael@walle.cc" , "qemu-ppc@nongnu.org" , "kbastian@mail.uni-paderborn.de" , "imammedo@redhat.com" , "fam@euphon.net" , "peter.maydell@linaro.org" , "sheepdog@lists.wpkg.org" , "david@redhat.com" , "palmer@sifive.com" , "thuth@redhat.com" , "jcmvbkbc@gmail.com" , "hare@suse.com" , "sstabellini@kernel.org" , "arei.gonglei@huawei.com" , "namei.unix@gmail.com" , "atar4qemu@gmail.com" , "farman@linux.ibm.com" , "amit@kernel.org" , "sw@weilnetz.de" , "groug@kaod.org" , "qemu-s390x@nongnu.org" , "qemu-arm@nongnu.org" , "peter.chubb@nicta.com.au" , "clg@kaod.org" , "shorne@gmail.com" , "qemu-riscv@nongnu.org" , "cohuck@redhat.com" , "amarkovic@wavecomp.com" , "aurelien@aurel32.net" , "pburton@wavecomp.com" , "sagark@eecs.berkeley.edu" , "jasowang@redhat.com" , "kraxel@redhat.com" , "edgar.iglesias@gmail.com" , "gxt@mprc.pku.edu.cn" , "ari@tuxera.com" , "quintela@redhat.com" , "mdroth@linux.vnet.ibm.com" , "lersek@redhat.com" , "borntraeger@de.ibm.com" , "antonynpavlov@gmail.com" , "dillaman@redhat.com" , "joel@jms.id.au" , "xen-devel@lists.xenproject.org" , "integration@gluster.org" , "rjones@redhat.com" , "Andrew.Baumann@microsoft.com" , "mreitz@redhat.com" , "walling@linux.ibm.com" , Denis Lunev , "mst@redhat.com" , "mark.cave-ayland@ilande.co.uk" , "v.maffione@gmail.com" , "marex@denx.de" , "armbru@redhat.com" , "marcandre.lureau@redhat.com" , "alistair@alistair23.me" , "paul.durrant@citrix.com" , "pavel.dovgaluk@ispras.ru" , "g.lettieri@iet.unipi.it" , "rizzo@iet.unipi.it" , "david@gibson.dropbear.id.au" , "akrowiak@linux.ibm.com" , "berrange@redhat.com" , "xiaoguangrong.eric@gmail.com" , "pmorel@linux.ibm.com" , "wencongyang2@huawei.com" , "jcd@tribudubois.net" , "pbonzini@redhat.com" , "stefanb@linux.ibm.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/24/19 9:12 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 3. What to do with huge auto-generated commit 07? Should I split it >>> per-maintainer or per-subsystem, or leave it as-is? >> >> It's big. I'd split it into multiple patches (and reduce the cc - except >> for the cover letter, the rest of the patches can be limited to the >> actual maintainer/subsystem affected rather than everyone involved >> anywhere else in the series. With the current large cc, anyone that >> replies gets several mail bounces about "too many recipients"). It may >> be easier to split along directory boundaries than by maintainer >> boundaries. Markus has applied large tree-wide Coccinelle cleanups >> before, maybe he has some advice. > > > If split by subsystem it would be 200+ patches: > git diff --name-only | while read f; do scripts/get_maintainer.pl -f $f --subsystem --no-rolestats 2>/dev/null | grep -v @ | head -1; done | sort | uniq | wc -l > 205 > > > Try to look at larger subsystem: > git diff --name-only | while read f; do scripts/get_maintainer.pl -f $f --subsystem --no-rolestats 2>/dev/null | grep -v @ | tail -2 | head -1; done | sort | uniq | wc -l > 139 > > still too many.. Or is it OK? Hmm - that becomes a tradeoff in length of the series (where individual patches may be reviewed fast, but where the overall process may be bogged down by sheer length), vs. length of individual emails (where the email itself is daunting, but as the review is mechanical and done by automation, it becomes a matter of spot-checking if we trust that the automation was done correctly). You can probably group it in fewer patches, by joining smaller patches across a couple of subsystems. It's an art form, there's probably several ways to do it that would work, and it comes down to a judgment call on how much work you want to do to try and reduce other's work in reviewing it. Maybe even an off-hand split of gathering files until you reach about 500 or so lines per diff. I wish I had easier advice on how to tackle this sort of project in the way that will get the fastest response time. >>> vl.c | 13 +- >>> scripts/coccinelle/auto-propagated-errp.cocci | 82 +++++++ >>> 319 files changed, 2729 insertions(+), 4245 deletions(-) >>> create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci >> >> The diffstat is huge, but promising. We also learned in reviews of 7/9 that the diffstat here is misleading, the number of insertions will definitely be increasing once the Coccinelle script is fixed to insert the macro in more functions, but hopefully it's still a net reduction in overall lines. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEDBDC432C2 for ; Wed, 25 Sep 2019 04:12:05 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5B7B2064A for ; Wed, 25 Sep 2019 04:12:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5B7B2064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iCyeI-0008D1-Lt; Wed, 25 Sep 2019 04:11:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iCml7-00075t-CP for xen-devel@lists.xenproject.org; Tue, 24 Sep 2019 15:29:45 +0000 X-Inumbo-ID: 21dabbe8-dee0-11e9-bf31-bc764e2007e4 Received: from mx1.redhat.com (unknown [209.132.183.28]) by localhost (Halon) with ESMTPS id 21dabbe8-dee0-11e9-bf31-bc764e2007e4; Tue, 24 Sep 2019 15:29:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E0637C069B4B; Tue, 24 Sep 2019 15:29:40 +0000 (UTC) Received: from [10.3.116.249] (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D57860BFB; Tue, 24 Sep 2019 15:28:53 +0000 (UTC) To: Vladimir Sementsov-Ogievskiy , "qemu-devel@nongnu.org" References: <20190923161231.22028-1-vsementsov@virtuozzo.com> <84c9e5dd-3e0f-94e1-5da1-2c7baa594bf1@virtuozzo.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <22191b09-822a-1f54-dcaa-3726c833805b@redhat.com> Date: Tue, 24 Sep 2019 10:28:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <84c9e5dd-3e0f-94e1-5da1-2c7baa594bf1@virtuozzo.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 24 Sep 2019 15:29:43 +0000 (UTC) X-Mailman-Approved-At: Wed, 25 Sep 2019 04:11:29 +0000 Subject: Re: [Xen-devel] [RFC v2 0/9] error: auto propagated local_err X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "stefanha@redhat.com" , "codyprime@gmail.com" , "jan.kiszka@siemens.com" , "berto@igalia.com" , "zhang.zhanghailiang@huawei.com" , "qemu-block@nongnu.org" , "arikalo@wavecomp.com" , "pasic@linux.ibm.com" , "hpoussin@reactos.org" , "anthony.perard@citrix.com" , "samuel.thibault@ens-lyon.org" , "philmd@redhat.com" , "green@moxielogic.com" , "lvivier@redhat.com" , "ehabkost@redhat.com" , "xiechanglong.d@gmail.com" , "pl@kamp.de" , "dgilbert@redhat.com" , "b.galvani@gmail.com" , "eric.auger@redhat.com" , "alex.williamson@redhat.com" , "ronniesahlberg@gmail.com" , "jsnow@redhat.com" , "rth@twiddle.net" , "kwolf@redhat.com" , "andrew@aj.id.au" , "crwulff@gmail.com" , "sundeep.lkml@gmail.com" , "michael@walle.cc" , "qemu-ppc@nongnu.org" , "kbastian@mail.uni-paderborn.de" , "imammedo@redhat.com" , "fam@euphon.net" , "peter.maydell@linaro.org" , "sheepdog@lists.wpkg.org" , "david@redhat.com" , "palmer@sifive.com" , "thuth@redhat.com" , "jcmvbkbc@gmail.com" , "hare@suse.com" , "sstabellini@kernel.org" , "arei.gonglei@huawei.com" , "marcel.apfelbaum@gmail.com" , "namei.unix@gmail.com" , "atar4qemu@gmail.com" , "farman@linux.ibm.com" , "amit@kernel.org" , "sw@weilnetz.de" , "groug@kaod.org" , "qemu-s390x@nongnu.org" , "qemu-arm@nongnu.org" , "peter.chubb@nicta.com.au" , "clg@kaod.org" , "shorne@gmail.com" , "qemu-riscv@nongnu.org" , "cohuck@redhat.com" , "amarkovic@wavecomp.com" , "aurelien@aurel32.net" , "pburton@wavecomp.com" , "sagark@eecs.berkeley.edu" , "jasowang@redhat.com" , "kraxel@redhat.com" , "edgar.iglesias@gmail.com" , "gxt@mprc.pku.edu.cn" , "ari@tuxera.com" , "quintela@redhat.com" , "mdroth@linux.vnet.ibm.com" , "lersek@redhat.com" , "borntraeger@de.ibm.com" , "antonynpavlov@gmail.com" , "dillaman@redhat.com" , "joel@jms.id.au" , "xen-devel@lists.xenproject.org" , "integration@gluster.org" , "balrogg@gmail.com" , "rjones@redhat.com" , "Andrew.Baumann@microsoft.com" , "mreitz@redhat.com" , "walling@linux.ibm.com" , Denis Lunev , "mst@redhat.com" , "mark.cave-ayland@ilande.co.uk" , "v.maffione@gmail.com" , "marex@denx.de" , "armbru@redhat.com" , "marcandre.lureau@redhat.com" , "alistair@alistair23.me" , "paul.durrant@citrix.com" , "pavel.dovgaluk@ispras.ru" , "g.lettieri@iet.unipi.it" , "rizzo@iet.unipi.it" , "david@gibson.dropbear.id.au" , "akrowiak@linux.ibm.com" , "berrange@redhat.com" , "xiaoguangrong.eric@gmail.com" , "pmorel@linux.ibm.com" , "wencongyang2@huawei.com" , "jcd@tribudubois.net" , "pbonzini@redhat.com" , "stefanb@linux.ibm.com" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gOS8yNC8xOSA5OjEyIEFNLCBWbGFkaW1pciBTZW1lbnRzb3YtT2dpZXZza2l5IHdyb3RlOgoK Pj4+IDMuIFdoYXQgdG8gZG8gd2l0aCBodWdlIGF1dG8tZ2VuZXJhdGVkIGNvbW1pdCAwNz8gU2hv dWxkIEkgc3BsaXQgaXQKPj4+IHBlci1tYWludGFpbmVyIG9yIHBlci1zdWJzeXN0ZW0sIG9yIGxl YXZlIGl0IGFzLWlzPwo+Pgo+PiBJdCdzIGJpZy4gSSdkIHNwbGl0IGl0IGludG8gbXVsdGlwbGUg cGF0Y2hlcyAoYW5kIHJlZHVjZSB0aGUgY2MgLSBleGNlcHQKPj4gZm9yIHRoZSBjb3ZlciBsZXR0 ZXIsIHRoZSByZXN0IG9mIHRoZSBwYXRjaGVzIGNhbiBiZSBsaW1pdGVkIHRvIHRoZQo+PiBhY3R1 YWwgbWFpbnRhaW5lci9zdWJzeXN0ZW0gYWZmZWN0ZWQgcmF0aGVyIHRoYW4gZXZlcnlvbmUgaW52 b2x2ZWQKPj4gYW55d2hlcmUgZWxzZSBpbiB0aGUgc2VyaWVzLiBXaXRoIHRoZSBjdXJyZW50IGxh cmdlIGNjLCBhbnlvbmUgdGhhdAo+PiByZXBsaWVzIGdldHMgc2V2ZXJhbCBtYWlsIGJvdW5jZXMg YWJvdXQgInRvbyBtYW55IHJlY2lwaWVudHMiKS4gIEl0IG1heQo+PiBiZSBlYXNpZXIgdG8gc3Bs aXQgYWxvbmcgZGlyZWN0b3J5IGJvdW5kYXJpZXMgdGhhbiBieSBtYWludGFpbmVyCj4+IGJvdW5k YXJpZXMuICBNYXJrdXMgaGFzIGFwcGxpZWQgbGFyZ2UgdHJlZS13aWRlIENvY2NpbmVsbGUgY2xl YW51cHMKPj4gYmVmb3JlLCBtYXliZSBoZSBoYXMgc29tZSBhZHZpY2UuCj4gCj4gCj4gSWYgc3Bs aXQgYnkgc3Vic3lzdGVtIGl0IHdvdWxkIGJlIDIwMCsgcGF0Y2hlczoKPiBnaXQgZGlmZiAtLW5h bWUtb25seSB8IHdoaWxlIHJlYWQgZjsgZG8gc2NyaXB0cy9nZXRfbWFpbnRhaW5lci5wbCAtZiAk ZiAtLXN1YnN5c3RlbSAtLW5vLXJvbGVzdGF0cyAyPi9kZXYvbnVsbCB8IGdyZXAgLXYgQCB8IGhl YWQgLTE7IGRvbmUgfCBzb3J0IHwgdW5pcSB8IHdjIC1sCj4gMjA1Cj4gCj4gCj4gVHJ5IHRvIGxv b2sgYXQgbGFyZ2VyIHN1YnN5c3RlbToKPiBnaXQgZGlmZiAtLW5hbWUtb25seSB8IHdoaWxlIHJl YWQgZjsgZG8gc2NyaXB0cy9nZXRfbWFpbnRhaW5lci5wbCAtZiAkZiAtLXN1YnN5c3RlbSAtLW5v LXJvbGVzdGF0cyAyPi9kZXYvbnVsbCB8IGdyZXAgLXYgQCB8IHRhaWwgLTIgfCBoZWFkIC0xOyBk b25lIHwgc29ydCB8IHVuaXEgfCB3YyAtbAo+IDEzOQo+IAo+IHN0aWxsIHRvbyBtYW55Li4gT3Ig aXMgaXQgT0s/CgpIbW0gLSB0aGF0IGJlY29tZXMgYSB0cmFkZW9mZiBpbiBsZW5ndGggb2YgdGhl IHNlcmllcyAod2hlcmUgaW5kaXZpZHVhbApwYXRjaGVzIG1heSBiZSByZXZpZXdlZCBmYXN0LCBi dXQgd2hlcmUgdGhlIG92ZXJhbGwgcHJvY2VzcyBtYXkgYmUKYm9nZ2VkIGRvd24gYnkgc2hlZXIg bGVuZ3RoKSwgdnMuIGxlbmd0aCBvZiBpbmRpdmlkdWFsIGVtYWlscyAod2hlcmUgdGhlCmVtYWls IGl0c2VsZiBpcyBkYXVudGluZywgYnV0IGFzIHRoZSByZXZpZXcgaXMgbWVjaGFuaWNhbCBhbmQg ZG9uZSBieQphdXRvbWF0aW9uLCBpdCBiZWNvbWVzIGEgbWF0dGVyIG9mIHNwb3QtY2hlY2tpbmcg aWYgd2UgdHJ1c3QgdGhhdCB0aGUKYXV0b21hdGlvbiB3YXMgZG9uZSBjb3JyZWN0bHkpLiAgWW91 IGNhbiBwcm9iYWJseSBncm91cCBpdCBpbiBmZXdlcgpwYXRjaGVzLCBieSBqb2luaW5nIHNtYWxs ZXIgcGF0Y2hlcyBhY3Jvc3MgYSBjb3VwbGUgb2Ygc3Vic3lzdGVtcy4gIEl0J3MKYW4gYXJ0IGZv cm0sIHRoZXJlJ3MgcHJvYmFibHkgc2V2ZXJhbCB3YXlzIHRvIGRvIGl0IHRoYXQgd291bGQgd29y aywgYW5kCml0IGNvbWVzIGRvd24gdG8gYSBqdWRnbWVudCBjYWxsIG9uIGhvdyBtdWNoIHdvcmsg eW91IHdhbnQgdG8gZG8gdG8gdHJ5CmFuZCByZWR1Y2Ugb3RoZXIncyB3b3JrIGluIHJldmlld2lu ZyBpdC4gIE1heWJlIGV2ZW4gYW4gb2ZmLWhhbmQgc3BsaXQKb2YgZ2F0aGVyaW5nIGZpbGVzIHVu dGlsIHlvdSByZWFjaCBhYm91dCA1MDAgb3Igc28gbGluZXMgcGVyIGRpZmYuICBJCndpc2ggSSBo YWQgZWFzaWVyIGFkdmljZSBvbiBob3cgdG8gdGFja2xlIHRoaXMgc29ydCBvZiBwcm9qZWN0IGlu IHRoZQp3YXkgdGhhdCB3aWxsIGdldCB0aGUgZmFzdGVzdCByZXNwb25zZSB0aW1lLgoKCj4+PiAg IHZsLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAxMyArLQo+ Pj4gICBzY3JpcHRzL2NvY2NpbmVsbGUvYXV0by1wcm9wYWdhdGVkLWVycnAuY29jY2kgfCAgODIg KysrKysrKwo+Pj4gICAzMTkgZmlsZXMgY2hhbmdlZCwgMjcyOSBpbnNlcnRpb25zKCspLCA0MjQ1 IGRlbGV0aW9ucygtKQo+Pj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgc2NyaXB0cy9jb2NjaW5lbGxl L2F1dG8tcHJvcGFnYXRlZC1lcnJwLmNvY2NpCj4+Cj4+IFRoZSBkaWZmc3RhdCBpcyBodWdlLCBi dXQgcHJvbWlzaW5nLgoKV2UgYWxzbyBsZWFybmVkIGluIHJldmlld3Mgb2YgNy85IHRoYXQgdGhl IGRpZmZzdGF0IGhlcmUgaXMgbWlzbGVhZGluZywKdGhlIG51bWJlciBvZiBpbnNlcnRpb25zIHdp bGwgZGVmaW5pdGVseSBiZSBpbmNyZWFzaW5nIG9uY2UgdGhlCkNvY2NpbmVsbGUgc2NyaXB0IGlz IGZpeGVkIHRvIGluc2VydCB0aGUgbWFjcm8gaW4gbW9yZSBmdW5jdGlvbnMsIGJ1dApob3BlZnVs bHkgaXQncyBzdGlsbCBhIG5ldCByZWR1Y3Rpb24gaW4gb3ZlcmFsbCBsaW5lcy4KCi0tIApFcmlj IEJsYWtlLCBQcmluY2lwYWwgU29mdHdhcmUgRW5naW5lZXIKUmVkIEhhdCwgSW5jLiAgICAgICAg ICAgKzEtOTE5LTMwMS0zMjI2ClZpcnR1YWxpemF0aW9uOiAgcWVtdS5vcmcgfCBsaWJ2aXJ0Lm9y ZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRl dmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9s aXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iCmlR-0007YI-7A for mharc-qemu-riscv@gnu.org; Tue, 24 Sep 2019 11:30:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49450) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCmlM-0007RX-K6 for qemu-riscv@nongnu.org; Tue, 24 Sep 2019 11:30:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCmlL-0000M0-6p for qemu-riscv@nongnu.org; Tue, 24 Sep 2019 11:30:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35298) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCml6-0000I2-FI; Tue, 24 Sep 2019 11:29:44 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E0637C069B4B; Tue, 24 Sep 2019 15:29:40 +0000 (UTC) Received: from [10.3.116.249] (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D57860BFB; Tue, 24 Sep 2019 15:28:53 +0000 (UTC) Subject: Re: [RFC v2 0/9] error: auto propagated local_err To: Vladimir Sementsov-Ogievskiy , "qemu-devel@nongnu.org" Cc: "kraxel@redhat.com" , "berrange@redhat.com" , "arei.gonglei@huawei.com" , "ehabkost@redhat.com" , "imammedo@redhat.com" , "lvivier@redhat.com" , "amit@kernel.org" , "kwolf@redhat.com" , "mreitz@redhat.com" , "ari@tuxera.com" , "pavel.dovgaluk@ispras.ru" , "pbonzini@redhat.com" , "stefanha@redhat.com" , "jsnow@redhat.com" , "sw@weilnetz.de" , "fam@euphon.net" , "ronniesahlberg@gmail.com" , "pl@kamp.de" , Denis Lunev , "armbru@redhat.com" , "berto@igalia.com" , "dillaman@redhat.com" , "wencongyang2@huawei.com" , "xiechanglong.d@gmail.com" , "namei.unix@gmail.com" , "rjones@redhat.com" , "codyprime@gmail.com" , "marcandre.lureau@redhat.com" , "rth@twiddle.net" , "groug@kaod.org" , "mst@redhat.com" , "marcel.apfelbaum@gmail.com" , "b.galvani@gmail.com" , "peter.maydell@linaro.org" , "Andrew.Baumann@microsoft.com" , "philmd@redhat.com" , "antonynpavlov@gmail.com" , "jcd@tribudubois.net" , "peter.chubb@nicta.com.au" , "sundeep.lkml@gmail.com" , "joel@jms.id.au" , "eric.auger@redhat.com" , "alistair@alistair23.me" , "balrogg@gmail.com" , "edgar.iglesias@gmail.com" , "sstabellini@kernel.org" , "anthony.perard@citrix.com" , "paul.durrant@citrix.com" , "pburton@wavecomp.com" , "arikalo@wavecomp.com" , "clg@kaod.org" , "andrew@aj.id.au" , "crwulff@gmail.com" , "marex@denx.de" , "david@gibson.dropbear.id.au" , "pasic@linux.ibm.com" , "cohuck@redhat.com" , "borntraeger@de.ibm.com" , "hpoussin@reactos.org" , "xiaoguangrong.eric@gmail.com" , "aurelien@aurel32.net" , "amarkovic@wavecomp.com" , "mark.cave-ayland@ilande.co.uk" , "jasowang@redhat.com" , "lersek@redhat.com" , "palmer@sifive.com" , "sagark@eecs.berkeley.edu" , "kbastian@mail.uni-paderborn.de" , "david@redhat.com" , "thuth@redhat.com" , "farman@linux.ibm.com" , "walling@linux.ibm.com" , "hare@suse.com" , "michael@walle.cc" , "atar4qemu@gmail.com" , "stefanb@linux.ibm.com" , "samuel.thibault@ens-lyon.org" , "akrowiak@linux.ibm.com" , "pmorel@linux.ibm.com" , "alex.williamson@redhat.com" , "mdroth@linux.vnet.ibm.com" , "zhang.zhanghailiang@huawei.com" , "quintela@redhat.com" , "dgilbert@redhat.com" , "rizzo@iet.unipi.it" , "g.lettieri@iet.unipi.it" , "v.maffione@gmail.com" , "jan.kiszka@siemens.com" , "green@moxielogic.com" , "shorne@gmail.com" , "gxt@mprc.pku.edu.cn" , "jcmvbkbc@gmail.com" , "qemu-block@nongnu.org" , "integration@gluster.org" , "sheepdog@lists.wpkg.org" , "qemu-arm@nongnu.org" , "xen-devel@lists.xenproject.org" , "qemu-ppc@nongnu.org" , "qemu-s390x@nongnu.org" , "qemu-riscv@nongnu.org" References: <20190923161231.22028-1-vsementsov@virtuozzo.com> <84c9e5dd-3e0f-94e1-5da1-2c7baa594bf1@virtuozzo.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <22191b09-822a-1f54-dcaa-3726c833805b@redhat.com> Date: Tue, 24 Sep 2019 10:28:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <84c9e5dd-3e0f-94e1-5da1-2c7baa594bf1@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 24 Sep 2019 15:29:43 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Sep 2019 15:30:03 -0000 On 9/24/19 9:12 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 3. What to do with huge auto-generated commit 07? Should I split it >>> per-maintainer or per-subsystem, or leave it as-is? >> >> It's big. I'd split it into multiple patches (and reduce the cc - except >> for the cover letter, the rest of the patches can be limited to the >> actual maintainer/subsystem affected rather than everyone involved >> anywhere else in the series. With the current large cc, anyone that >> replies gets several mail bounces about "too many recipients"). It may >> be easier to split along directory boundaries than by maintainer >> boundaries. Markus has applied large tree-wide Coccinelle cleanups >> before, maybe he has some advice. > > > If split by subsystem it would be 200+ patches: > git diff --name-only | while read f; do scripts/get_maintainer.pl -f $f --subsystem --no-rolestats 2>/dev/null | grep -v @ | head -1; done | sort | uniq | wc -l > 205 > > > Try to look at larger subsystem: > git diff --name-only | while read f; do scripts/get_maintainer.pl -f $f --subsystem --no-rolestats 2>/dev/null | grep -v @ | tail -2 | head -1; done | sort | uniq | wc -l > 139 > > still too many.. Or is it OK? Hmm - that becomes a tradeoff in length of the series (where individual patches may be reviewed fast, but where the overall process may be bogged down by sheer length), vs. length of individual emails (where the email itself is daunting, but as the review is mechanical and done by automation, it becomes a matter of spot-checking if we trust that the automation was done correctly). You can probably group it in fewer patches, by joining smaller patches across a couple of subsystems. It's an art form, there's probably several ways to do it that would work, and it comes down to a judgment call on how much work you want to do to try and reduce other's work in reviewing it. Maybe even an off-hand split of gathering files until you reach about 500 or so lines per diff. I wish I had easier advice on how to tackle this sort of project in the way that will get the fastest response time. >>> vl.c | 13 +- >>> scripts/coccinelle/auto-propagated-errp.cocci | 82 +++++++ >>> 319 files changed, 2729 insertions(+), 4245 deletions(-) >>> create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci >> >> The diffstat is huge, but promising. We also learned in reviews of 7/9 that the diffstat here is misleading, the number of insertions will definitely be increasing once the Coccinelle script is fixed to insert the macro in more functions, but hopefully it's still a net reduction in overall lines. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org