From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8C28C433FE for ; Mon, 17 Oct 2022 11:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aDkT9h4zI/Qy3zh758FzjRlx2Bdpq6sXQla1vYYLGtI=; b=gVO95/xd4/qpvU VwM+vD4c3jn7OIDxEhKwbhXtJpwNDs3zt8i8U+8ao1pMJd0Mxy7QbZuAZAYZpvEOaW/RGAFPBj12k BY8LVPFNOKxCKreJfZUvj2RUTacdoxPIOEm09hZqY+apBbhtrNKYhRGkWDWK+mhNcW0fctX2f+gmB 0toWRXeiwaNIRsSV3PE3sBEGYvLDAtBaNKsahFuF1oyKPurCS5ttn+Hu39cMzbSHUrZ0TdgXv8oeZ ueuW5Ajq7DhI5D+hEK0QpTwTghGQ8euyUL4gyqtv2eK5e4B6AV69unLtAggKrHFe/sJcboeOD7bKK dIDXPwnSjdja3LiWBH2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okOJQ-00AqWZ-0U; Mon, 17 Oct 2022 11:29:40 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okOJG-00AqUD-57; Mon, 17 Oct 2022 11:29:31 +0000 Received: from p508fc122.dip0.t-ipconnect.de ([80.143.193.34] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1okOIy-0007hW-1b; Mon, 17 Oct 2022 13:29:12 +0200 From: Heiko Stuebner To: Johan Jonker , John Keeping Cc: dri-devel@lists.freedesktop.org, Sandy Huang , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup Date: Mon, 17 Oct 2022 13:29:11 +0200 Message-ID: <2220890.jZfb76A358@phil> In-Reply-To: References: <20211029115014.264084-1-john@metanate.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221017_042930_198275_B90B9BBB X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: > Hi Johan, > > On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: > > Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a SoC. > > Would you like to contribute to fix this issue? > > The assumtion that drm_fbdev_generic_setup() does what rockchip_drm_fbdev_init did is not true! > > A revert makes it work again. > > It looks like there are 3 different ways to end up with -ENOMEM here, > can you track down whether you're hitting one of the cases in > rockchip_gem_prime_vmap() or if it's the iosys_map_is_null case in > drm_gem_vmap()? > > I guess the memory usage increases slightly using the generic code and > RK3066 has less memory available. also rk3066 and rk3188 do not have an iommu, so rely on cma allocations. Heiko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E8D1C43217 for ; Mon, 17 Oct 2022 11:29:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A04210E3E2; Mon, 17 Oct 2022 11:29:24 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0275310E3E2 for ; Mon, 17 Oct 2022 11:29:15 +0000 (UTC) Received: from p508fc122.dip0.t-ipconnect.de ([80.143.193.34] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1okOIy-0007hW-1b; Mon, 17 Oct 2022 13:29:12 +0200 From: Heiko Stuebner To: Johan Jonker , John Keeping Subject: Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup Date: Mon, 17 Oct 2022 13:29:11 +0200 Message-ID: <2220890.jZfb76A358@phil> In-Reply-To: References: <20211029115014.264084-1-john@metanate.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Sandy Huang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: > Hi Johan, > > On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: > > Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a SoC. > > Would you like to contribute to fix this issue? > > The assumtion that drm_fbdev_generic_setup() does what rockchip_drm_fbdev_init did is not true! > > A revert makes it work again. > > It looks like there are 3 different ways to end up with -ENOMEM here, > can you track down whether you're hitting one of the cases in > rockchip_gem_prime_vmap() or if it's the iosys_map_is_null case in > drm_gem_vmap()? > > I guess the memory usage increases slightly using the generic code and > RK3066 has less memory available. also rk3066 and rk3188 do not have an iommu, so rely on cma allocations. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F5F8C4332F for ; Mon, 17 Oct 2022 11:30:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbiJQL3z (ORCPT ); Mon, 17 Oct 2022 07:29:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbiJQL3Z (ORCPT ); Mon, 17 Oct 2022 07:29:25 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0E67CD9 for ; Mon, 17 Oct 2022 04:29:21 -0700 (PDT) Received: from p508fc122.dip0.t-ipconnect.de ([80.143.193.34] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1okOIy-0007hW-1b; Mon, 17 Oct 2022 13:29:12 +0200 From: Heiko Stuebner To: Johan Jonker , John Keeping Cc: dri-devel@lists.freedesktop.org, Sandy Huang , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup Date: Mon, 17 Oct 2022 13:29:11 +0200 Message-ID: <2220890.jZfb76A358@phil> In-Reply-To: References: <20211029115014.264084-1-john@metanate.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: > Hi Johan, > > On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: > > Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a SoC. > > Would you like to contribute to fix this issue? > > The assumtion that drm_fbdev_generic_setup() does what rockchip_drm_fbdev_init did is not true! > > A revert makes it work again. > > It looks like there are 3 different ways to end up with -ENOMEM here, > can you track down whether you're hitting one of the cases in > rockchip_gem_prime_vmap() or if it's the iosys_map_is_null case in > drm_gem_vmap()? > > I guess the memory usage increases slightly using the generic code and > RK3066 has less memory available. also rk3066 and rk3188 do not have an iommu, so rely on cma allocations. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D574CC4332F for ; Mon, 17 Oct 2022 11:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nfmjIYqAU+0VR2pnVqyCdMTSJFyQKpIyuBpotS56igk=; b=AFEE39QndMWEjo efKdKIfFpzwzS1JM16n9v65NsnD6OGJEy6ULseolBJA75sDzhLBS3RaHODkhBAiyNjW2NbDozpI+Y ydSn0N30cuMRvXxH+AQbmujsqe/WV8qGz929te31HPXnK4yzGXlQdICAySkedXIlup6snXg7Jg2TX AsElZO9vrqssxegBBUbiYKt6KqMLDL48TIUdVE5V7ZybhdXMm2xqI+0eAf2cl9lZFqlguTezOkwLe RYePrnZMKz2vvEDk78ZGeeZnE0NkHS2tN6fMxB9ZPufGjlOUrV+uoNNpV0J3NLCMRMFOW6+AmfRbu p7EbEfkunvojPtwJlbgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okOJI-00AqVW-Kc; Mon, 17 Oct 2022 11:29:32 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okOJG-00AqUD-57; Mon, 17 Oct 2022 11:29:31 +0000 Received: from p508fc122.dip0.t-ipconnect.de ([80.143.193.34] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1okOIy-0007hW-1b; Mon, 17 Oct 2022 13:29:12 +0200 From: Heiko Stuebner To: Johan Jonker , John Keeping Cc: dri-devel@lists.freedesktop.org, Sandy Huang , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup Date: Mon, 17 Oct 2022 13:29:11 +0200 Message-ID: <2220890.jZfb76A358@phil> In-Reply-To: References: <20211029115014.264084-1-john@metanate.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221017_042930_198275_B90B9BBB X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: > Hi Johan, > > On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: > > Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a SoC. > > Would you like to contribute to fix this issue? > > The assumtion that drm_fbdev_generic_setup() does what rockchip_drm_fbdev_init did is not true! > > A revert makes it work again. > > It looks like there are 3 different ways to end up with -ENOMEM here, > can you track down whether you're hitting one of the cases in > rockchip_gem_prime_vmap() or if it's the iosys_map_is_null case in > drm_gem_vmap()? > > I guess the memory usage increases slightly using the generic code and > RK3066 has less memory available. also rk3066 and rk3188 do not have an iommu, so rely on cma allocations. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel