All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Sinan Kaya <okaya@kernel.org>
Cc: linux-next@vger.kernel.org, linux-acpi@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470
Date: Thu, 24 Jan 2019 11:51:43 +0100	[thread overview]
Message-ID: <2222147.2pZxjFhHIY@aspire.rjw.lan> (raw)
In-Reply-To: <20190121231958.28255-1-okaya@kernel.org>

On Tuesday, January 22, 2019 12:19:57 AM CET Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly.
> 
> WARNING: unmet direct dependencies detected for I2C_DESIGNWARE_PLATFORM
>   Depends on [n]: I2C [=y] && HAS_IOMEM [=y] && (ACPI [=y] && COMMON_CLK [=n] || !ACPI [=y])
>   Selected by [y]:
>   - MFD_TPS68470 [=y] && HAS_IOMEM [=y] && ACPI [=y] && I2C [=y]=y
> 
> MFD_TPS68470 is an ACPI only device and selects I2C_DESIGNWARE_PLATFORM.
> I2C_DESIGNWARE_PLATFORM does not have any configuration today for ACPI
> support without CONFIG_PCI set.
> 
> For sake of a quick fix this introduces a new mandatory dependency to the
> driver which may survive without it. Otherwise we need to revisit the
> driver architecture to address this properly.
> 
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index f461460a2aeb..76f9909cf396 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1419,7 +1419,7 @@ config MFD_TPS65217
>  
>  config MFD_TPS68470
>  	bool "TI TPS68470 Power Management / LED chips"
> -	depends on ACPI && I2C=y
> +	depends on ACPI && PCI && I2C=y
>  	select MFD_CORE
>  	select REGMAP_I2C
>  	select I2C_DESIGNWARE_PLATFORM
> 

Is anyone taking this or should I?

  parent reply	other threads:[~2019-01-24 10:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21 23:19 [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470 Sinan Kaya
2019-01-21 23:19 ` Sinan Kaya
2019-01-21 23:19 ` [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled Sinan Kaya
2019-01-21 23:19   ` Sinan Kaya
2019-01-22 12:54   ` Borislav Petkov
2019-01-22 12:54     ` Borislav Petkov
2019-01-22 14:39     ` Sinan Kaya
2019-01-22 14:39       ` Sinan Kaya
2019-01-22 21:51   ` [tip:x86/urgent] " tip-bot for Sinan Kaya
2019-01-24 10:51   ` [for next][PATCH 2/2] " Rafael J. Wysocki
2019-01-24 10:51     ` Rafael J. Wysocki
2019-01-24 17:42     ` Sinan Kaya
2019-01-24 17:42       ` Sinan Kaya
2019-01-24 10:51 ` Rafael J. Wysocki [this message]
2019-01-24 17:43   ` [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470 Sinan Kaya
2019-01-28  7:21     ` Lee Jones
2019-01-30 23:55       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2222147.2pZxjFhHIY@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=lee.jones@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=okaya@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.