From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D329C433F5 for ; Wed, 29 Dec 2021 15:15:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C04AE83094; Wed, 29 Dec 2021 16:15:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=akkea.ca header.i=@akkea.ca header.b="Fm0GwNLN"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="o1hb3cjh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2B7B583063; Wed, 29 Dec 2021 16:15:51 +0100 (CET) Received: from node.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8A4A883063 for ; Wed, 29 Dec 2021 16:15:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angus@akkea.ca Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 9F9734E2006; Wed, 29 Dec 2021 15:15:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1640790945; bh=DfwpvZsHjybnfz8+ItDp7ulXgd2supqLnGhUwJgOlB0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Fm0GwNLNmpW8KCSJ7tNY1SjNLJ2CQhMz5APQ3Ei6EFtvR4DoELNhwqkn+wqyC4VXO eSaQuShCFe7t8Ri3rl+GfTCWyXhST4IcTr7of2fU0XLjqMtJLdFPJXT60lflJVS1pt B8yerLfrhg/B9rvXnI0RIbdJ6XZhczYDvzGtiMww= Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RYOWB_VXZmAo; Wed, 29 Dec 2021 15:15:43 +0000 (UTC) Received: from www.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) by node.akkea.ca (Postfix) with ESMTPSA id 77AFC4E2003; Wed, 29 Dec 2021 15:15:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1640790943; bh=DfwpvZsHjybnfz8+ItDp7ulXgd2supqLnGhUwJgOlB0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=o1hb3cjhFDk9f+MQWV7eGmKVG63Zod4AKLkodHuNRUe/OE8ef9/EQbAabLaYr/T2/ qHRbgXyegzJvR0TwAOfQE/EAjggr+pHdPeXpQvPOwu4XI7NwMMysxcS2B8QGqkS0bw 608jEE0wiDOOv8BtkC63UKhcL2OvL6inJSqAzIvA= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 29 Dec 2021 07:15:43 -0800 From: Angus Ainslie To: Oleh Kravchenko Cc: Sean Anderson , u-boot@lists.denx.de, Simon Glass , Patrick Delaunay , Roman Stratiienko , Marek Szyprowski , kernel@puri.sm Subject: Re: [PATCH v2 1/1] fastboot: fb_getvar: Add getvar_logical_blocksize for NXP mfgtool In-Reply-To: <25cb5e9a-d023-ecff-a2f9-2bba1264cc1e@kaa.org.ua> References: <20211219161516.118636-1-angus@akkea.ca> <20211219161516.118636-2-angus@akkea.ca> <906fabbf-4297-8b03-ea39-6ea0109723aa@seco.com> <5f4413d03f81d7d7ba113d34b76a6749@akkea.ca> <25cb5e9a-d023-ecff-a2f9-2bba1264cc1e@kaa.org.ua> Message-ID: <22255e4f9fd562b8a41b8a486a6454af@akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Oleh, On 2021-12-29 07:07, Oleh Kravchenko wrote: > Hello Angus, > > 29.12.21 15:35, Angus Ainslie пише: >> The version of uuu that we are using requires the block-size for the >> sparse upload >> >> https://source.puri.sm/Librem5/mfgtools/-/blob/pureos/amber/libuuu/fastboot.cpp#L501 > > This version is outdated (2 years old). > Maybe it is time to upgrade to the latest one? > That was one of my suggested solutions but it would still leave older uuu implementations out there that won't work with mainline u-boot. >> It looks like the upstream version will default to 4096 if the >> block-size is not provided >> >> https://github.com/NXPmicro/mfgtools/blob/5397913ad97db422c1d70f314dedff4cb7d976b9/libuuu/fastboot.cpp#L642 >> >> Instead of making assumptions about the block size wouldn't it be >> better to provide one if requested ? > > +1 if it works faster ^_^ > I haven't done any speed tests so I can't really comment about the speed. >> We could also remove that being a required parameter from the uuu that >> we are using but that still leaves versions out there that won't work >> with a mainline u-boot. > > Why does mainline use fixed block size 4096? > That's a fall back if the fastboot implementation doesn't provide a block-size , probably so that it can work with mainline u-boot. > > Excuse me for direct questions I'm just curious. NP that's what review is for. Angus