From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v10 06/11] net/failsafe: support flow API
Date: Mon, 17 Jul 2017 17:03:46 +0100
Message-ID: <2230acd3-1119-22ab-5456-858d90e9f789@intel.com>
References: <cover.1500130634.git.gaetan.rivet@6wind.com>
 <db76677a92c44a91f68ea3609dcda6f8490b195f.1500130635.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Gaetan Rivet <gaetan.rivet@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 52005235
 for <dev@dpdk.org>; Mon, 17 Jul 2017 18:03:53 +0200 (CEST)
In-Reply-To: <db76677a92c44a91f68ea3609dcda6f8490b195f.1500130635.git.gaetan.rivet@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/15/2017 6:57 PM, Gaetan Rivet wrote:
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> Acked-by: Olga Shern <olgas@mellanox.com>

<...>

> +
> +	flow = fs_flow_allocate(attr, patterns, actions);
> +	FOREACH_SUBDEV_ST(sdev, i, dev, DEV_ACTIVE) {
> +		flow->flows[i] = rte_flow_create(PORT_ID(sdev),
> +				attr, patterns, actions, error);

Should SUB_ID(sdev) used here? And in related functions.
flow->flows[SUB_ID(sdev)] = ...

> +		if (flow->flows[i] == NULL) {
> +			ERROR("Failed to create flow on sub_device %d",
> +				i);
> +			goto err;
> +		}
<...>