All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: linux-acpi@vger.kernel.org, lenb@kernel.org
Subject: Re: [PATCH] ACPI: Simplify conditional that has the same effect no matter what.
Date: Tue, 23 Oct 2012 00:30:02 +0200	[thread overview]
Message-ID: <2233864.3RfD4h10pf@vostro.rjw.lan> (raw)
In-Reply-To: <alpine.DEB.2.02.1210221738310.5975@oneiric>

On Monday 22 of October 2012 17:40:36 Robert P. J. Day wrote:
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

I recall having an identical patch in my queue for v3.8.  If it's not there
after all, I'll take yours.

Thanks,
Rafael


> ---
> 
>   not sure if there's something weirdly subtle happening here, but
> this looks like a straightforward simplification.
> 
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 9eaf708..e76a7f5 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -949,12 +949,7 @@ static acpi_status __acpi_os_execute(acpi_execute_type type,
>  		(type == OSL_NOTIFY_HANDLER ? kacpi_notify_wq : kacpid_wq);
>  	dpc->wait = hp ? 1 : 0;
> 
> -	if (queue == kacpi_hotplug_wq)
> -		INIT_WORK(&dpc->work, acpi_os_execute_deferred);
> -	else if (queue == kacpi_notify_wq)
> -		INIT_WORK(&dpc->work, acpi_os_execute_deferred);
> -	else
> -		INIT_WORK(&dpc->work, acpi_os_execute_deferred);
> +	INIT_WORK(&dpc->work, acpi_os_execute_deferred);
> 
>  	/*
>  	 * On some machines, a software-initiated SMI causes corruption unless
> 
> 
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  reply	other threads:[~2012-10-22 22:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 21:40 [PATCH] ACPI: Simplify conditional that has the same effect no matter what Robert P. J. Day
2012-10-22 22:30 ` Rafael J. Wysocki [this message]
2012-10-23  2:27 ` Matthew Garrett
2012-10-24 21:23   ` Rafael J. Wysocki
2012-10-24 22:19 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2233864.3RfD4h10pf@vostro.rjw.lan \
    --to=rjw@sisk.pl \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.