From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v3 3/5] ghes_edac: add platform check to enable ghes_edac Date: Wed, 23 Aug 2017 22:46:42 +0200 Message-ID: <2234003.7P8fBnLXh9@aspire.rjw.lan> References: <20170818194644.14538-1-toshi.kani@hpe.com> <20170818194644.14538-4-toshi.kani@hpe.com> <20170823162053.4nns6ytekw5fychw@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20170823162053.4nns6ytekw5fychw@pd.tnic> Sender: linux-kernel-owner@vger.kernel.org To: Borislav Petkov Cc: Toshi Kani , mchehab@kernel.org, tony.luck@intel.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Wednesday, August 23, 2017 6:20:53 PM CEST Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 01:46:42PM -0600, Toshi Kani wrote: > > The ghes_edac driver was introduced in 2013 [1], but it has not > > been enabled by any distro yet. This driver obtains error info > > from firmware interfaces, which are not properly implemented on > > many platforms, as the driver always emits the messages below: > > > > This EDAC driver relies on BIOS to enumerate memory and get error reports. > > Unfortunately, not all BIOSes reflect the memory layout correctly > > So, the end result of using this driver varies from vendor to vendor > > If you find incorrect reports, please contact your hardware vendor > > to correct its BIOS. > > > > To get out from this situation, add a platform check to selectively > > enable the driver on the platforms that are known to have proper > > firmware implementation. Platform vendors can add their platforms > > to the list when they support ghes_edac. > > > > "ghes_edac.force_load=1" skips this platform check. > > > > [1]: https://lwn.net/Articles/538438/ > > Signed-off-by: Toshi Kani > > Cc: Borislav Petkov > > Cc: Mauro Carvalho Chehab > > Cc: Tony Luck > > --- > > drivers/edac/ghes_edac.c | 28 +++++++++++++++++++++++----- > > 1 file changed, 23 insertions(+), 5 deletions(-) > > Ok, for the remaining three, I've updated my "ghes" branch here: > > https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=ghes > > Please, redo them ontop. > > @Rafael: how do you want to handle this? > > The first two are ACPI patches and the remaining three are EDAC. It > would be probably easier if you acked the ACPI ones (but wait until > Toshi's next version) and took them all through the EDAC tree as I have > two more reworking that ghes_edac driver. So I have some pending intel_pstate and the intel_pstate changes are likely to conflict with it. > Alternatively, they could all go through the ACPI tree but you'll have > to pick them all up together. That can be done. :-) > That shouldn't be a problem either as all > changes are solely to drivers/edac/ghes_edac.c and there's one other > patch in my EDAC pile which touches ghes_edac.c: > > https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/diff/drivers/edac/ghes_edac.c?h=for-next&id=c54182ec0e157988f0cafd1e8d37b68ab4210f87 > > That's why I say, it'll be easier if I carried them all. :) > > But I'm sure we can work something out. I can expose a branch with this series for you to merge if that helps. Thanks, Rafael From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,3/5] ghes_edac: add platform check to enable ghes_edac From: "Rafael J. Wysocki" Message-Id: <2234003.7P8fBnLXh9@aspire.rjw.lan> Date: Wed, 23 Aug 2017 22:46:42 +0200 To: Borislav Petkov Cc: Toshi Kani , mchehab@kernel.org, tony.luck@intel.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gV2VkbmVzZGF5LCBBdWd1c3QgMjMsIDIwMTcgNjoyMDo1MyBQTSBDRVNUIEJvcmlzbGF2IFBl dGtvdiB3cm90ZToKPiBPbiBGcmksIEF1ZyAxOCwgMjAxNyBhdCAwMTo0Njo0MlBNIC0wNjAwLCBU b3NoaSBLYW5pIHdyb3RlOgo+ID4gVGhlIGdoZXNfZWRhYyBkcml2ZXIgd2FzIGludHJvZHVjZWQg aW4gMjAxMyBbMV0sIGJ1dCBpdCBoYXMgbm90Cj4gPiBiZWVuIGVuYWJsZWQgYnkgYW55IGRpc3Ry byB5ZXQuICBUaGlzIGRyaXZlciBvYnRhaW5zIGVycm9yIGluZm8KPiA+IGZyb20gZmlybXdhcmUg aW50ZXJmYWNlcywgd2hpY2ggYXJlIG5vdCBwcm9wZXJseSBpbXBsZW1lbnRlZCBvbgo+ID4gbWFu eSBwbGF0Zm9ybXMsIGFzIHRoZSBkcml2ZXIgYWx3YXlzIGVtaXRzIHRoZSBtZXNzYWdlcyBiZWxv dzoKPiA+IAo+ID4gIFRoaXMgRURBQyBkcml2ZXIgcmVsaWVzIG9uIEJJT1MgdG8gZW51bWVyYXRl IG1lbW9yeSBhbmQgZ2V0IGVycm9yIHJlcG9ydHMuCj4gPiAgVW5mb3J0dW5hdGVseSwgbm90IGFs bCBCSU9TZXMgcmVmbGVjdCB0aGUgbWVtb3J5IGxheW91dCBjb3JyZWN0bHkKPiA+ICBTbywgdGhl IGVuZCByZXN1bHQgb2YgdXNpbmcgdGhpcyBkcml2ZXIgdmFyaWVzIGZyb20gdmVuZG9yIHRvIHZl bmRvcgo+ID4gIElmIHlvdSBmaW5kIGluY29ycmVjdCByZXBvcnRzLCBwbGVhc2UgY29udGFjdCB5 b3VyIGhhcmR3YXJlIHZlbmRvcgo+ID4gIHRvIGNvcnJlY3QgaXRzIEJJT1MuCj4gPiAKPiA+IFRv IGdldCBvdXQgZnJvbSB0aGlzIHNpdHVhdGlvbiwgYWRkIGEgcGxhdGZvcm0gY2hlY2sgdG8gc2Vs ZWN0aXZlbHkKPiA+IGVuYWJsZSB0aGUgZHJpdmVyIG9uIHRoZSBwbGF0Zm9ybXMgdGhhdCBhcmUg a25vd24gdG8gaGF2ZSBwcm9wZXIKPiA+IGZpcm13YXJlIGltcGxlbWVudGF0aW9uLiAgUGxhdGZv cm0gdmVuZG9ycyBjYW4gYWRkIHRoZWlyIHBsYXRmb3Jtcwo+ID4gdG8gdGhlIGxpc3Qgd2hlbiB0 aGV5IHN1cHBvcnQgZ2hlc19lZGFjLgo+ID4gCj4gPiAiZ2hlc19lZGFjLmZvcmNlX2xvYWQ9MSIg c2tpcHMgdGhpcyBwbGF0Zm9ybSBjaGVjay4KPiA+IAo+ID4gWzFdOiBodHRwczovL2x3bi5uZXQv QXJ0aWNsZXMvNTM4NDM4Lwo+ID4gU2lnbmVkLW9mZi1ieTogVG9zaGkgS2FuaSA8dG9zaGkua2Fu aUBocGUuY29tPgo+ID4gQ2M6IEJvcmlzbGF2IFBldGtvdiA8YnBAYWxpZW44LmRlPgo+ID4gQ2M6 IE1hdXJvIENhcnZhbGhvIENoZWhhYiA8bWNoZWhhYkBrZXJuZWwub3JnPgo+ID4gQ2M6IFRvbnkg THVjayA8dG9ueS5sdWNrQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZWRhYy9naGVz X2VkYWMuYyB8ICAgMjggKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ID4gIDEgZmlsZSBj aGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+IAo+IE9rLCBmb3IgdGhl IHJlbWFpbmluZyB0aHJlZSwgSSd2ZSB1cGRhdGVkIG15ICJnaGVzIiBicmFuY2ggaGVyZToKPiAK PiBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9icC9icC5n aXQvbG9nLz9oPWdoZXMKPiAKPiBQbGVhc2UsIHJlZG8gdGhlbSBvbnRvcC4KPiAKPiBAUmFmYWVs OiBob3cgZG8geW91IHdhbnQgdG8gaGFuZGxlIHRoaXM/Cj4gCj4gVGhlIGZpcnN0IHR3byBhcmUg QUNQSSBwYXRjaGVzIGFuZCB0aGUgcmVtYWluaW5nIHRocmVlIGFyZSBFREFDLiBJdAo+IHdvdWxk IGJlIHByb2JhYmx5IGVhc2llciBpZiB5b3UgYWNrZWQgdGhlIEFDUEkgb25lcyAoYnV0IHdhaXQg dW50aWwKPiBUb3NoaSdzIG5leHQgdmVyc2lvbikgYW5kIHRvb2sgdGhlbSBhbGwgdGhyb3VnaCB0 aGUgRURBQyB0cmVlIGFzIEkgaGF2ZQo+IHR3byBtb3JlIHJld29ya2luZyB0aGF0IGdoZXNfZWRh YyBkcml2ZXIuCgpTbyBJIGhhdmUgc29tZSBwZW5kaW5nIGludGVsX3BzdGF0ZSBhbmQgdGhlIGlu dGVsX3BzdGF0ZSBjaGFuZ2VzIGFyZSBsaWtlbHkKdG8gY29uZmxpY3Qgd2l0aCBpdC4KCj4gQWx0 ZXJuYXRpdmVseSwgdGhleSBjb3VsZCBhbGwgZ28gdGhyb3VnaCB0aGUgQUNQSSB0cmVlIGJ1dCB5 b3UnbGwgaGF2ZQo+IHRvIHBpY2sgdGhlbSBhbGwgdXAgdG9nZXRoZXIuCgpUaGF0IGNhbiBiZSBk b25lLiA6LSkKCj4gVGhhdCBzaG91bGRuJ3QgYmUgYSBwcm9ibGVtIGVpdGhlciBhcyBhbGwKPiBj aGFuZ2VzIGFyZSBzb2xlbHkgdG8gZHJpdmVycy9lZGFjL2doZXNfZWRhYy5jIGFuZCB0aGVyZSdz IG9uZSBvdGhlcgo+IHBhdGNoIGluIG15IEVEQUMgcGlsZSB3aGljaCB0b3VjaGVzIGdoZXNfZWRh Yy5jOgo+IAo+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0 L2JwL2JwLmdpdC9kaWZmL2RyaXZlcnMvZWRhYy9naGVzX2VkYWMuYz9oPWZvci1uZXh0JmlkPWM1 NDE4MmVjMGUxNTc5ODhmMGNhZmQxZThkMzdiNjhhYjQyMTBmODcKPiAKPiBUaGF0J3Mgd2h5IEkg c2F5LCBpdCdsbCBiZSBlYXNpZXIgaWYgSSBjYXJyaWVkIHRoZW0gYWxsLiA6KQo+IAo+IEJ1dCBJ J20gc3VyZSB3ZSBjYW4gd29yayBzb21ldGhpbmcgb3V0LgoKSSBjYW4gZXhwb3NlIGEgYnJhbmNo IHdpdGggdGhpcyBzZXJpZXMgZm9yIHlvdSB0byBtZXJnZSBpZiB0aGF0IGhlbHBzLgoKVGhhbmtz LApSYWZhZWwKLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5l ICJ1bnN1YnNjcmliZSBsaW51eC1lZGFjIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFq b3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdl ci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK