From: Keith Owens <kaos@ocs.com.au>
To: Dave Jones <davej@suse.de>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [patch] 2.5.25 net/core/Makefile
Date: Tue, 09 Jul 2002 10:30:31 +1000 [thread overview]
Message-ID: <22345.1026174631@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Tue, 09 Jul 2002 01:11:35 +0100." <20020709001135.GA21383@suse.de>
On Tue, 9 Jul 2002 01:11:35 +0100,
Dave Jones <davej@suse.de> wrote:
>On Sat, Jul 06, 2002 at 06:30:29PM +1000, Keith Owens wrote:
> > The valid combination of CONFIG_NET=n, CONFIG_LLC undefined incorrectly
> > builds ext8022.o and gets unresolved references because there is no
> > network code. Detected by kbuild 2.5, not detected by the existing
> > build system.
>
>And this breaks the valid combination of CONFIG_NET=y, CONFIG_LLC undef'd
>
>net/network.o: In function Register_8022_client':
>net/network.o(.text+0xe8b7): undefined reference to Llc_register_sap'
>net/network.o: In function Unregister_8022_client':
>net/network.o(.text+0xe8fe): undefined reference to Llc_unregister_sap'
??? That is the bug that I reported. My patch fixes that bug.
Index: 25.1/net/core/Makefile
--- 25.1/net/core/Makefile Wed, 19 Jun 2002 14:11:35 +1000 kaos (linux-2.5/p/c/50_Makefile 1.4 444)
+++ 25.1(w)/net/core/Makefile Sat, 06 Jul 2002 18:27:16 +1000 kaos (linux-2.5/p/c/50_Makefile 1.4 444)
@@ -16,7 +16,7 @@ obj-$(CONFIG_FILTER) += filter.o
obj-$(CONFIG_NET) += dev.o dev_mcast.o dst.o neighbour.o rtnetlink.o utils.o
-ifneq ($(CONFIG_LLC),n)
+ifneq ($(subst n,,$(CONFIG_LLC)),)
obj-y += ext8022.o
endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2002-07-09 0:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-06 8:30 [patch] 2.5.25 net/core/Makefile Keith Owens
2002-07-09 0:11 ` Dave Jones
2002-07-09 0:30 ` Keith Owens [this message]
2002-07-09 0:36 ` Dave Jones
2002-07-09 2:13 ` Keith Owens
2002-07-09 2:24 ` Arnaldo Carvalho de Melo
2002-07-21 23:56 ` Kai Germaschewski
2002-07-22 1:08 ` Keith Owens
2002-07-22 8:07 ` Russell King
2002-07-22 8:37 ` Roman Zippel
2002-07-22 8:51 ` Andreas Schwab
2002-07-22 8:55 ` Russell King
2002-07-22 9:23 ` Roman Zippel
2002-07-22 14:29 ` Kai Germaschewski
2002-07-11 3:53 Thunder from the hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22345.1026174631@ocs3.intra.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.