From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754014AbdDRO3u (ORCPT ); Tue, 18 Apr 2017 10:29:50 -0400 Received: from mga09.intel.com ([134.134.136.24]:20952 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250AbdDRO3s (ORCPT ); Tue, 18 Apr 2017 10:29:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,219,1488873600"; d="scan'208";a="91248019" From: "Reshetova, Elena" To: Bjorn Helgaas CC: Stephen Hemminger , Bjorn Helgaas , Stephen Hemminger , Kees Cook , "linux-pci@vger.kernel.org" , Haiyang Zhang , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "Hans Liljestrand" , David Windsor Subject: RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t Thread-Topic: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t Thread-Index: AQHSloUy7QDW1qu8zE+2+pi4S/JWUKGIVvKAgAF2SwCAQWW/gIAAKNkAgAAXT6A= Date: Tue, 18 Apr 2017 14:29:43 +0000 Message-ID: <2236FBA76BA1254E88B949DDB74E612B41C8C6EB@IRSMSX102.ger.corp.intel.com> References: <1488810076-3754-1-git-send-email-elena.reshetova@intel.com> <1488810076-3754-18-git-send-email-elena.reshetova@intel.com> <20170306213829.GB5305@bhelgaas-glaptop.roam.corp.google.com> <20170307115808.16f5235e@xeon-e3> <2236FBA76BA1254E88B949DDB74E612B41C8C518@IRSMSX102.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3IETsoB010768 > On Tue, Apr 18, 2017 at 5:40 AM, Reshetova, Elena > wrote: > > > > > >> On Mon, 6 Mar 2017 15:38:29 -0600 > >> Bjorn Helgaas wrote: > >> > >> > [+cc Hyper-V folks, -cc others] > >> > > >> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote: > >> > > refcount_t type and corresponding API should be > >> > > used instead of atomic_t when the variable is used as > >> > > a reference counter. This allows to avoid accidental > >> > > refcounter overflows that might lead to use-after-free > >> > > situations. > >> > > > >> > > Signed-off-by: Elena Reshetova > >> > > Signed-off-by: Hans Liljestrand > >> > > Signed-off-by: Kees Cook > >> > > Signed-off-by: David Windsor > >> > >> > >> Reviewed-by: Stephen Hemminger > > > > Getting back on this: could you take the patch via your tree or should I resubmit > to some dedicated place with a new review-by added? > > Sorry, for some reason I had assumed this would all go as part of the > larger series. I applied it to my pci/host-hv branch with Stephen's > reviewed-by for v4.12. Thank you very much! I think I confused everyone in the beginning, but later on we decided that it is better off in small chunks and separate tress. Best Regards, Elena. > > Thanks for the ping! > > Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: "Reshetova, Elena" To: Bjorn Helgaas CC: Stephen Hemminger , Bjorn Helgaas , Stephen Hemminger , Kees Cook , "linux-pci@vger.kernel.org" , Haiyang Zhang , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "Hans Liljestrand" , David Windsor Subject: RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t Date: Tue, 18 Apr 2017 14:29:43 +0000 Message-ID: <2236FBA76BA1254E88B949DDB74E612B41C8C6EB@IRSMSX102.ger.corp.intel.com> References: <1488810076-3754-1-git-send-email-elena.reshetova@intel.com> <1488810076-3754-18-git-send-email-elena.reshetova@intel.com> <20170306213829.GB5305@bhelgaas-glaptop.roam.corp.google.com> <20170307115808.16f5235e@xeon-e3> <2236FBA76BA1254E88B949DDB74E612B41C8C518@IRSMSX102.ger.corp.intel.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: PiBPbiBUdWUsIEFwciAxOCwgMjAxNyBhdCA1OjQwIEFNLCBSZXNoZXRvdmEsIEVsZW5hDQo+IDxl bGVuYS5yZXNoZXRvdmFAaW50ZWwuY29tPiB3cm90ZToNCj4gPg0KPiA+DQo+ID4+IE9uIE1vbiwg NiBNYXIgMjAxNyAxNTozODoyOSAtMDYwMA0KPiA+PiBCam9ybiBIZWxnYWFzIDxoZWxnYWFzQGtl cm5lbC5vcmc+IHdyb3RlOg0KPiA+Pg0KPiA+PiA+IFsrY2MgSHlwZXItViBmb2xrcywgLWNjIG90 aGVyc10NCj4gPj4gPg0KPiA+PiA+IE9uIE1vbiwgTWFyIDA2LCAyMDE3IGF0IDA0OjIxOjA0UE0g KzAyMDAsIEVsZW5hIFJlc2hldG92YSB3cm90ZToNCj4gPj4gPiA+IHJlZmNvdW50X3QgdHlwZSBh bmQgY29ycmVzcG9uZGluZyBBUEkgc2hvdWxkIGJlDQo+ID4+ID4gPiB1c2VkIGluc3RlYWQgb2Yg YXRvbWljX3Qgd2hlbiB0aGUgdmFyaWFibGUgaXMgdXNlZCBhcw0KPiA+PiA+ID4gYSByZWZlcmVu Y2UgY291bnRlci4gVGhpcyBhbGxvd3MgdG8gYXZvaWQgYWNjaWRlbnRhbA0KPiA+PiA+ID4gcmVm Y291bnRlciBvdmVyZmxvd3MgdGhhdCBtaWdodCBsZWFkIHRvIHVzZS1hZnRlci1mcmVlDQo+ID4+ ID4gPiBzaXR1YXRpb25zLg0KPiA+PiA+ID4NCj4gPj4gPiA+IFNpZ25lZC1vZmYtYnk6IEVsZW5h IFJlc2hldG92YSA8ZWxlbmEucmVzaGV0b3ZhQGludGVsLmNvbT4NCj4gPj4gPiA+IFNpZ25lZC1v ZmYtYnk6IEhhbnMgTGlsamVzdHJhbmQgPGlzaGthbWllbEBnbWFpbC5jb20+DQo+ID4+ID4gPiBT aWduZWQtb2ZmLWJ5OiBLZWVzIENvb2sgPGtlZXNjb29rQGNocm9taXVtLm9yZz4NCj4gPj4gPiA+ IFNpZ25lZC1vZmYtYnk6IERhdmlkIFdpbmRzb3IgPGR3aW5kc29yQGdtYWlsLmNvbT4NCj4gPj4N Cj4gPj4NCj4gPj4gUmV2aWV3ZWQtYnk6IFN0ZXBoZW4gSGVtbWluZ2VyIDxzdGhlbW1pbkBtaWNy b3NvZnQuY29tPg0KPiA+DQo+ID4gR2V0dGluZyBiYWNrIG9uIHRoaXM6IGNvdWxkIHlvdSB0YWtl IHRoZSBwYXRjaCB2aWEgeW91ciB0cmVlIG9yIHNob3VsZCBJIHJlc3VibWl0DQo+IHRvIHNvbWUg ZGVkaWNhdGVkIHBsYWNlIHdpdGggYSBuZXcgcmV2aWV3LWJ5IGFkZGVkPw0KPiANCj4gU29ycnks IGZvciBzb21lIHJlYXNvbiBJIGhhZCBhc3N1bWVkIHRoaXMgd291bGQgYWxsIGdvIGFzIHBhcnQg b2YgdGhlDQo+IGxhcmdlciBzZXJpZXMuICBJIGFwcGxpZWQgaXQgdG8gbXkgcGNpL2hvc3QtaHYg YnJhbmNoIHdpdGggU3RlcGhlbidzDQo+IHJldmlld2VkLWJ5IGZvciB2NC4xMi4NCg0KVGhhbmsg eW91IHZlcnkgbXVjaCEgSSB0aGluayBJIGNvbmZ1c2VkIGV2ZXJ5b25lIGluIHRoZSBiZWdpbm5p bmcsIGJ1dCBsYXRlciBvbiB3ZSBkZWNpZGVkIHRoYXQgaXQgaXMgYmV0dGVyIG9mZiBpbiBzbWFs bCBjaHVua3MgYW5kIHNlcGFyYXRlIHRyZXNzLiANCg0KQmVzdCBSZWdhcmRzLA0KRWxlbmEuDQo+ IA0KPiBUaGFua3MgZm9yIHRoZSBwaW5nIQ0KPiANCj4gQmpvcm4NCg==