From: Milian Wolff <milian.wolff@kdab.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
David Ahern <dsahern@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Yao Jin <yao.jin@linux.intel.com>,
kernel-team@lge.com
Subject: Re: [PATCH] perf report: fix off-by-one for non-activation frames
Date: Tue, 16 May 2017 11:00:27 +0200 [thread overview]
Message-ID: <2238286.x0bYLBrYdd@agathebauer> (raw)
In-Reply-To: <20170516015753.GB4885@sejong>
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
On Dienstag, 16. Mai 2017 03:57:53 CEST Namhyung Kim wrote:
> On Mon, May 15, 2017 at 05:13:06PM +0200, Milian Wolff wrote:
> > On Monday, May 15, 2017 5:04:44 PM CEST Milian Wolff wrote:
> > > As the documentation for dwfl_frame_pc says, frames that
> > > are no activation frames need to have their program counter
> > > decremented by one to properly find the function of the caller.
> >
> > Note that this leaves the perf build against libunwind in the current,
> > broken state. I do not know how to detect the activation property there.
> > Does anyone else? See elfutils source code for what it is doing:
> >
> > https://sourceware.org/git/?p=elfutils.git;a=blob;f=libdwfl/
> > dwfl_frame_pc.c;h=296c815b9c73f42d79ac1778d2a0c420b89ee4eb;hb=HEAD
>
> It seems that you can use unw_is_signal_frame().
Thank you! The v2 patch I just sent now uses that and it seems to work
reliably in my quick test.
Cheers
--
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5903 bytes --]
next prev parent reply other threads:[~2017-05-16 9:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 15:04 [PATCH] perf report: fix off-by-one for non-activation frames Milian Wolff
2017-05-15 15:13 ` Milian Wolff
2017-05-15 15:13 ` Milian Wolff
2017-05-16 1:57 ` Namhyung Kim
2017-05-16 9:00 ` Milian Wolff [this message]
2017-06-16 6:14 ` Jan Kratochvil
2017-06-16 11:51 ` Milian Wolff
2017-06-16 11:57 ` Jan Kratochvil
2017-06-16 19:54 ` Milian Wolff
2017-06-17 7:56 ` Namhyung Kim
2017-06-17 8:04 ` Jan Kratochvil
2017-06-17 11:13 ` Milian Wolff
2017-06-19 18:59 ` Arnaldo Carvalho de Melo
2017-07-04 7:59 ` Milian Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2238286.x0bYLBrYdd@agathebauer \
--to=milian.wolff@kdab.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.