From: Thomas Monjalon <thomas@monjalon.net>
To: Gregory Etelson <getelson@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>,
Asaf Penso <asafp@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/mlx5: fix tunnel offload object allocation
Date: Sat, 14 Nov 2020 18:55:11 +0100 [thread overview]
Message-ID: <2239227.gqSdfHFHd5@thomas> (raw)
In-Reply-To: <MN2PR12MB463972BDF9ED07BAA1E7A381A5E50@MN2PR12MB4639.namprd12.prod.outlook.com>
14/11/2020 18:47, Gregory Etelson:
> > 13/11/2020 15:52, Gregory Etelson:
> > > The original patch allocated tunnel offload objects with invalid
> > > indexes. As the result, PMD tunnel object allocation failed.
> > >
> > > In this patch indexed pool provides both an index and memory for a new
> > > tunnel offload object.
> > > Also tunnel offload ipool moved to dv enabled code only.
> > >
> > > Fixes: f2e8093 ("net/mlx5: use indexed pool as id generator")
> > >
> > > Signed-off-by: Gregory Etelson <getelson@nvidia.com>2
> >
> > Typo above
> >
> > > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> >
> > This patch is breaking compilation in non-DV mode.
> > You should move it at the end of this series, after moving all in DV
> > areas.
>
> Patch "[PATCH v2 5/5] net/mlx5: fix non-dv compilation errors" in that series
> resolves the compilation error.
> To restore tunnel offload functionality all 5 patches must be applied.
All patches must compile.
That's why I recommend moving this patch later in the series.
next prev parent reply other threads:[~2020-11-14 17:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 14:52 [dpdk-dev] [PATCH v2 0/5] restore tunnel offload functionality in mlx5 Gregory Etelson
2020-11-13 14:52 ` [dpdk-dev] [PATCH v2 1/5] net/mlx5: fix tunnel offload object allocation Gregory Etelson
2020-11-13 19:00 ` Thomas Monjalon
2020-11-14 17:47 ` Gregory Etelson
2020-11-14 17:55 ` Thomas Monjalon [this message]
2020-11-13 14:52 ` [dpdk-dev] [PATCH v2 2/5] net/mlx5: fix tunnel offload hub multi-thread protection Gregory Etelson
2020-11-13 14:52 ` [dpdk-dev] [PATCH v2 3/5] net/mlx5: fix double table referencing Gregory Etelson
2020-11-13 14:52 ` [dpdk-dev] [PATCH v2 4/5] net/mlx5: fix tunnel offload callback names Gregory Etelson
2020-11-13 14:52 ` [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors Gregory Etelson
2020-11-14 12:06 ` Thomas Monjalon
2020-11-14 17:41 ` Gregory Etelson
2020-11-14 17:53 ` Thomas Monjalon
2020-11-14 18:31 ` Gregory Etelson
2020-11-14 19:24 ` Thomas Monjalon
2020-11-15 5:47 ` Gregory Etelson
2020-11-13 19:03 ` [dpdk-dev] [PATCH v2 0/5] restore tunnel offload functionality in mlx5 Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2239227.gqSdfHFHd5@thomas \
--to=thomas@monjalon.net \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.