From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754559AbcKQRB6 (ORCPT ); Thu, 17 Nov 2016 12:01:58 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:60040 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932979AbcKQRBq (ORCPT ); Thu, 17 Nov 2016 12:01:46 -0500 From: Arnd Bergmann To: nico@linaro.org Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, josh@joshtriplett.org, nicolas.pitre@linaro.org, mingo@kernel.org, hpa@zytor.com, richardcochran@gmail.com, pebolle@tiscali.nl, ecree@solarflare.com, john.stultz@linaro.org, mmarek@suse.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:timers/core] ptp_clock: Allow for it to be optional Date: Thu, 17 Nov 2016 17:44:05 +0100 Message-ID: <22431516.ipZiDAzsn3@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1478841010-28605-4-git-send-email-nicolas.pitre@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:uKdUIfgBOHBSmTTm7aec7KHJK3yn9Z10nMIP7PcKVEr+YmUWutQ F9Fdam+KseQm0vZ4fN70Vm0j4QPJPwALzPDd3lp3PikinI/7pBDbWk6XHv9mdhgya+I7xP/ dIZGDyaXRE1HNBhzIVtD3gujB+E8ehHZGnvyeQ+2T3D5RU0y0zuAlSZPUvHnPpS7b+gA0AQ TUG5CtzEOQlSFNFg/tssw== X-UI-Out-Filterresults: notjunk:1;V01:K0:dOHeHV2bK0Q=:zSa0AfvlKhpNgPtcuYtxZZ q8PGuC/3H/cmWt6i4H1xTY9bxbsvRZQrjZsyaWq5PlqNdgiHgyOrabDW0r2dOIt2gE7b0+TtQ mytQa7J2nM0C1PnfT1f0MTvsmMAlmmfddh35BMlkqNRpETz5vX/NChGlCHMraxnO07DKvFTyY H2ycSsKedYx/u8ZCmHfyrQb4NvTdRHFVGIpZ/epnAXGVs4MumsPZ9NVOp6ZtDJyAwKl7xkfmD hZbSeTL8qNxNYMJEOzG0rcIUmbQsI9Kt0ans7L7nsp1WdhHV0qFdwPm3j08kadyibaVU18+ai tVPZ0XIUGnBOo9Dmh7r/WIaVNnMnGiwK2c5JaElYsklLK1GVhv9daoBb+eTXECtO8SD20F6CB ZfSTvhVHKymh3kpOPyCwDcQrMJ46qY7OZLuWWLQSjIGIhMzdpBuhOUJFjtyYJK2O5KbqZ3kHL uHgCQCt3+YHqjm2in2B1CtswjdAfnNCLiQlitkd5IsWw2DyrPjErAQMPKYin/oHvD4vCtOkzU up7UtwGeN3UrMHT/7V4O/3rmyFQ9vwFs8EpVwBtwdGjHiD6+KO/bzO33sct59cVtlq2AzAyJE R7RyXAlKPm+DhYkefrBVRgbjwILFknRoXi9QCmFEH1K+dyZ6z2vmruizzjPP7ioddhKJBi0SD Huwv5XaHHGAT9KTdcHCYfqjp+YK9TuPlyevicWBGYEqp78AsciPaVIQIc8MRTJLpNhSISkxgg 0mO9QibF40D5l+OC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, November 16, 2016 12:32:03 AM CET tip-bot for Nicolas Pitre wrote: > Commit-ID: d1cbfd771ce8297fa11e89f315392de6056a2181 > Gitweb: http://git.kernel.org/tip/d1cbfd771ce8297fa11e89f315392de6056a2181 > Author: Nicolas Pitre > AuthorDate: Fri, 11 Nov 2016 00:10:07 -0500 > Committer: Thomas Gleixner > CommitDate: Wed, 16 Nov 2016 09:26:34 +0100 > > ptp_clock: Allow for it to be optional > > In order to break the hard dependency between the PTP clock subsystem and > ethernet drivers capable of being clock providers, this patch provides > simple PTP stub functions to allow linkage of those drivers into the > kernel even when the PTP subsystem is configured out. Drivers must be > ready to accept NULL from ptp_clock_register() in that case. > > And to make it possible for PTP to be configured out, the select statement > in those driver's Kconfig menu entries is converted to the new "imply" > statement. This way the PTP subsystem may have Kconfig dependencies of > its own, such as POSIX_TIMERS, without having to make those ethernet > drivers unavailable if POSIX timers are cconfigured out. And when support > for POSIX timers is selected again then the default config option for PTP > clock support will automatically be adjusted accordingly. > > The pch_gbe driver is a bit special as it relies on extra code in > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into > drivers/ptp/ even if PTP_1588_CLOCK is unselected. > > Signed-off-by: Nicolas Pitre > Acked-by: Richard Cochran > Acked-by: Edward Cree > Acked-by: Thomas Gleixner > Acked-by: John Stultz > Reviewed-by: Josh Triplett > Cc: Paul Bolle > Cc: linux-kbuild@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: Michal Marek > Link: http://lkml.kernel.org/r/1478841010-28605-4-git-send-email-nicolas.pitre@linaro.org > Signed-off-by: Thomas Gleixner Just for reference to anyone looking for the failure: drivers/net/ethernet/amd/Kconfig:183: syntax error drivers/net/ethernet/amd/Kconfig:182: unknown option "imply" drivers/net/ethernet/adi/Kconfig:62: syntax error drivers/net/ethernet/adi/Kconfig:61: unknown option "imply" drivers/net/ethernet/broadcom/Kconfig:114: syntax error drivers/net/ethernet/broadcom/Kconfig:113: unknown option "imply" drivers/net/ethernet/broadcom/Kconfig:124: syntax error drivers/net/ethernet/broadcom/Kconfig:123: unknown option "imply" drivers/net/ethernet/cavium/Kconfig:57: syntax error drivers/net/ethernet/cavium/Kconfig:56: unknown option "imply" drivers/net/ethernet/freescale/Kconfig:29: syntax error drivers/net/ethernet/freescale/Kconfig:28: unknown option "imply" drivers/net/ethernet/intel/Kconfig:62: syntax error drivers/net/ethernet/intel/Kconfig:61: unknown option "imply" drivers/net/ethernet/intel/Kconfig:87: syntax error drivers/net/ethernet/intel/Kconfig:86: unknown option "imply" drivers/net/ethernet/intel/Kconfig:160: syntax error drivers/net/ethernet/intel/Kconfig:159: unknown option "imply" drivers/net/ethernet/intel/Kconfig:217: syntax error drivers/net/ethernet/intel/Kconfig:216: unknown option "imply" drivers/net/ethernet/intel/Kconfig:268: syntax error drivers/net/ethernet/intel/Kconfig:267: unknown option "imply" drivers/net/ethernet/mellanox/mlx4/Kconfig:11: syntax error drivers/net/ethernet/mellanox/mlx4/Kconfig:10: unknown option "imply" drivers/net/ethernet/mellanox/mlx5/core/Kconfig:18: syntax error drivers/net/ethernet/mellanox/mlx5/core/Kconfig:17: unknown option "imply" drivers/net/ethernet/renesas/Kconfig:41: syntax error drivers/net/ethernet/renesas/Kconfig:40: unknown option "imply" drivers/net/ethernet/samsung/Kconfig:25: syntax error drivers/net/ethernet/samsung/Kconfig:24: unknown option "imply" drivers/net/ethernet/sfc/Kconfig:9: syntax error drivers/net/ethernet/sfc/Kconfig:8: unknown option "imply" drivers/net/ethernet/stmicro/stmmac/Kconfig:8: syntax error drivers/net/ethernet/stmicro/stmmac/Kconfig:7: unknown option "imply" drivers/net/ethernet/ti/Kconfig:80: syntax error drivers/net/ethernet/ti/Kconfig:79: unknown option "imply" drivers/net/ethernet/tile/Kconfig:13: syntax error drivers/net/ethernet/tile/Kconfig:12: unknown option "imply" drivers/ptp/Kconfig:80: syntax error drivers/ptp/Kconfig:79: unknown option "imply" It was introduced in linux-next today, but it only happens if you don't do a 'make clean' or 'make mrproper'. Apparently patch 1 of the series changes kconfig but that change does not trigger a rebuild of the kconfig binary for me. After removing kconfig from the object directory, it works again. I also ran into a problem with CONFIG_TIMERFD enabled but CONFIG_POSIX_TIMERS turned off. This could be related to some of my own patches though, haven't tried if that happens with just your patches applied. Arnd