From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 4/6] pinctrl: samsung: Add support for SoC-specific suspend/resume callbacks Date: Fri, 24 May 2013 11:20:06 +0200 Message-ID: <22452279.DN7eJUzGA7@amdc1227> References: <1368807872-2601-1-git-send-email-t.figa@samsung.com> <1368807872-2601-5-git-send-email-t.figa@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:12090 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754557Ab3EXJUO (ORCPT ); Fri, 24 May 2013 05:20:14 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MNA00IPUPTR2K20@mailout3.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 24 May 2013 10:20:12 +0100 (BST) In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Linus Walleij Cc: linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , Kukjin Kim , Arnd Bergmann , Olof Johansson , Doug Anderson , Heiko =?ISO-8859-1?Q?St=FCbner?= , Stephen Warren , Thomas Abraham , Prathyush K , Kyungmin Park Hi Linus, On Friday 24 of May 2013 11:07:41 Linus Walleij wrote: > On Fri, May 17, 2013 at 6:24 PM, Tomasz Figa wrote: > > SoC-specific driver might require additional save and restore of > > registers. This patch adds pair of SoC-specific callbacks per pinctrl > > device to account for this. > > > > Signed-off-by: Tomasz Figa > > Signed-off-by: Kyungmin Park > > Patch applied for fixes. Thanks. > Hm this is quite a lot of code for "fixes", can you confirm that > the system is really unusable without all these patches? Well, it is something that should have been already sent as a fix for 3.8, when this pin control driver was added, because since then suspend/resume has been broken on DT-enabled Exynos boards. Without this, suspending the board and then trying to wake it up is rather unpredictable, leading usually to board reset, interrupt storm or at least some devices failing to resume. Best regards, -- Tomasz Figa Linux Kernel Developer Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: t.figa@samsung.com (Tomasz Figa) Date: Fri, 24 May 2013 11:20:06 +0200 Subject: [PATCH 4/6] pinctrl: samsung: Add support for SoC-specific suspend/resume callbacks In-Reply-To: References: <1368807872-2601-1-git-send-email-t.figa@samsung.com> <1368807872-2601-5-git-send-email-t.figa@samsung.com> Message-ID: <22452279.DN7eJUzGA7@amdc1227> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Linus, On Friday 24 of May 2013 11:07:41 Linus Walleij wrote: > On Fri, May 17, 2013 at 6:24 PM, Tomasz Figa wrote: > > SoC-specific driver might require additional save and restore of > > registers. This patch adds pair of SoC-specific callbacks per pinctrl > > device to account for this. > > > > Signed-off-by: Tomasz Figa > > Signed-off-by: Kyungmin Park > > Patch applied for fixes. Thanks. > Hm this is quite a lot of code for "fixes", can you confirm that > the system is really unusable without all these patches? Well, it is something that should have been already sent as a fix for 3.8, when this pin control driver was added, because since then suspend/resume has been broken on DT-enabled Exynos boards. Without this, suspending the board and then trying to wake it up is rather unpredictable, leading usually to board reset, interrupt storm or at least some devices failing to resume. Best regards, -- Tomasz Figa Linux Kernel Developer Samsung R&D Institute Poland Samsung Electronics