From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753389AbcCZPME (ORCPT ); Sat, 26 Mar 2016 11:12:04 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:41403 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752383AbcCZPL7 (ORCPT ); Sat, 26 Mar 2016 11:11:59 -0400 From: Laurent Pinchart To: Sebastian Reichel Cc: Tony Lindgren , Aaro Koskinen , Tomi Valkeinen , David Airlie , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/23] drm: omapdrm: wait for pending operations before updating plane Date: Sat, 26 Mar 2016 11:20 +0200 Message-ID: <2247354.2fBg1ifxEX@avalon> User-Agent: KMail/4.14.10 (Linux/4.1.15-gentoo-r1; KDE/4.14.16; x86_64; ; ) In-Reply-To: <1457455195-1938-7-git-send-email-sre@kernel.org> References: <1457455195-1938-1-git-send-email-sre@kernel.org> <1457455195-1938-7-git-send-email-sre@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sabastian, Thank you for the patch. On Tuesday 08 Mar 2016 17:39:38 Sebastian Reichel wrote: > Updating the plane may interrupt ongoing display > updates, so wait for any pending operations. There's already an omap_atomic_wait_for_completion() call a couple of lines below, do we need two of them ? Why can display update be ongoing there, given that the previous omap_atomic_complete() call did wait for completion before returning ? > Signed-off-By: Sebastian Reichel > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c > b/drivers/gpu/drm/omapdrm/omap_drv.c index a3ff35f5f6cd..e142a4245766 > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.c > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c > @@ -95,6 +95,10 @@ static void omap_atomic_complete(struct > omap_atomic_state_commit *commit) /* Apply the atomic update. */ > dispc_runtime_get(); > > + dev_dbg(dev->dev, "omap_atomic_complete"); > + > + omap_atomic_wait_for_completion(dev, old_state); > + > drm_atomic_helper_commit_modeset_disables(dev, old_state); > drm_atomic_helper_commit_planes(dev, old_state, false); > drm_atomic_helper_commit_modeset_enables(dev, old_state); -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 06/23] drm: omapdrm: wait for pending operations before updating plane Date: Sat, 26 Mar 2016 11:20 +0200 Message-ID: <2247354.2fBg1ifxEX@avalon> References: <1457455195-1938-1-git-send-email-sre@kernel.org> <1457455195-1938-7-git-send-email-sre@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1457455195-1938-7-git-send-email-sre@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sebastian Reichel Cc: Aaro Koskinen , Tony Lindgren , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen , linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org SGkgU2FiYXN0aWFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5IDA4IE1h ciAyMDE2IDE3OjM5OjM4IFNlYmFzdGlhbiBSZWljaGVsIHdyb3RlOgo+IFVwZGF0aW5nIHRoZSBw bGFuZSBtYXkgaW50ZXJydXB0IG9uZ29pbmcgZGlzcGxheQo+IHVwZGF0ZXMsIHNvIHdhaXQgZm9y IGFueSBwZW5kaW5nIG9wZXJhdGlvbnMuCgpUaGVyZSdzIGFscmVhZHkgYW4gb21hcF9hdG9taWNf d2FpdF9mb3JfY29tcGxldGlvbigpIGNhbGwgYSBjb3VwbGUgb2YgbGluZXMgCmJlbG93LCBkbyB3 ZSBuZWVkIHR3byBvZiB0aGVtID8gV2h5IGNhbiBkaXNwbGF5IHVwZGF0ZSBiZSBvbmdvaW5nIHRo ZXJlLCBnaXZlbiAKdGhhdCB0aGUgcHJldmlvdXMgb21hcF9hdG9taWNfY29tcGxldGUoKSBjYWxs IGRpZCB3YWl0IGZvciBjb21wbGV0aW9uIGJlZm9yZSAKcmV0dXJuaW5nID8KCj4gU2lnbmVkLW9m Zi1CeTogU2ViYXN0aWFuIFJlaWNoZWwgPHNyZUBrZXJuZWwub3JnPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jIHwgNCArKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA0 IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0v b21hcF9kcnYuYwo+IGIvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9kcnYuYyBpbmRleCBh M2ZmMzVmNWY2Y2QuLmUxNDJhNDI0NTc2Ngo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9vbWFwZHJtL29tYXBfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFw X2Rydi5jCj4gQEAgLTk1LDYgKzk1LDEwIEBAIHN0YXRpYyB2b2lkIG9tYXBfYXRvbWljX2NvbXBs ZXRlKHN0cnVjdAo+IG9tYXBfYXRvbWljX3N0YXRlX2NvbW1pdCAqY29tbWl0KSAvKiBBcHBseSB0 aGUgYXRvbWljIHVwZGF0ZS4gKi8KPiAgCWRpc3BjX3J1bnRpbWVfZ2V0KCk7Cj4gCj4gKwlkZXZf ZGJnKGRldi0+ZGV2LCAib21hcF9hdG9taWNfY29tcGxldGUiKTsKPiArCj4gKwlvbWFwX2F0b21p Y193YWl0X2Zvcl9jb21wbGV0aW9uKGRldiwgb2xkX3N0YXRlKTsKPiArCj4gIAlkcm1fYXRvbWlj X2hlbHBlcl9jb21taXRfbW9kZXNldF9kaXNhYmxlcyhkZXYsIG9sZF9zdGF0ZSk7Cj4gIAlkcm1f YXRvbWljX2hlbHBlcl9jb21taXRfcGxhbmVzKGRldiwgb2xkX3N0YXRlLCBmYWxzZSk7Cj4gIAlk cm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9kZXNldF9lbmFibGVzKGRldiwgb2xkX3N0YXRlKTsK Ci0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==