From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDEDBC433F5 for ; Tue, 19 Oct 2021 09:40:21 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 10EF16138F for ; Tue, 19 Oct 2021 09:40:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 10EF16138F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D2BE40E5A; Tue, 19 Oct 2021 11:40:20 +0200 (CEST) Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com [64.147.123.18]) by mails.dpdk.org (Postfix) with ESMTP id 001F040683 for ; Tue, 19 Oct 2021 11:40:18 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 4E4D42B01358; Tue, 19 Oct 2021 05:40:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 19 Oct 2021 05:40:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= sh9uEdAcxKG4M7tDPCCyfMhCa8GrZtG4m/q/FLdYXwI=; b=dD90QOnBceRmRHdE cILLzYIOTPyUk92AOeGXZu0BPMxXGpVevLPyjyejHozxz+f/pohYmopHagJ6W9w8 j/PHLQZCxzkNUiUCNwV1qzpAjC5mjlbGTBfIt+I7Wk3KzXJzZbG3Y7YnTzi6J2dp SeWlvuv35jEw0jTibmxtkMfh/Ifx/Og2DUkNhkGct/q56a4IuZapjEUSyKb6LrQk x+gfRLtpMy/1CYVdEJ7kAru65Xd0WF+5zQLoTmicFrd0RtWDHUn7MAA1VFjy2n+B BmYtHjmce4BzBMgfqwIG8BOmFdJc+ElEZA+MSqQDptU7Z3CQVi171fQ2+FeWf2TZ +RB7dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=sh9uEdAcxKG4M7tDPCCyfMhCa8GrZtG4m/q/FLdYX wI=; b=bKdKDPFYLFaw5u7WTjoOowZ3Gu/nYGlBm1bZ4o6McmCNjnKPh4hUSFPwN 2ATWWI1S4cbbPkekIF3hZ+7IPmwFTwRzYcHutGgdlebnnTzaLgeAHYEH+vRXKVRg oDoRmM01Yp121rTuzLf84YzRUamHncFD0TcedIAdZ5AE377nGCfM/QQ+2nMI2ZWK YWI/Z/6bycyAiODaVagVbuiWZCpIOOE+hBrjq8Hw1NAXGwdCuM9CrXt+1CVMDWLM aTRMW2p5u6NNJ6UywqnzYHlzCaARv7Ald/1u6MDomL1txkFuZDtfEtqRJAhcAiPa y/o9LC9GbYprO3HqmUu5gOvX7cEkw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvvddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Oct 2021 05:40:12 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko , David Marchand Cc: dev@dpdk.org, Olivier Matz , Maryam Tahhan , Reshma Pattan , Xiaoyun Li , Ray Kinsella , Pavan Nikhilesh , Shijith Thotton , Jerin Jacob , "Artem V. Andreev" , Nithin Dabilpuram , Kiran Kumar K , Maciej Czekaj , Radha Mohan Chintakuntla , Veerasenareddy Burru , Maxime Coquelin , Chenbo Xia , dev Date: Tue, 19 Oct 2021 11:40:10 +0200 Message-ID: <2247611.Gtme2DleT2@thomas> In-Reply-To: References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <20211018144907.1145028-3-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/6] mempool: add namespace prefix to flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/10/2021 10:52, David Marchand: > On Mon, Oct 18, 2021 at 4:49 PM Andrew Rybchenko > wrote: > > > > Fix the mempool flgas namespace by adding an RTE_ prefix to the name. > > The old flags remain usable, but a deprecation warning is issued at > > compilation. > > We have a build failure in CI for SPDK. > This is most probably (I can't find the full compilation error in > logs..) because of the deprecation of MEMPOOL_F_NO_IOVA_CONTIG. > > > $ git grep-all -E > '\<(MEMPOOL_F_NO_IOVA_CONTIG|MEMPOOL_F_POOL_CREATED|MEMPOOL_F_SC_GET|MEMPOOL_F_SP_PUT|MEMPOOL_F_NO_CACHE_ALIGN|MEMPOOL_F_NO_SPREAD)\>' > BESS/core/packet_pool.cc: pool_->flags |= MEMPOOL_F_NO_IOVA_CONTIG; > gatekeeper/cps/main.c: socket_id, MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET); > gatekeeper/cps/main.c: socket_id, MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET); > mTcp/mtcp/src/dpdk_module.c: rte_socket_id(), MEMPOOL_F_SP_PUT | > mTcp/mtcp/src/dpdk_module.c: MEMPOOL_F_SC_GET); > mTcp/mtcp/src/memory_mgt.c: MEMPOOL_F_NO_SPREAD); > OpenDataplane/platform/linux-generic/pktio/dpdk.c:#define > MEMPOOL_FLAGS MEMPOOL_F_NO_IOVA_CONTIG > SPDK/lib/env_dpdk/env.c: socket_id, MEMPOOL_F_NO_IOVA_CONTIG); > Trex/src/pal/linux_dpdk/mbuf.cpp: unsigned flags = is_hugepages ? 0 > : MEMPOOL_F_NO_IOVA_CONTIG; > Trex/src/pal/linux_dpdk/mbuf.cpp: flags = (MEMPOOL_F_SP_PUT | > MEMPOOL_F_SC_GET); > Trex/src/pal/linux_dpdk/mbuf.cpp: flags |= MEMPOOL_F_NO_IOVA_CONTIG; > Warp17/inc/tpg_memory.h:#define MEM_MBUF_POOL_FLAGS (MEMPOOL_F_SP_PUT > | MEMPOOL_F_SC_GET) > Warp17/inc/tpg_memory.h:#define MEM_TCB_POOL_FLAGS (MEMPOOL_F_SP_PUT | > MEMPOOL_F_SC_GET) > Warp17/inc/tpg_memory.h:#define MEM_UCB_POOL_FLAGS (MEMPOOL_F_SP_PUT | > MEMPOOL_F_SC_GET) > Warp17/src/ring_if/tpg_ring_if.c:static_assert(!(MEM_MBUF_POOL_FLAGS & > MEMPOOL_F_SP_PUT), > Warp17/src/ring_if/tpg_ring_if.c: "MEM_MBUF_POOL_FLAGS > contains MEMPOOL_F_SP_PUT! This will corrupt memory when using Ring > Interfaces!"); > > > If we had announced such a deprecation, I would not question the change. > I think we should postpone the deprecation part to 22.02. > > Thomas, what do you think? Yes it is too early for such deprecation. OK to introduce new names, but please keep full compatibility.