All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: George.Dunlap@eu.citrix.com, wei.liu2@citrix.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v2 4/4] docs: add HVM USB passthrough documentation
Date: Tue, 20 Sep 2016 11:25:06 +0100	[thread overview]
Message-ID: <22497.3714.383429.280495@mariner.uk.xensource.com> (raw)
In-Reply-To: <1474288810-1986-5-git-send-email-jgross@suse.com>

Juergen Gross writes ("[PATCH v2 4/4] docs: add HVM USB passthrough documentation"):
> Update the man page regarding passthrough of USB devices to HVM
> domains via qemu USB emulation.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

By which I also mean that I approve of the API.  Thanks!


However,

> +"devicemodel" specifies a USB controller emulated by qemu. It will show up as
> +a PCI-device in the guest.
> +
>  "auto" (the default) determines whether a kernel based backend is installed.
>  If this is the case, "pv" is selected, "qusb" will be selected if no kernel
> -backend is currently available.
> +backend is currently available. For HVM domains "devicemodel" is being selected.

This should read:
   For HVM domains "devicemodel" will be selected.

But this can be fixed up later; I'm happy to submit such a patch.

Also you might want to consider semantic newlines for your future
patches to the markdown.
  http://rhodesmill.org/brandon/2012/one-sentence-per-line/



Regards,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-09-20 10:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19 12:40 [PATCH v2 0/4] libxl: add HVM USB passthrough capability Juergen Gross
2016-09-19 12:40 ` [PATCH v2 1/4] libxl: add function to remove usb controller xenstore entries Juergen Gross
2016-09-19 14:49   ` Wei Liu
2016-09-19 12:40 ` [PATCH v2 2/4] libxl: add basic support for devices without backend Juergen Gross
2016-09-19 12:40 ` [PATCH v2 3/4] libxl: add HVM usb passthrough support Juergen Gross
2016-09-19 14:49   ` Wei Liu
2016-09-19 15:31   ` George Dunlap
2016-09-20  6:17     ` Juergen Gross
2016-09-20  9:05       ` George Dunlap
2016-09-20 10:15         ` Juergen Gross
2016-09-19 12:40 ` [PATCH v2 4/4] docs: add HVM USB passthrough documentation Juergen Gross
2016-09-20 10:25   ` Ian Jackson [this message]
2016-09-20 10:44     ` Juergen Gross
2016-09-20 11:09       ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22497.3714.383429.280495@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=jgross@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.