From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, nhorman@tuxdriver.com,
kevin.laatz@intel.com, bruce.richardson@intel.com,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Luca Boccassi <luca.boccassi@gmail.com>,
Dodji Seketeli <dodji@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
David Marchand <david.marchand@redhat.com>,
"Kinsella, Ray" <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH v4 1/2] version: 20.11-rc0
Date: Tue, 11 Aug 2020 16:05:44 +0200 [thread overview]
Message-ID: <22497299.0Dkr4sR0H9@thomas> (raw)
In-Reply-To: <44dcd28c-73ac-4252-1993-3fdd85942532@ashroe.eu>
11/08/2020 15:47, Kinsella, Ray:
> On 11/08/2020 12:27, Thomas Monjalon wrote:
> > --- a/devtools/libabigail.abignore
> > +++ b/devtools/libabigail.abignore
> > @@ -8,12 +8,6 @@
> > [suppress_variable]
> > symbol_version = INTERNAL
> >
> > -; Ignore ABI 20.0.1 replaced with ABI 21
> > -[suppress_function]
> > - symbol_version = DPDK_20.0.1
> > -[suppress_variable]
> > - symbol_version = DPDK_20.0.1
> > -
> > ; Explicit ignore for driver-only ABI
> > [suppress_type]
> > name = rte_cryptodev_ops
>
> I think we might be safer doing a complete reset of libabigail.ignore.
> We should leave only the suppressions for internal and experimental.
>
> My concern is that if we have suppressions that live in there forever,
> it will becomes stale, and eventually we will end up suppressing things we don't intend.
>
> So yes, if we strip out some of these - especially the enumeration suppressions,
> We will end up having to suppress them again as we extend/modify the enumerations etc,
> but for me that preferable to the risk of unintended supressions.
>
> What do others think?
I removed all exceptions in v5.
I would like to apply this patch tomorrow morning.
All, please ack or nack quickly.
next prev parent reply other threads:[~2020-08-11 14:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 15:15 [dpdk-dev] [PATCH] version: 20.11-rc0 Thomas Monjalon
2020-08-11 9:31 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-08-11 9:58 ` [dpdk-dev] [PATCH v3 1/2] " Thomas Monjalon
2020-08-11 9:58 ` [dpdk-dev] [PATCH v3 2/2] devtools: fix ABI update in map files Thomas Monjalon
2020-08-11 11:27 ` [dpdk-dev] [PATCH v4 1/2] version: 20.11-rc0 Thomas Monjalon
2020-08-11 11:27 ` [dpdk-dev] [PATCH v4 2/2] devtools: fix ABI update in map files Thomas Monjalon
2020-08-11 13:47 ` [dpdk-dev] [PATCH v4 1/2] version: 20.11-rc0 Kinsella, Ray
2020-08-11 14:05 ` Thomas Monjalon [this message]
2020-08-11 14:03 ` [dpdk-dev] [PATCH v5 " Thomas Monjalon
2020-08-11 14:03 ` [dpdk-dev] [PATCH v5 2/2] devtools: fix ABI update in map files Thomas Monjalon
2020-08-12 6:57 ` Kinsella, Ray
2020-08-11 16:18 ` [dpdk-dev] [PATCH v5 1/2] version: 20.11-rc0 Kinsella, Ray
2020-08-12 9:02 ` Kinsella, Ray
2020-08-12 8:58 ` Kinsella, Ray
2020-08-12 9:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22497299.0Dkr4sR0H9@thomas \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=kevin.laatz@intel.com \
--cc=luca.boccassi@gmail.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.