All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Thomas Huth <thuth@redhat.com>,
	qemu-block@nongnu.org, qemu-trivial@nongnu.org,
	qemu-arm@nongnu.org, Miroslav Rezanina <mrezanin@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: Re: [PATCH 3/3] hw/pcmcia: Do not register PCMCIA type if not required
Date: Fri, 30 Apr 2021 15:16:54 +0200	[thread overview]
Message-ID: <224bb111-585d-fa11-6a36-fb9a9f0eb7c4@vivier.eu> (raw)
In-Reply-To: <20210424222057.3434459-4-f4bug@amsat.org>

Le 25/04/2021 à 00:20, Philippe Mathieu-Daudé a écrit :
> If the Kconfig 'PCMCIA' value is not selected, it is pointless
> to build the PCMCIA core components.
> 
> (Currently only one machine of the ARM targets requires this).
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/pcmcia/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/pcmcia/meson.build b/hw/pcmcia/meson.build
> index ab50bd325d6..51f2512b8ed 100644
> --- a/hw/pcmcia/meson.build
> +++ b/hw/pcmcia/meson.build
> @@ -1,2 +1,2 @@
> -softmmu_ss.add(files('pcmcia.c'))
> +softmmu_ss.add(when: 'CONFIG_PCMCIA', if_true: files('pcmcia.c'))
>  softmmu_ss.add(when: 'CONFIG_PXA2XX', if_true: files('pxa2xx.c'))
> 

Applied to my trivial-patches branch.

Thanks,
Laurent


  reply	other threads:[~2021-04-30 14:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-24 22:20 [PATCH 0/3] hw: Restrict PCMCIA to ARM target Philippe Mathieu-Daudé
2021-04-24 22:20 ` [PATCH 1/3] hw/arm/pxa2xx: Declare PCMCIA bus with Kconfig Philippe Mathieu-Daudé
2021-04-24 22:43   ` Warner Losh
2021-04-30 13:14   ` Laurent Vivier
2021-04-24 22:20 ` [PATCH 2/3] hw/ide: Add Kconfig dependency MICRODRIVE -> PCMCIA Philippe Mathieu-Daudé
2021-04-24 22:45   ` Warner Losh
2021-04-30 13:15   ` Laurent Vivier
2021-04-24 22:20 ` [PATCH 3/3] hw/pcmcia: Do not register PCMCIA type if not required Philippe Mathieu-Daudé
2021-04-30 13:16   ` Laurent Vivier [this message]
2021-04-24 22:38 ` [PATCH 0/3] hw: Restrict PCMCIA to ARM target Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=224bb111-585d-fa11-6a36-fb9a9f0eb7c4@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=f4bug@amsat.org \
    --cc=jsnow@redhat.com \
    --cc=mrezanin@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.