From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88C50C433C1 for ; Wed, 24 Mar 2021 22:08:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC53D61A13 for ; Wed, 24 Mar 2021 22:08:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC53D61A13 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPBfd-0002b6-Ta for qemu-devel@archiver.kernel.org; Wed, 24 Mar 2021 18:08:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPBen-0001lI-7w for qemu-devel@nongnu.org; Wed, 24 Mar 2021 18:07:17 -0400 Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]:34501) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPBel-0005J7-M0 for qemu-devel@nongnu.org; Wed, 24 Mar 2021 18:07:16 -0400 Received: by mail-ot1-x334.google.com with SMTP id k14-20020a9d7dce0000b02901b866632f29so72761otn.1 for ; Wed, 24 Mar 2021 15:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TB0oJJLlnibZIzXk6H+9hbbiT1QtP6PluC0Z/sabW7k=; b=NAs5DX4zypkq+nKnrKnxhsl4V+w1FZmI9hcpU64nTxZRWS5XJYOxb0pCCwCapX6cpT 8/3A7UamA2axsdRgR2TSUNWZ0T3XOfyya97RfSQyeU9t40AhYNNKxyDK3S4Tms3lkRs6 lpE4zjN/BAOCgEBPxQObptC4Gnct55WoW4aIKeZNpyATj8A5IEVRMPKhO40FNJBp0lbP Zes+tXIRThQY7Zh4MZQoSjhxwjv3M9V5RiQ4xOoD31C3AjlpBLBUZUXXFXRamYDiNaZl z7RmfjZhtHDkzXMUpjE9oemMGCgW5IA0oQnVNoaXE0vb+C1IyNXyKhnpRHxN1b4ANtjD 12qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TB0oJJLlnibZIzXk6H+9hbbiT1QtP6PluC0Z/sabW7k=; b=mz8MSWV/89kDBgPHSu2+LmBrO1AIY1fW54pSgS6ZZrdGDxfk9rLlXWx9TgcJ5fmuyF G7AN/uiQy1McZyCIrAxZrDbWNJ7kuoZPvRks6CHtfDkbCUVuDwWaKGEEop5xTBbV+79Y pBeKliskq6KsrkU9ZaBsMg4eLQ0QIvIa6Z7szWR0cpucjPF7tyRD2vx9RyKpvEc0VeYj PEUlpG5ru/3Bzan77S0CdzR1iaeuLn4ix4TxH3VtKk840Vc6z2+H8X19V1YzI5qbHj+z QyxBnkWzUlE8lajQOEUNCmTEC3DnTNQ55iXYrjTBO9vO7HyeW9TWYFdcrzQo+ise7mwa OlJA== X-Gm-Message-State: AOAM530EqT2AXztvR8nITtbAo8/15h5CmQ3PEZzlgLF0bokBzvt5Up0T FGYgrmlaNiJKj1XIWUBci9Kjaw== X-Google-Smtp-Source: ABdhPJwa6iP87bZYs4X21K5+3wDMXcHzOj2n/x2lHb7f3gJBZUZIzo0xoGMZegxf6iCAqtNtXROqTA== X-Received: by 2002:a9d:458e:: with SMTP id x14mr5050525ote.231.1616623633878; Wed, 24 Mar 2021 15:07:13 -0700 (PDT) Received: from [172.24.51.127] (168.189-204-159.bestelclientes.com.mx. [189.204.159.168]) by smtp.gmail.com with ESMTPSA id v6sm799563ook.40.2021.03.24.15.07.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 15:07:13 -0700 (PDT) Subject: Re: [RFC v11 23/55] target/arm: move arm_sctlr away from tcg helpers To: Claudio Fontana , Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210323151749.21299-1-cfontana@suse.de> <20210323154639.23477-16-cfontana@suse.de> From: Richard Henderson Message-ID: <2251f4fa-a0da-2706-8a21-329dc3f7c56d@linaro.org> Date: Wed, 24 Mar 2021 16:07:10 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210323154639.23477-16-cfontana@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::334; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x334.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Roman Bolshakov , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/23/21 9:46 AM, Claudio Fontana wrote: > this function is used for kvm too, add it to the > cpu-common module. > > Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson > /* #endif TARGET_AARCH64 , see matching comment above */ > + > +uint64_t arm_sctlr(CPUARMState *env, int el) > +{ > + /* Only EL0 needs to be adjusted for EL1&0 or EL2&0. */ > + if (el == 0) { > + ARMMMUIdx mmu_idx = arm_mmu_idx_el(env, 0); > + el = (mmu_idx == ARMMMUIdx_E20_0 || mmu_idx == ARMMMUIdx_SE20_0) > + ? 2 : 1; I only thought of it because of the comment, but *E20_0 is aarch64 only; aarch32 always uses el = 1 here. ;-) r~