From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD32C11F66 for ; Mon, 12 Jul 2021 10:39:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 550D161006 for ; Mon, 12 Jul 2021 10:39:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233627AbhGLKmd (ORCPT ); Mon, 12 Jul 2021 06:42:33 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:6917 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233445AbhGLKma (ORCPT ); Mon, 12 Jul 2021 06:42:30 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GNgCq4szZz7BcH; Mon, 12 Jul 2021 18:36:07 +0800 (CST) Received: from dggpemm500005.china.huawei.com (7.185.36.74) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 12 Jul 2021 18:39:39 +0800 Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 12 Jul 2021 18:39:38 +0800 Subject: Re: [Linuxarm] [PATCH rfc v3 0/4] add frag page support in page pool From: Yunsheng Lin To: , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <1626081581-54524-1-git-send-email-linyunsheng@huawei.com> Message-ID: <22579591-606c-9967-42e5-fcfe18875026@huawei.com> Date: Mon, 12 Jul 2021 18:39:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <1626081581-54524-1-git-send-email-linyunsheng@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggeme709-chm.china.huawei.com (10.1.199.105) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please ignore this patch set, will send out a new series without duplicated patch 3 and fix a bug for a corner case. On 2021/7/12 17:19, Yunsheng Lin wrote: > This patchset adds frag page support in page pool and > enable skb's page frag recycling based on page pool in > hns3 drvier. > > RFC v3: > 1. Implement the semantic of "page recycling only wait for the > page pool user instead of all user of a page" > 2. Support the frag allocation of different sizes > 3. Merge patch 4 & 5 to one patch as it does not make sense to > use page_pool_dev_alloc_pages() API directly with elevated > refcnt. > 4. other minor comment suggested by Alexander. > > RFC v2: > 1. Split patch 1 to more reviewable one. > 2. Repurpose the lower 12 bits of the dma address to store the > pagecnt_bias as suggested by Alexander. > 3. support recycling to pool->alloc for elevated refcnt case > too. > > > Yunsheng Lin (4): > page_pool: keep pp info as long as page pool owns the page > page_pool: add interface for getting and setting pagecnt_bias > page_pool: add frag page recycling support in page pool > net: hns3: support skb's frag page recycling based on page pool > > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 79 ++++++++++++- > drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 3 + > drivers/net/ethernet/marvell/mvneta.c | 6 +- > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- > drivers/net/ethernet/ti/cpsw.c | 2 +- > drivers/net/ethernet/ti/cpsw_new.c | 2 +- > include/linux/skbuff.h | 4 +- > include/net/page_pool.h | 58 +++++++-- > net/core/page_pool.c | 150 +++++++++++++++++++++--- > 9 files changed, 262 insertions(+), 44 deletions(-) >