From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: move runtime dir creation after args
	parse
Date: Tue, 15 May 2018 16:03:01 +0200
Message-ID: <2259993.h8ZpUa3X5Z@xps>
References: <e2abe0583336c0c4fa38d4a4151c1ee9e05c99fc.1526381067.git.anatoly.burakov@intel.com>
 <d986a385-0854-7a70-2323-4dc8b8a3c4eb@solarflare.com>
 <6f35d96d-d5cd-f399-0af4-afd8ddaa050b@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
 Bruce Richardson <bruce.richardson@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 440481B89F
 for <dev@dpdk.org>; Tue, 15 May 2018 16:03:07 +0200 (CEST)
In-Reply-To: <6f35d96d-d5cd-f399-0af4-afd8ddaa050b@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

15/05/2018 14:16, Burakov, Anatoly:
> On 15-May-18 12:36 PM, Andrew Rybchenko wrote:
> > On 05/15/2018 01:44 PM, Anatoly Burakov wrote:
> >> The intention of the original code was to create runtime data
> >> directory as early as possible, however it was moved too early,
> >> before the arguments were parsed, resulting in --file-prefix
> >> option essentially not working.
> >>
> >> Fix this by moving eal_create_runtime_dir() to after command
> >> line arguments parsing.
> >>
> >> Fixes: 56236363b481 ("eal: add directory for runtime data")
> >>
> >> Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
> >>
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > 
> > Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > 
> > I've tested it quickly and it solves the problem I observe.
> > I suppose it is OK that the directory remains after application exit.
> > 
> 
> Previously, all of the files that we were creating during runtime 
> remained, so having a directory where all the files are is better than 
> having a scattering of files :)
> 
> Thanks for testing!

Applied, thanks