All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <martin.wilck@suse.com>
To: "bmarzins@redhat.com" <bmarzins@redhat.com>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	"maier@linux.ibm.com" <maier@linux.ibm.com>,
	"christophe.varoqui@opensvc.com" <christophe.varoqui@opensvc.com>
Subject: Re: [dm-devel] [PATCH v2 1/2] libmultipath: support host adapter name lookup for s390x ccw bus
Date: Tue, 15 Feb 2022 20:41:52 +0000	[thread overview]
Message-ID: <225eb45b2f6b14743b0ace392679964912b188d9.camel@suse.com> (raw)
In-Reply-To: <b862a5941dcf0fbe6dbec1798c983e4d649393be.camel@suse.com>

On Tue, 2022-02-15 at 21:38 +0100, Martin Wilck wrote:
> 
> I was thinking about something like this (untested):
> 
> for (parent = udev_device_get_parent(hostdev); parent; 
>      parent = udev_device_get_parent(parent)) {
>       driver_name = udev_device_get_driver(parent);
>       if (driver_name && !strcmp(driver_name, "pcieport"))
>                break;
>       subsystem_name = udev_device_get_subsystem(parent);
>       if (subsystem_name && !strcmp(subsystem_name, "ccw"))
>                break;
> }
> if (!parent) {
>        udev_device_unref(hostdev);
>        return 1;
> }
> ...

So you did exactly that in your v3. Nice!

Martin


--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2022-02-15 20:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-14 18:55 [dm-devel] [PATCH v2 0/2] multipath-tools: FCP addressing display support (for s390x) Steffen Maier
2022-02-14 18:55 ` [dm-devel] [PATCH v2 1/2] libmultipath: support host adapter name lookup for s390x ccw bus Steffen Maier
2022-02-14 19:19   ` Martin Wilck
2022-02-15 17:51     ` Steffen Maier
2022-02-15 20:38       ` Martin Wilck
2022-02-15 20:41         ` Martin Wilck [this message]
2022-02-14 18:55 ` [dm-devel] [PATCH v2 2/2] libmultipath: add %L path wildcard for 64-bit hex LUN Steffen Maier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=225eb45b2f6b14743b0ace392679964912b188d9.camel@suse.com \
    --to=martin.wilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    --cc=maier@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.