From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932887AbdCaIGO convert rfc822-to-8bit (ORCPT ); Fri, 31 Mar 2017 04:06:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50094 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932564AbdCaIGK (ORCPT ); Fri, 31 Mar 2017 04:06:10 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5703580473 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5703580473 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170317054755.GA595@zzz> References: <20170317054755.GA595@zzz> <148966413352.3279.15659219505999889147.stgit@warthog.procyon.org.uk> To: Eric Biggers Cc: dhowells@redhat.com, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH] ext4: Add statx support MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22643.1490947567.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Fri, 31 Mar 2017 09:06:07 +0100 Message-ID: <22644.1490947567@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 31 Mar 2017 08:06:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Biggers wrote: > Ultimately this needs to be addressed in ext4 more fully, but how about for > ->getattr() just skipping the call to ext4_get_inode_flags() and instead > populating the generic attributes like STATX_ATTR_APPEND and > STATX_ATTR_IMMUTABLE from the generic inode flags, rather than from the > ext4-specific flags? Actually, it could even be done in generic_fillattr(), so > that all filesystems benefit. For the moment, taking Andreas's comments into account, I'll just drop the call to ext4_get_inode_flags() and just assume ei->i_flags is correct. I'm not sure whether to push the APPEND and IMMUTABLE attribute transfers to the generic code - it makes sense for all filesystems that support such flags and not for those that don't:-/ And, true, the same could be said of the AUTOMMOUNT attribute. David