From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B32CC48BCF for ; Wed, 9 Jun 2021 12:13:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E3E661285 for ; Wed, 9 Jun 2021 12:13:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235191AbhFIMPM (ORCPT ); Wed, 9 Jun 2021 08:15:12 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:5470 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231783AbhFIMPG (ORCPT ); Wed, 9 Jun 2021 08:15:06 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G0Qsk46w6zZds7; Wed, 9 Jun 2021 20:10:18 +0800 (CST) Received: from dggema761-chm.china.huawei.com (10.1.198.203) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 9 Jun 2021 20:13:08 +0800 Received: from [10.174.178.46] (10.174.178.46) by dggema761-chm.china.huawei.com (10.1.198.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 9 Jun 2021 20:13:08 +0800 Subject: Re: [PATCH] mailbox: bcm2835: Remove redundant dev_err call in bcm2835_mbox_probe() To: , , CC: , , , , References: <20210601082454.127810-1-chengzhihao1@huawei.com> From: Zhihao Cheng Message-ID: <226660de-e502-68b8-131d-27552ccccfd0@huawei.com> Date: Wed, 9 Jun 2021 20:13:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20210601082454.127810-1-chengzhihao1@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggema761-chm.china.huawei.com (10.1.198.203) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/6/1 16:24, Zhihao Cheng дµÀ: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot > Signed-off-by: Zhihao Cheng > --- > drivers/mailbox/bcm2835-mailbox.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c > index 39761d190545..86b7ce3549c5 100644 > --- a/drivers/mailbox/bcm2835-mailbox.c > +++ b/drivers/mailbox/bcm2835-mailbox.c > @@ -157,7 +157,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev) > mbox->regs = devm_ioremap_resource(&pdev->dev, iomem); > if (IS_ERR(mbox->regs)) { > ret = PTR_ERR(mbox->regs); > - dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret); > return ret; > } > friendly ping. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D6BC48BCD for ; Wed, 9 Jun 2021 12:50:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4A9F611C9 for ; Wed, 9 Jun 2021 12:50:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4A9F611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LL4CQPwe56ZW/I9Gg2XOjlI0jElg6kD/j5J8UTbWgP0=; b=jCurB+SiIC2+wMMxatLyfBrl7s /8k0SHuEUse7kJR3PFjvntScY6wG/hZvOJPloxIdGWv0LGrNAW4a67r9MXnf+w6AMRY3siBP66tCe v7e/eX7dk2/O3nvE/V5CG3+PjwV6y83N/L0dPtGdGzJIhqWzBN60RiAIcIdJP5qOM+eAy7e73ofN0 bwgHDIBkIsjVoW4oqqiSzN1Np288GnNowzS8zwFeUS4gfhDHBIz1s4ChTKSKQpNKIjnfqtFNN6jqv 9ogr+VJ4c+xWbgEX5wLxcYaULFEGA5fAWiIZnkLQpybJ/rf5tbH1kZ6D0E29J56lHc2/qRZ9u5CFo Cg7KlGQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqxcu-00DnLN-SX; Wed, 09 Jun 2021 12:48:09 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqx58-00Db06-D5; Wed, 09 Jun 2021 12:13:16 +0000 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G0Qsk46w6zZds7; Wed, 9 Jun 2021 20:10:18 +0800 (CST) Received: from dggema761-chm.china.huawei.com (10.1.198.203) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 9 Jun 2021 20:13:08 +0800 Received: from [10.174.178.46] (10.174.178.46) by dggema761-chm.china.huawei.com (10.1.198.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 9 Jun 2021 20:13:08 +0800 Subject: Re: [PATCH] mailbox: bcm2835: Remove redundant dev_err call in bcm2835_mbox_probe() To: , , CC: , , , , References: <20210601082454.127810-1-chengzhihao1@huawei.com> From: Zhihao Cheng Message-ID: <226660de-e502-68b8-131d-27552ccccfd0@huawei.com> Date: Wed, 9 Jun 2021 20:13:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20210601082454.127810-1-chengzhihao1@huawei.com> X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggema761-chm.china.huawei.com (10.1.198.203) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_051314_788278_4150AAF0 X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="gbk"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 1NogMjAyMS82LzEgMTY6MjQsIFpoaWhhbyBDaGVuZyDQtLXAOgo+IFRoZXJlIGlzIGEgZXJyb3Ig bWVzc2FnZSB3aXRoaW4gZGV2bV9pb3JlbWFwX3Jlc291cmNlCj4gYWxyZWFkeSwgc28gcmVtb3Zl IHRoZSBkZXZfZXJyIGNhbGwgdG8gYXZvaWQgcmVkdW5kYW50Cj4gZXJyb3IgbWVzc2FnZS4KPgo+ IFJlcG9ydGVkLWJ5OiBIdWxrIFJvYm90IDxodWxrY2lAaHVhd2VpLmNvbT4KPiBTaWduZWQtb2Zm LWJ5OiBaaGloYW8gQ2hlbmcgPGNoZW5nemhpaGFvMUBodWF3ZWkuY29tPgo+IC0tLQo+ICAgZHJp dmVycy9tYWlsYm94L2JjbTI4MzUtbWFpbGJveC5jIHwgMSAtCj4gICAxIGZpbGUgY2hhbmdlZCwg MSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWFpbGJveC9iY20yODM1LW1h aWxib3guYyBiL2RyaXZlcnMvbWFpbGJveC9iY20yODM1LW1haWxib3guYwo+IGluZGV4IDM5NzYx ZDE5MDU0NS4uODZiN2NlMzU0OWM1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWFpbGJveC9iY20y ODM1LW1haWxib3guYwo+ICsrKyBiL2RyaXZlcnMvbWFpbGJveC9iY20yODM1LW1haWxib3guYwo+ IEBAIC0xNTcsNyArMTU3LDYgQEAgc3RhdGljIGludCBiY20yODM1X21ib3hfcHJvYmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgIAltYm94LT5yZWdzID0gZGV2bV9pb3JlbWFwX3Jl c291cmNlKCZwZGV2LT5kZXYsIGlvbWVtKTsKPiAgIAlpZiAoSVNfRVJSKG1ib3gtPnJlZ3MpKSB7 Cj4gICAJCXJldCA9IFBUUl9FUlIobWJveC0+cmVncyk7Cj4gLQkJZGV2X2VycigmcGRldi0+ZGV2 LCAiRmFpbGVkIHRvIHJlbWFwIG1haWxib3ggcmVnczogJWRcbiIsIHJldCk7Cj4gICAJCXJldHVy biByZXQ7Cj4gICAJfQo+ICAgCgpmcmllbmRseSBwaW5nLgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK