From: Dmitry Osipenko <digetx@gmail.com>
To: Stefan Agner <stefan@agner.ch>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linus.walleij@linaro.org, pdeschrijver@nvidia.co,
marcel.ziswiler@toradex.com
Cc: keescook@chromium.org, linux-tegra@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: tegra: readd gpio-ranges properties
Date: Thu, 02 Aug 2018 13:35:46 +0300 [thread overview]
Message-ID: <2268060.eSddBDDeqC@dimapc> (raw)
In-Reply-To: <2777476.ese58fB1FL@dimapc>
On Thursday, 2 August 2018 02:11:23 MSK Dmitry Osipenko wrote:
> On Thursday, 2 August 2018 01:51:42 MSK Stefan Agner wrote:
> > On 01.08.2018 22:51, Dmitry Osipenko wrote:
> > > On Thursday, 26 July 2018 18:40:25 MSK Stefan Agner wrote:
> > >> The properties have been commented out to prevent a regression a
> > >> while ago. The first regression should be resolved by
> > >> commit 44af7927316e ("spi: Map SPI OF client IRQ at probe time").
> > >>
> > >> The second regression is probably addressed by
> > >> commit 494fd7b7ad10 ("PM / core: fix deferred probe breaking suspend
> > >> resume
> > >> order") and/or maybe others. Readd the gpio-ranges properties to see
> > >> whether regressions still get reported.
> > >>
> > >> This reverts commit 4f1d841475e1f6e9e32496dda11215db56f4ea73
> > >> ("ARM: tegra: Comment out gpio-ranges properties").
> > >>
> > >> Signed-off-by: Stefan Agner <stefan@agner.ch>
> > >> ---
> > >
> > > Unfortunately the second regression hasn't been addressed yet, this
> > > patch
> > > still breaks wake-up using GPIO key. BTW, better to spell "readd" as
> > > "re-add".
> >
> > You do have the hardware and could test it?
>
> Yes, I have.
>
> > Hm, that is unfortunate. I think this was the patch which should address
> > the issue:
> > https://lkml.org/lkml/2015/9/10/218
>
> I've tested the patch and it is still actual, i.e. it fixes the wake-up.
> Welcome back to 2015 :-)
Actually, the pinctrl-gpio probe order is easily fixable by reshuffling the
drivers registration order within the kernel. I'll send patches.
next prev parent reply other threads:[~2018-08-02 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 15:40 [PATCH 1/2] pinctrl: tegra: define GPIO compatible node per SoC Stefan Agner
2018-07-26 15:40 ` [PATCH 2/2] ARM: tegra: readd gpio-ranges properties Stefan Agner
2018-08-01 20:51 ` Dmitry Osipenko
2018-08-01 22:51 ` Stefan Agner
2018-08-01 23:11 ` Dmitry Osipenko
2018-08-02 10:35 ` Dmitry Osipenko [this message]
2018-08-16 14:44 ` Dmitry Osipenko
2018-07-29 21:37 ` [PATCH 1/2] pinctrl: tegra: define GPIO compatible node per SoC Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2268060.eSddBDDeqC@dimapc \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=pdeschrijver@nvidia.co \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.