From: Xiao Ni <xni@redhat.com>
To: Song Liu <song@kernel.org>
Cc: linux-raid <linux-raid@vger.kernel.org>,
Nigel Croxon <ncroxon@redhat.com>
Subject: Re: [PATCH 1/2] super1.0 calculates max sectors in a wrong way
Date: Wed, 29 Jul 2020 09:13:43 +0800 [thread overview]
Message-ID: <22684ab9-7c20-f0a3-4045-3357bbf53125@redhat.com> (raw)
In-Reply-To: <CAPhsuW5RAEb7i-VQ+MS0XfGKNyd=2_=VoGVjk2SU6A30cW9PKg@mail.gmail.com>
On 07/29/2020 08:43 AM, Song Liu wrote:
>> Hi Song
>>
>> This calculation of bitmap is decided by mdadm. In mdadm super1.c
>> choose_bm_space function,
>> it uses this way to calculate bitmap space. Do I need to add comments
>> here to describe this?
>> Something like "mdadm function choose_bm_space decides the bitmap space"?
> Thanks for the explanation.
>
> I merged the two patches, made some changes, and applied it to md-next. Please
> let me know whether it looks good.
>
The function super_10_choose_bm_space can make people confused. All
types of super1 calculate
bitmap space in the same way (super1.0, 1.1 and 1.2). Could you change
the function name to
super_1_choose_bm_space?
Thanks
Xiao
next prev parent reply other threads:[~2020-07-29 1:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 7:55 [PATCH 0/2] Can't grow size twice for a super1.0 array Xiao Ni
2020-06-30 7:55 ` [PATCH 1/2] super1.0 calculates max sectors in a wrong way Xiao Ni
2020-07-27 17:33 ` Song Liu
2020-07-28 1:18 ` Xiao Ni
2020-07-29 0:43 ` Song Liu
2020-07-29 1:13 ` Xiao Ni [this message]
2020-07-29 2:51 ` Song Liu
2020-06-30 7:55 ` [PATCH 2/2] Don't need to reset superblock start address for super1.0 Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22684ab9-7c20-f0a3-4045-3357bbf53125@redhat.com \
--to=xni@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=ncroxon@redhat.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.