From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH v2 3/5] tools/libxendevicemodel: extract functions and add a compat layer Date: Wed, 22 Feb 2017 14:20:22 +0000 Message-ID: <22701.40486.327235.432509@mariner.uk.xensource.com> References: <1487770058-21040-1-git-send-email-paul.durrant@citrix.com> <1487770058-21040-4-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgXmb-0007wo-NK for xen-devel@lists.xenproject.org; Wed, 22 Feb 2017 14:20:41 +0000 In-Reply-To: <1487770058-21040-4-git-send-email-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Paul Durrant Cc: xen-devel@lists.xenproject.org, Wei Liu List-Id: xen-devel@lists.xenproject.org UGF1bCBEdXJyYW50IHdyaXRlcyAoIltQQVRDSCB2MiAzLzVdIHRvb2xzL2xpYnhlbmRldmljZW1v ZGVsOiBleHRyYWN0IGZ1bmN0aW9ucyBhbmQgYWRkIGEgY29tcGF0IGxheWVyIik6Cj4gVGhpcyBw YXRjaCBleHRyYWN0cyBhbGwgZnVuY3Rpb25zIHJlc3VsdGluZyBpbiBhIGRtX29wIGh5cGVyY2Fs bCBmcm9tCj4gbGlieGVuY3RybCBhbmQgbW92ZXMgdGhlbSBpbnRvIGxpYnhlbmRldmljZW1vZGVs LiBJdCBhbHNvIGFkZHMgYSBjb21wYXQKPiBsYXllciBpbnRvIGxpYnhlbmN0cmwsIHdoaWNoIGNh biBiZSBzZWxlY3RlZCBieSBkZWZpbmluZwo+IFhDX1dBTlRfQ09NUEFUX0RFVklDRU1PREVMX0FQ SSB0byAxIGJlZm9yZSBpbmNsdWRpbmcgeGVuY3RybC5oLgo+IAo+IFdpdGggdGhpcyBwYXRjaCB0 aGUgY29yZSBvZiBsaWJ4ZW5kZXZpY2Vtb2RlbCBzdGlsbCB1c2VzIGxpYnhlbmNhbGwgdG8KPiBp c3N1ZSB0aGUgZG1fb3AgaHlwZXJjYWxscywgYnV0IHRoaXMgaXMgZG9uZSBieSBjYWxsaW5nIHRo cm91Z2ggY29kZSB0aGF0Cj4gY2FuIGJlIG1vZGlmaWVkIG9uIGEgcGVyLU9TIGJhc2lzLiBBIHN1 YnNlcXVlbnQgcGF0Y2ggd2lsbCBhZGQgYSBMaW51eC0KPiBzcGVjaWZpYyB2YXJpYW50LgouLi4K PiAraW50IHhlbmRldmljZW1vZGVsX3RyYWNrX2RpcnR5X3ZyYW0oCj4gKyAgICB4ZW5kZXZpY2Vt b2RlbF9oYW5kbGUgKmRtb2QsIGRvbWlkX3QgZG9taWQsIHVpbnQ2NF90IGZpcnN0X3BmbiwKPiAr ICAgIHVpbnQzMl90IG5yLCB1bnNpZ25lZCBsb25nICpkaXJ0eV9iaXRtYXApCj4gK3sKPiArICAg IHN0cnVjdCB4ZW5fZG1fb3Agb3A7Cj4gKyAgICBzdHJ1Y3QgeGVuX2RtX29wX3RyYWNrX2RpcnR5 X3ZyYW0gKmRhdGE7Cj4gKwo+ICsgICAgbWVtc2V0KCZvcCwgMCwgc2l6ZW9mKG9wKSk7Cj4gKwo+ ICsgICAgb3Aub3AgPSBYRU5fRE1PUF90cmFja19kaXJ0eV92cmFtOwo+ICsgICAgZGF0YSA9ICZv cC51LnRyYWNrX2RpcnR5X3ZyYW07Cj4gKwo+ICsgICAgZGF0YS0+Zmlyc3RfcGZuID0gZmlyc3Rf cGZuOwo+ICsgICAgZGF0YS0+bnIgPSBucjsKPiArCj4gKyAgICByZXR1cm4geGVuZGV2aWNlbW9k ZWxfb3AoZG1vZCwgZG9taWQsIDIsICZvcCwgc2l6ZW9mKG9wKSwKPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBkaXJ0eV9iaXRtYXAsIChzaXplX3QpKG5yICsgNykgLyA4KTsKPiArfQoK QXMgSSB0aGluayB3ZSBkaXNjdXNzZWQgc29tZSB0aW1lIGxhc3Qgd2VlayAoPyksIHRoaXMgZnVu Y3Rpb24gY2Fubm90CmJlIGEgRE1PUC4gIFRoaXMgaXMgYmVjYXVzZSBlbmFibGluZyB0cmFja19k aXJ0eV92cmFtIGNhdXNlcyB0aGUKaHlwZXJ2aXNvciB0byByZW1lbWJlciB0aGUgbWVtb3J5IHJl ZmVycmVkIHRvIGJ5IGRpcnR5X2JpdG1hcCwgYnV0IHRoZQpkbW9wIHByaXZjbWQgcmVzdHJpY3Rp b24gbWVjaGFuaXNtIG9ubHkgZ3VhcmFudGVlcyB0aGF0IHRoZSBtZW1vcnkgaXMKdmFsaWQgYW5k IGJlbG9uZ2luZyB0byB0aGlzIGd1ZXN0IF9kdXJpbmcgdGhlIGh5cGVyY2FsbF8uCgpBcmUgdGhl cmUgbW9yZSBsaWtlIHRoaXMgPyAgSG93IGRvZXMgaW9yZXEgc2VydmVyIHJlZ2lzdHJhdGlvbgp3 b3JrID8KCkNhbiB3ZSBhZGQgYSBub3RlIHRvIHRoZSBoeXBlcnZpc29yIHNpZGUgb2YgdGhlIERN T1AgYnVmZmVyIGludGVyZmFjZSwKc2F5aW5nIHNvbWV0aGluZyBsaWtlCgogICBDb2RlIGluIFhl biBNVVNUIE5PVCBzYXZlIGNvcGllcyBvZiB0aGUgcG9pbnRlcnMgaW4gdGhlIGRtb3AKICAgYnVm ZmVycy4gIE9ubHkgY29weWluZyB0byBhbmQgZnJvbSBndWVzdCBtZW1vcnksIGR1cmluZyB0aGUK ICAgaHlwZXJjYWxsLCBpcyBwZXJtaXR0ZWQuCgo/CgpJYW4uCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1k ZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK