From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034620AbeE1Pfm (ORCPT ); Mon, 28 May 2018 11:35:42 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:38016 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968817AbeE1KSh (ORCPT ); Mon, 28 May 2018 06:18:37 -0400 From: Laurent Pinchart To: Maciej Purski Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Rob Herring , Mark Rutland , Thierry Reding , Kukjin Kim , Krzysztof Kozlowski , Archit Taneja , Andrzej Hajda , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 07/12] dt-bindings: tc358754: add DT bindings Date: Mon, 28 May 2018 13:18:36 +0300 Message-ID: <2275901.CJI6BsfBlP@avalon> Organization: Ideas on Board Oy In-Reply-To: <1527500833-16005-8-git-send-email-m.purski@samsung.com> References: <1527500833-16005-1-git-send-email-m.purski@samsung.com> <1527500833-16005-8-git-send-email-m.purski@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maciej, Thank you for the patch. On Monday, 28 May 2018 12:47:11 EEST Maciej Purski wrote: > The patch adds bindings to Toshiba DSI/LVDS bridge TC358764. > Bindings describe power supplies, reset gpio and video interfaces. > > Signed-off-by: Andrzej Hajda > Signed-off-by: Maciej Purski > --- > .../bindings/display/bridge/toshiba,tc358764.txt | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/bridge/toshiba,tc358764.txt > > diff --git > a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358764.txt > b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358764.txt new > file mode 100644 > index 0000000..d09bdc2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358764.txt > @@ -0,0 +1,42 @@ > +TC358764 MIPI-DSI to LVDS panel bridge > + > +Required properties: > + - compatible: "toshiba,tc358764" > + - reg: the virtual channel number of a DSI peripheral > + - vddc-supply: core voltage supply > + - vddio-supply: I/O voltage supply > + - vddmipi-supply: MIPI voltage supply > + - vddlvds133-supply: LVDS1 3.3V voltage supply > + - vddlvds112-supply: LVDS1 1.2V voltage supply That's a lot of power supplies. Could some of them be merged together ? See https://patchwork.freedesktop.org/patch/216058/ for an earlier discussion on the same subject. > + - reset-gpios: a GPIO spec for the reset pin > + > +The device node can contain zero to two 'port' child nodes, each with one > +child > +'endpoint' node, according to the bindings defined in [1]. > +The following are properties specific to those nodes. > + > +port: > + - reg: (required) can be 0 for DSI port or 1 for LVDS port; This seems pretty vague to me. It could be read as meaning that ports are completely optional, and that the port number you list can be used, but that something else could be used to. Let's make the port nodes mandatory. I propose the following. Required nodes: The TC358764 has DSI and LVDS ports whose connections are described using the OF graph bindings defined in Documentation/devicetree/bindings/graph.txt. The device node must contain one 'port' child node per DSI and LVDS port. The port nodes are numbered as follows. Port Number ------------------------------------------------------------------- DSI Input 0 LVDS Output 1 Each port node must contain endpoint nodes describing the hardware connections. > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > + > +Example: > + > + bridge@0 { > + reg = <0>; > + compatible = "toshiba,tc358764"; > + vddc-supply = <&vcc_1v2_reg>; > + vddio-supply = <&vcc_1v8_reg>; > + vddmipi-supply = <&vcc_1v2_reg>; > + vddlvds133-supply = <&vcc_3v3_reg>; > + vddlvds112-supply = <&vcc_1v2_reg>; > + reset-gpios = <&gpd1 6 GPIO_ACTIVE_LOW>; > + #address-cells = <1>; > + #size-cells = <0>; > + port@1 { > + reg = <1>; > + lvds_ep: endpoint { > + remote-endpoint = <&panel_ep>; > + }; > + }; > + }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 07/12] dt-bindings: tc358754: add DT bindings Date: Mon, 28 May 2018 13:18:36 +0300 Message-ID: <2275901.CJI6BsfBlP@avalon> References: <1527500833-16005-1-git-send-email-m.purski@samsung.com> <1527500833-16005-8-git-send-email-m.purski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1527500833-16005-8-git-send-email-m.purski@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maciej Purski Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , David Airlie , Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Rob Herring , Thierry Reding , Kukjin Kim , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Marek Szyprowski List-Id: devicetree@vger.kernel.org SGkgTWFjaWVqLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBNb25kYXksIDI4IE1heSAy MDE4IDEyOjQ3OjExIEVFU1QgTWFjaWVqIFB1cnNraSB3cm90ZToKPiBUaGUgcGF0Y2ggYWRkcyBi aW5kaW5ncyB0byBUb3NoaWJhIERTSS9MVkRTIGJyaWRnZSBUQzM1ODc2NC4KPiBCaW5kaW5ncyBk ZXNjcmliZSBwb3dlciBzdXBwbGllcywgcmVzZXQgZ3BpbyBhbmQgdmlkZW8gaW50ZXJmYWNlcy4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmRyemVqIEhhamRhIDxhLmhhamRhQHNhbXN1bmcuY29tPgo+ IFNpZ25lZC1vZmYtYnk6IE1hY2llaiBQdXJza2kgPG0ucHVyc2tpQHNhbXN1bmcuY29tPgo+IC0t LQo+ICAuLi4vYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvdG9zaGliYSx0YzM1ODc2NC50eHQgICB8 IDQyICsrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDQyIGluc2VydGlvbnMo KykKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0Cj4gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2Rpc3BsYXkvYnJpZGdlL3Rvc2hpYmEsdGMzNTg3NjQudHh0Cj4gCj4gZGlmZiAtLWdpdAo+ IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3Rvc2hp YmEsdGMzNTg3NjQudHh0Cj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlz cGxheS9icmlkZ2UvdG9zaGliYSx0YzM1ODc2NC50eHQgbmV3Cj4gZmlsZSBtb2RlIDEwMDY0NAo+ IGluZGV4IDAwMDAwMDAuLmQwOWJkYzIKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3Rvc2hpYmEsdGMzNTg3NjQu dHh0Cj4gQEAgLTAsMCArMSw0MiBAQAo+ICtUQzM1ODc2NCBNSVBJLURTSSB0byBMVkRTIHBhbmVs IGJyaWRnZQo+ICsKPiArUmVxdWlyZWQgcHJvcGVydGllczoKPiArICAtIGNvbXBhdGlibGU6ICJ0 b3NoaWJhLHRjMzU4NzY0Igo+ICsgIC0gcmVnOiB0aGUgdmlydHVhbCBjaGFubmVsIG51bWJlciBv ZiBhIERTSSBwZXJpcGhlcmFsCj4gKyAgLSB2ZGRjLXN1cHBseTogY29yZSB2b2x0YWdlIHN1cHBs eQo+ICsgIC0gdmRkaW8tc3VwcGx5OiBJL08gdm9sdGFnZSBzdXBwbHkKPiArICAtIHZkZG1pcGkt c3VwcGx5OiBNSVBJIHZvbHRhZ2Ugc3VwcGx5Cj4gKyAgLSB2ZGRsdmRzMTMzLXN1cHBseTogTFZE UzEgMy4zViB2b2x0YWdlIHN1cHBseQo+ICsgIC0gdmRkbHZkczExMi1zdXBwbHk6IExWRFMxIDEu MlYgdm9sdGFnZSBzdXBwbHkKClRoYXQncyBhIGxvdCBvZiBwb3dlciBzdXBwbGllcy4gQ291bGQg c29tZSBvZiB0aGVtIGJlIG1lcmdlZCB0b2dldGhlciA/IFNlZSAKaHR0cHM6Ly9wYXRjaHdvcmsu ZnJlZWRlc2t0b3Aub3JnL3BhdGNoLzIxNjA1OC8gZm9yIGFuIGVhcmxpZXIgZGlzY3Vzc2lvbiBv biAKdGhlIHNhbWUgc3ViamVjdC4KCj4gKyAgLSByZXNldC1ncGlvczogYSBHUElPIHNwZWMgZm9y IHRoZSByZXNldCBwaW4KPiArCj4gK1RoZSBkZXZpY2Ugbm9kZSBjYW4gY29udGFpbiB6ZXJvIHRv IHR3byAncG9ydCcgY2hpbGQgbm9kZXMsIGVhY2ggd2l0aCBvbmUKPiArY2hpbGQKPiArJ2VuZHBv aW50JyBub2RlLCBhY2NvcmRpbmcgdG8gdGhlIGJpbmRpbmdzIGRlZmluZWQgaW4gWzFdLgo+ICtU aGUgZm9sbG93aW5nIGFyZSBwcm9wZXJ0aWVzIHNwZWNpZmljIHRvIHRob3NlIG5vZGVzLgo+ICsK PiArcG9ydDoKPiArICAtIHJlZzogKHJlcXVpcmVkKSBjYW4gYmUgMCBmb3IgRFNJIHBvcnQgb3Ig MSBmb3IgTFZEUyBwb3J0OwoKVGhpcyBzZWVtcyBwcmV0dHkgdmFndWUgdG8gbWUuIEl0IGNvdWxk IGJlIHJlYWQgYXMgbWVhbmluZyB0aGF0IHBvcnRzIGFyZSAKY29tcGxldGVseSBvcHRpb25hbCwg YW5kIHRoYXQgdGhlIHBvcnQgbnVtYmVyIHlvdSBsaXN0IGNhbiBiZSB1c2VkLCBidXQgdGhhdCAK c29tZXRoaW5nIGVsc2UgY291bGQgYmUgdXNlZCB0by4KCkxldCdzIG1ha2UgdGhlIHBvcnQgbm9k ZXMgbWFuZGF0b3J5LiBJIHByb3Bvc2UgdGhlIGZvbGxvd2luZy4KClJlcXVpcmVkIG5vZGVzOgoK VGhlIFRDMzU4NzY0IGhhcyBEU0kgYW5kIExWRFMgcG9ydHMgd2hvc2UgY29ubmVjdGlvbnMgYXJl IGRlc2NyaWJlZCB1c2luZyB0aGUgCk9GIGdyYXBoIGJpbmRpbmdzIGRlZmluZWQgaW4gRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2dyYXBoLnR4dC4gVGhlIApkZXZpY2Ugbm9kZSBt dXN0IGNvbnRhaW4gb25lICdwb3J0JyBjaGlsZCBub2RlIHBlciBEU0kgYW5kIExWRFMgcG9ydC4g VGhlIHBvcnQgCm5vZGVzIGFyZSBudW1iZXJlZCBhcyBmb2xsb3dzLgoKICBQb3J0ICAgICAgICAg ICAgICAgICAgTnVtYmVyCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICBEU0kgSW5wdXQgICAgICAgICAgICAgMAogIExW RFMgT3V0cHV0ICAgICAgICAgICAxCgpFYWNoIHBvcnQgbm9kZSBtdXN0IGNvbnRhaW4gZW5kcG9p bnQgbm9kZXMgZGVzY3JpYmluZyB0aGUgaGFyZHdhcmUgCmNvbm5lY3Rpb25zLgoKPiArWzFdOiBE b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVkaWEvdmlkZW8taW50ZXJmYWNlcy50 eHQKPiArCj4gK0V4YW1wbGU6Cj4gKwo+ICsJYnJpZGdlQDAgewo+ICsJCXJlZyA9IDwwPjsKPiAr CQljb21wYXRpYmxlID0gInRvc2hpYmEsdGMzNTg3NjQiOwo+ICsJCXZkZGMtc3VwcGx5ID0gPCZ2 Y2NfMXYyX3JlZz47Cj4gKwkJdmRkaW8tc3VwcGx5ID0gPCZ2Y2NfMXY4X3JlZz47Cj4gKwkJdmRk bWlwaS1zdXBwbHkgPSA8JnZjY18xdjJfcmVnPjsKPiArCQl2ZGRsdmRzMTMzLXN1cHBseSA9IDwm dmNjXzN2M19yZWc+Owo+ICsJCXZkZGx2ZHMxMTItc3VwcGx5ID0gPCZ2Y2NfMXYyX3JlZz47Cj4g KwkJcmVzZXQtZ3Bpb3MgPSA8JmdwZDEgNiBHUElPX0FDVElWRV9MT1c+Owo+ICsJCSNhZGRyZXNz LWNlbGxzID0gPDE+Owo+ICsJCSNzaXplLWNlbGxzID0gPDA+Owo+ICsJCXBvcnRAMSB7Cj4gKwkJ CXJlZyA9IDwxPjsKPiArCQkJbHZkc19lcDogZW5kcG9pbnQgewo+ICsJCQkJcmVtb3RlLWVuZHBv aW50ID0gPCZwYW5lbF9lcD47Cj4gKwkJCX07Cj4gKwkJfTsKPiArCX07CgotLSAKUmVnYXJkcywK CkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Mon, 28 May 2018 13:18:36 +0300 Subject: [PATCH 07/12] dt-bindings: tc358754: add DT bindings In-Reply-To: <1527500833-16005-8-git-send-email-m.purski@samsung.com> References: <1527500833-16005-1-git-send-email-m.purski@samsung.com> <1527500833-16005-8-git-send-email-m.purski@samsung.com> Message-ID: <2275901.CJI6BsfBlP@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Maciej, Thank you for the patch. On Monday, 28 May 2018 12:47:11 EEST Maciej Purski wrote: > The patch adds bindings to Toshiba DSI/LVDS bridge TC358764. > Bindings describe power supplies, reset gpio and video interfaces. > > Signed-off-by: Andrzej Hajda > Signed-off-by: Maciej Purski > --- > .../bindings/display/bridge/toshiba,tc358764.txt | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/bridge/toshiba,tc358764.txt > > diff --git > a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358764.txt > b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358764.txt new > file mode 100644 > index 0000000..d09bdc2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358764.txt > @@ -0,0 +1,42 @@ > +TC358764 MIPI-DSI to LVDS panel bridge > + > +Required properties: > + - compatible: "toshiba,tc358764" > + - reg: the virtual channel number of a DSI peripheral > + - vddc-supply: core voltage supply > + - vddio-supply: I/O voltage supply > + - vddmipi-supply: MIPI voltage supply > + - vddlvds133-supply: LVDS1 3.3V voltage supply > + - vddlvds112-supply: LVDS1 1.2V voltage supply That's a lot of power supplies. Could some of them be merged together ? See https://patchwork.freedesktop.org/patch/216058/ for an earlier discussion on the same subject. > + - reset-gpios: a GPIO spec for the reset pin > + > +The device node can contain zero to two 'port' child nodes, each with one > +child > +'endpoint' node, according to the bindings defined in [1]. > +The following are properties specific to those nodes. > + > +port: > + - reg: (required) can be 0 for DSI port or 1 for LVDS port; This seems pretty vague to me. It could be read as meaning that ports are completely optional, and that the port number you list can be used, but that something else could be used to. Let's make the port nodes mandatory. I propose the following. Required nodes: The TC358764 has DSI and LVDS ports whose connections are described using the OF graph bindings defined in Documentation/devicetree/bindings/graph.txt. The device node must contain one 'port' child node per DSI and LVDS port. The port nodes are numbered as follows. Port Number ------------------------------------------------------------------- DSI Input 0 LVDS Output 1 Each port node must contain endpoint nodes describing the hardware connections. > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > + > +Example: > + > + bridge at 0 { > + reg = <0>; > + compatible = "toshiba,tc358764"; > + vddc-supply = <&vcc_1v2_reg>; > + vddio-supply = <&vcc_1v8_reg>; > + vddmipi-supply = <&vcc_1v2_reg>; > + vddlvds133-supply = <&vcc_3v3_reg>; > + vddlvds112-supply = <&vcc_1v2_reg>; > + reset-gpios = <&gpd1 6 GPIO_ACTIVE_LOW>; > + #address-cells = <1>; > + #size-cells = <0>; > + port at 1 { > + reg = <1>; > + lvds_ep: endpoint { > + remote-endpoint = <&panel_ep>; > + }; > + }; > + }; -- Regards, Laurent Pinchart