From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52127C433DB for ; Mon, 25 Jan 2021 11:03:16 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 6527021BE5 for ; Mon, 25 Jan 2021 11:03:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6527021BE5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F97C140EEE; Mon, 25 Jan 2021 12:03:14 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 28C68140EED for ; Mon, 25 Jan 2021 12:03:13 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id CEC935C0109; Mon, 25 Jan 2021 06:03:12 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 25 Jan 2021 06:03:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= Ah0LSzjEnAh9ZpDXwcZet3RTZoS+gZCNBDVHJ9GBaxA=; b=SchDdqYU0sX48juA gtLYQIGrVBXd1FN+R19pRfA+pZsDAByBGMxqahGycsSGR3zdErwL60JtgQEklnmh CEZYbMVu7m6q2mqPqljuZ1NQ9oUk00vl403Q7Ik5LQ7MnFxJbAkq59gDX05840ZI qCXYUeDBdXI02mJG7s4nznsCUJdqQUIsF/FlmXT96bvzNWN4kxa5AZg2O8cJT0PX +7cl0SdS7CIAr3M2o2pdR3kfhSvo1BC+cvvvgzFsH7oxZ8vo8wfOQbqDE9WY8t6L F0HFH7R1Ro2YYQRkkfjK78X2SrtIghfYKeAg07C3Ih9ZPD9qQWt3RU56XDGI2KAn aP/bBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Ah0LSzjEnAh9ZpDXwcZet3RTZoS+gZCNBDVHJ9GBa xA=; b=M7jQYNoQw6rDDX/hmj1WtTGkHT4o+QlLcINaed6j/+JaQPCtrRgetvR3w mOHrSnmBgouN9RYCa650fFbuL8M7f49nr+42So6n336jQ9+ai9haAYA+IuRxlFxt yGzns6jX1psRWrBg+dv61Me+3qqvFRuSQBof34pyd40/cyNP+mZWGt9yfJ+4t7bA 8vEh2e823mujs+7SnGDAyr3zFPnwVyUL1uK3elQpwwyipD6oM5/x/cC5sRB0FG3x y6LbTMWTRVZqiTRZ3Murr2DbdAsn9wlmfV4hKfJ2pPRE1MjMjlZb8HQfyViuKDkS 1wIaIB0L8z2t8PJ6limGvFasZWI6Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 82C1224005E; Mon, 25 Jan 2021 06:03:11 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: "Kinsella, Ray" , dev , Dmitry Kozlyuk Date: Mon, 25 Jan 2021 12:03:08 +0100 Message-ID: <2277343.39N8RZBLj0@thomas> In-Reply-To: <3e6d199a-57ee-8e6a-0176-d04c1fc870be@ashroe.eu> References: <20201014183136.22239-1-dmitry.kozliuk@gmail.com> <3e6d199a-57ee-8e6a-0176-d04c1fc870be@ashroe.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/01/2021 11:46, Kinsella, Ray: > On 25/01/2021 10:29, David Marchand wrote: > > The symbol itself can be hidden from the ABeyes. > > It is only a placeholder for the PMD_INFO_STRING= string used by > > usertools/dpdk-pmdinfo.py and maybe some other parsing tool. > > > > I guess a static symbol would be enough: > > > > diff --git a/buildtools/pmdinfogen/pmdinfogen.c > > b/buildtools/pmdinfogen/pmdinfogen.c > > index a68d1ea999..14bf7d9f42 100644 > > --- a/buildtools/pmdinfogen/pmdinfogen.c > > +++ b/buildtools/pmdinfogen/pmdinfogen.c > > @@ -393,7 +393,7 @@ static void output_pmd_info_string(struct elf_info > > *info, char *outfile) > > drv = info->drivers; > > > > while (drv) { > > - fprintf(ofd, "const char %s_pmd_info[] __attribute__((used)) = " > > + fprintf(ofd, "static const char %s_pmd_info[] > > __attribute__((used)) = " > > "\"PMD_INFO_STRING= {", > > drv->name); > > fprintf(ofd, "\\\"name\\\" : \\\"%s\\\", ", drv->name); > > > > > > We will need an exception for the v21 ABI though. > > > > Good suggestion +1 Yes +1 for adding static on *_pmd_info