From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751337AbdFXIij (ORCPT ); Sat, 24 Jun 2017 04:38:39 -0400 Received: from gloria.sntech.de ([95.129.55.99]:47092 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbdFXIih (ORCPT ); Sat, 24 Jun 2017 04:38:37 -0400 From: Heiko Stuebner To: Andrew Lunn Cc: David Wu , davem@davemloft.net, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, olof@lixom.net, linux@armlinux.org.uk, arnd@arndb.de, f.fainelli@gmail.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, huangtao@rock-chips.com, hwg@rock-chips.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/11] net: phy: Add rockchip phy driver support Date: Sat, 24 Jun 2017 10:38:13 +0200 Message-ID: <2277908.rG2NXdikOp@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <20170624021910.GB4875@lunn.ch> References: <1498192929-7519-1-git-send-email-david.wu@rock-chips.com> <1498192929-7519-2-git-send-email-david.wu@rock-chips.com> <20170624021910.GB4875@lunn.ch> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Samstag, 24. Juni 2017, 04:19:10 CEST schrieb Andrew Lunn: > On Fri, Jun 23, 2017 at 12:41:59PM +0800, David Wu wrote: > > Support internal ephy currently. > > > > Signed-off-by: David Wu > > --- > > drivers/net/phy/Kconfig | 4 ++ > > drivers/net/phy/Makefile | 1 + > > drivers/net/phy/rockchip.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 99 insertions(+) > > create mode 100644 drivers/net/phy/rockchip.c > > > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > > index c360dd6..86010d4 100644 > > --- a/drivers/net/phy/Kconfig > > +++ b/drivers/net/phy/Kconfig > > @@ -350,6 +350,10 @@ config XILINX_GMII2RGMII > > the Reduced Gigabit Media Independent Interface(RGMII) between > > Ethernet physical media devices and the Gigabit Ethernet controller. > > > > +config ROCKCHIP_MAC_PHY > > This is a bit of an odd name, having both MAC and PHY in it. Are there > any other RockChip PHYs? Any external PHYS? Are they register > incompatible with the internal PHY? Is it even RockChip IP? Or has it > been licensed from somebody else? > > I would more likely just call it ROCKCHIP_PHY. hmm, we do have quite a number of non-net phys in the phy subsystem (DP, PCIe, ...) and given that the above would be CONFIG_ROCKCHIP_PHY in a global sense, sounds like it could make things confusing. So some addition sounds reasonable ... ROCKCHIP_ETH_PHY or so? Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 01/11] net: phy: Add rockchip phy driver support Date: Sat, 24 Jun 2017 10:38:13 +0200 Message-ID: <2277908.rG2NXdikOp@phil> References: <1498192929-7519-1-git-send-email-david.wu@rock-chips.com> <1498192929-7519-2-git-send-email-david.wu@rock-chips.com> <20170624021910.GB4875@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: David Wu , davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, peppe.cavallaro-qxv4g6HH51o@public.gmane.org, alexandre.torgue-qxv4g6HH51o@public.gmane.org, huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, hwg-TNX95d0MmH7DzftRWevZcw@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Lunn Return-path: In-Reply-To: <20170624021910.GB4875-g2DYL2Zd6BY@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Am Samstag, 24. Juni 2017, 04:19:10 CEST schrieb Andrew Lunn: > On Fri, Jun 23, 2017 at 12:41:59PM +0800, David Wu wrote: > > Support internal ephy currently. > > > > Signed-off-by: David Wu > > --- > > drivers/net/phy/Kconfig | 4 ++ > > drivers/net/phy/Makefile | 1 + > > drivers/net/phy/rockchip.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 99 insertions(+) > > create mode 100644 drivers/net/phy/rockchip.c > > > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > > index c360dd6..86010d4 100644 > > --- a/drivers/net/phy/Kconfig > > +++ b/drivers/net/phy/Kconfig > > @@ -350,6 +350,10 @@ config XILINX_GMII2RGMII > > the Reduced Gigabit Media Independent Interface(RGMII) between > > Ethernet physical media devices and the Gigabit Ethernet controller. > > > > +config ROCKCHIP_MAC_PHY > > This is a bit of an odd name, having both MAC and PHY in it. Are there > any other RockChip PHYs? Any external PHYS? Are they register > incompatible with the internal PHY? Is it even RockChip IP? Or has it > been licensed from somebody else? > > I would more likely just call it ROCKCHIP_PHY. hmm, we do have quite a number of non-net phys in the phy subsystem (DP, PCIe, ...) and given that the above would be CONFIG_ROCKCHIP_PHY in a global sense, sounds like it could make things confusing. So some addition sounds reasonable ... ROCKCHIP_ETH_PHY or so? Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Sat, 24 Jun 2017 10:38:13 +0200 Subject: [PATCH 01/11] net: phy: Add rockchip phy driver support In-Reply-To: <20170624021910.GB4875@lunn.ch> References: <1498192929-7519-1-git-send-email-david.wu@rock-chips.com> <1498192929-7519-2-git-send-email-david.wu@rock-chips.com> <20170624021910.GB4875@lunn.ch> Message-ID: <2277908.rG2NXdikOp@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Samstag, 24. Juni 2017, 04:19:10 CEST schrieb Andrew Lunn: > On Fri, Jun 23, 2017 at 12:41:59PM +0800, David Wu wrote: > > Support internal ephy currently. > > > > Signed-off-by: David Wu > > --- > > drivers/net/phy/Kconfig | 4 ++ > > drivers/net/phy/Makefile | 1 + > > drivers/net/phy/rockchip.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 99 insertions(+) > > create mode 100644 drivers/net/phy/rockchip.c > > > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > > index c360dd6..86010d4 100644 > > --- a/drivers/net/phy/Kconfig > > +++ b/drivers/net/phy/Kconfig > > @@ -350,6 +350,10 @@ config XILINX_GMII2RGMII > > the Reduced Gigabit Media Independent Interface(RGMII) between > > Ethernet physical media devices and the Gigabit Ethernet controller. > > > > +config ROCKCHIP_MAC_PHY > > This is a bit of an odd name, having both MAC and PHY in it. Are there > any other RockChip PHYs? Any external PHYS? Are they register > incompatible with the internal PHY? Is it even RockChip IP? Or has it > been licensed from somebody else? > > I would more likely just call it ROCKCHIP_PHY. hmm, we do have quite a number of non-net phys in the phy subsystem (DP, PCIe, ...) and given that the above would be CONFIG_ROCKCHIP_PHY in a global sense, sounds like it could make things confusing. So some addition sounds reasonable ... ROCKCHIP_ETH_PHY or so? Heiko