From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63BEFC31E40 for ; Tue, 6 Aug 2019 15:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2244D2070D for ; Tue, 6 Aug 2019 15:53:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=dell.com header.i=@dell.com header.b="o+BipkYN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733304AbfHFPxL (ORCPT ); Tue, 6 Aug 2019 11:53:11 -0400 Received: from mx0a-00154904.pphosted.com ([148.163.133.20]:17648 "EHLO mx0a-00154904.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729161AbfHFPxK (ORCPT ); Tue, 6 Aug 2019 11:53:10 -0400 Received: from pps.filterd (m0170391.ppops.net [127.0.0.1]) by mx0a-00154904.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x76FZUkM025412 for ; Tue, 6 Aug 2019 11:53:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=smtpout1; bh=nfYxhfi86doHjndXXSZxZRT3NfXpSWbxGGXXfgyCS/0=; b=o+BipkYNL0Rcc8Q8fpXCZy7ImK3eZUXoyxzMgPYdzPOUSHJ4jz8bKcE1/NGLbG196pwm cIWYvKRuARsYKR4jNi7cnjZptexjJJomXFi3T0F5KyH64LPUPxpVrJE10T7ccW9tllMQ Usz7R45mzaUHAGI1TxVbZ9m4hi1TR4+pw9PYFtjMHcElk35/Cv4hHkvd/yRJR5vvG5gF iDyOD/CRzQf0tXZv/R0PU58us2EgP0/oECflVpeYfeWJI6tMRJ1nfhVdDQRJfozm6oo7 aFp3WX66Q+HmbuTT1c1JBMR2Dkj8j+nGeVd9fidkQQeOXUMyYujX2tZ+Lk2mhF6tNQLG XQ== Received: from mx0a-00154901.pphosted.com (mx0a-00154901.pphosted.com [67.231.149.39]) by mx0a-00154904.pphosted.com with ESMTP id 2u7aqngnt3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 06 Aug 2019 11:53:10 -0400 Received: from pps.filterd (m0134746.ppops.net [127.0.0.1]) by mx0a-00154901.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x76FqsXL121317 for ; Tue, 6 Aug 2019 11:53:09 -0400 Received: from ausxippc101.us.dell.com (ausxippc101.us.dell.com [143.166.85.207]) by mx0a-00154901.pphosted.com with ESMTP id 2u7acrtmj3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 06 Aug 2019 11:53:09 -0400 X-LoopCount0: from 10.166.132.127 X-PREM-Routing: D-Outbound X-IronPort-AV: E=Sophos;i="5.60,346,1549951200"; d="scan'208";a="1282221332" From: To: , CC: , Subject: RE: MDI errors during resume from ACPI S3 (suspend to ram) Thread-Topic: MDI errors during resume from ACPI S3 (suspend to ram) Thread-Index: AQHVTGy4cv+XwO2TC0mYS3+6gWgQH6buROIg Date: Tue, 6 Aug 2019 15:53:06 +0000 Message-ID: <2277f25bc44c4aebaac59942de2e24bb@AUSX13MPC105.AMER.DELL.COM> References: <81004059-6d91-d8be-c80e-70c52359350d@molgen.mpg.de> In-Reply-To: <81004059-6d91-d8be-c80e-70c52359350d@molgen.mpg.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Enabled=True; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Owner=Mario_Limonciello@Dell.com; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SetDate=2019-08-06T15:53:05.0856508Z; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Name=External Public; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Application=Microsoft Azure Information Protection; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Extended_MSFT_Method=Manual; aiplabel=External Public x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-06_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908060152 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908060151 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBQYXVsIE1lbnplbCA8cG1lbnpl bEBtb2xnZW4ubXBnLmRlPg0KPiBTZW50OiBUdWVzZGF5LCBBdWd1c3QgNiwgMjAxOSAxMDozNiBB TQ0KPiBUbzogSmVmZiBLaXJzaGVyDQo+IENjOiBpbnRlbC13aXJlZC1sYW5AbGlzdHMub3N1b3Ns Lm9yZzsgTGludXggS2VybmVsIE1haWxpbmcgTGlzdDsgTGltb25jaWVsbG8sIE1hcmlvDQo+IFN1 YmplY3Q6IE1ESSBlcnJvcnMgZHVyaW5nIHJlc3VtZSBmcm9tIEFDUEkgUzMgKHN1c3BlbmQgdG8g cmFtKQ0KPiANCj4gRGVhciBMaW51eCBmb2xrcywNCj4gDQo+IA0KPiBUcnlpbmcgdG8gZGVjcmVh c2UgdGhlIHJlc3VtZSB0aW1lIG9mIExpbnV4IDUuMy1yYzMgb24gdGhlIERlbGwgT3B0aVBsZXgN Cj4gNTA0MCB3aXRoIHRoZSBkZXZpY2UgYmVsb3cNCj4gDQo+ICAgICAkIGxzcGNpIC1ubiAtcyAw MDoxZi42DQo+ICAgICAwMDoxZi42IEV0aGVybmV0IGNvbnRyb2xsZXIgWzAyMDBdOiBJbnRlbCBD b3Jwb3JhdGlvbiBFdGhlcm5ldCBDb25uZWN0aW9uICgyKQ0KPiBJMjE5LVYgWzgwODY6MTViOF0g KHJldiAzMSkNCj4gDQo+IHBtLWdyYXBo4oCZcyBzY3JpcHQgYHNsZWVwZ3JhcGgucHlgIHNob3dz LCB0aGF0IHRoZSBkcml2ZXIgKmUxMDAwZSogdGFrZXMNCj4gYXJvdW5kIDQwMCBtcywgd2hpY2gg aXMgcXVpdGUgYSBsb3QuIFRoZSBjYWxsIGdyYXBoIHRyYWNlIHNob3dzIHRoYXQNCj4gYGUxMDAw ZV9yZWFkX3BoeV9yZWdfbWRpYygpYCBpcyByZXNwb25zaWJsZSBmb3IgYSBsb3Qgb2YgdGhvc2Uu IEZyb20NCj4gYGRyaXZlcnMvbmV0L2V0aGVybmV0L2ludGVsL2UxMDAwZS9waHkuY2AgWzFdOg0K PiANCj4gICAgICAgICBmb3IgKGkgPSAwOyBpIDwgKEUxMDAwX0dFTl9QT0xMX1RJTUVPVVQgKiAz KTsgaSsrKSB7DQo+ICAgICAgICAgICAgICAgICB1ZGVsYXkoNTApOw0KPiAgICAgICAgICAgICAg ICAgbWRpYyA9IGVyMzIoTURJQyk7DQo+ICAgICAgICAgICAgICAgICBpZiAobWRpYyAmIEUxMDAw X01ESUNfUkVBRFkpDQo+ICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOw0KPiAgICAgICAg IH0NCj4gICAgICAgICBpZiAoIShtZGljICYgRTEwMDBfTURJQ19SRUFEWSkpIHsNCj4gICAgICAg ICAgICAgICAgIGVfZGJnKCJNREkgUmVhZCBkaWQgbm90IGNvbXBsZXRlXG4iKTsNCj4gICAgICAg ICAgICAgICAgIHJldHVybiAtRTEwMDBfRVJSX1BIWTsNCj4gICAgICAgICB9DQo+ICAgICAgICAg aWYgKG1kaWMgJiBFMTAwMF9NRElDX0VSUk9SKSB7DQo+ICAgICAgICAgICAgICAgICBlX2RiZygi TURJIEVycm9yXG4iKTsNCj4gICAgICAgICAgICAgICAgIHJldHVybiAtRTEwMDBfRVJSX1BIWTsN Cj4gICAgICAgICB9DQo+IA0KPiBVbmZvcnR1bmF0ZWx5LCBlcnJvcnMgYXJlIG5vdCBsb2dnZWQg aWYgZHluYW1pYyBkZWJ1ZyBpcyBkaXNhYmxlZCwNCj4gc28gcmVidWlsZGluZyB0aGUgTGludXgg a2VybmVsIHdpdGggYENPTkZJR19EWU5BTUlDX0RFQlVHYCwgYW5kDQo+IA0KPiAgICAgZWNobyAi ZmlsZSBkcml2ZXJzL25ldC9ldGhlcm5ldC8qICtwIiB8IHN1ZG8gdGVlDQo+IC9zeXMva2VybmVs L2RlYnVnL2R5bmFtaWNfZGVidWcvY29udHJvbA0KPiANCj4gSSBnb3QgdGhlIG1lc3NhZ2VzIGJl bG93Lg0KPiANCj4gICAgIFsgNDE1OS4yMDQxOTJdIGUxMDAwZSAwMDAwOjAwOjFmLjYgbmV0MDA6 IE1ESSBFcnJvcg0KPiAgICAgWyA0MTYwLjI2Nzk1MF0gZTEwMDBlIDAwMDA6MDA6MWYuNiBuZXQw MDogTURJIFdyaXRlIGRpZCBub3QgY29tcGxldGUNCj4gICAgIFsgNDE2MC4zNTk4NTVdIGUxMDAw ZSAwMDAwOjAwOjFmLjYgbmV0MDA6IE1ESSBFcnJvcg0KPiANCj4gQ2FuIHlvdSBwbGVhc2Ugc2hl ZCBhIGxpdHRsZSBtb3JlIGxpZ2h0IGludG8gdGhlc2UgZXJyb3JzPyBQbGVhc2UNCj4gZmluZCB0 aGUgZnVsbCBsb2cgYXR0YWNoZWQuDQo+IA0KPiANCj4gS2luZCByZWdhcmRzLA0KPiANCj4gUGF1 bA0KPiANCj4gDQo+IFsxXToNCj4gaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4 L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0L3RyZWUvZHJpdmVycy9uDQo+IGV0L2V0aGVy bmV0L2ludGVsL2UxMDAwZS9waHkuYyNuMjA2DQoNClN0cmljdGx5IGFzIGEgcmVmZXJlbmNlIHBv aW50IHlvdSBtYXkgY29uc2lkZXIgdHJ5aW5nIHRoZSBvdXQtb2YtdHJlZSBkcml2ZXIgdG8gc2Vl IGlmIHRoZXNlDQpiZWhhdmlvcnMgcGVyc2lzdC4NCg0KaHR0cHM6Ly9zb3VyY2Vmb3JnZS5uZXQv cHJvamVjdHMvZTEwMDAvDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario.Limonciello@dell.com Date: Tue, 6 Aug 2019 15:53:06 +0000 Subject: [Intel-wired-lan] MDI errors during resume from ACPI S3 (suspend to ram) In-Reply-To: <81004059-6d91-d8be-c80e-70c52359350d@molgen.mpg.de> References: <81004059-6d91-d8be-c80e-70c52359350d@molgen.mpg.de> Message-ID: <2277f25bc44c4aebaac59942de2e24bb@AUSX13MPC105.AMER.DELL.COM> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: > -----Original Message----- > From: Paul Menzel > Sent: Tuesday, August 6, 2019 10:36 AM > To: Jeff Kirsher > Cc: intel-wired-lan at lists.osuosl.org; Linux Kernel Mailing List; Limonciello, Mario > Subject: MDI errors during resume from ACPI S3 (suspend to ram) > > Dear Linux folks, > > > Trying to decrease the resume time of Linux 5.3-rc3 on the Dell OptiPlex > 5040 with the device below > > $ lspci -nn -s 00:1f.6 > 00:1f.6 Ethernet controller [0200]: Intel Corporation Ethernet Connection (2) > I219-V [8086:15b8] (rev 31) > > pm-graph?s script `sleepgraph.py` shows, that the driver *e1000e* takes > around 400 ms, which is quite a lot. The call graph trace shows that > `e1000e_read_phy_reg_mdic()` is responsible for a lot of those. From > `drivers/net/ethernet/intel/e1000e/phy.c` [1]: > > for (i = 0; i < (E1000_GEN_POLL_TIMEOUT * 3); i++) { > udelay(50); > mdic = er32(MDIC); > if (mdic & E1000_MDIC_READY) > break; > } > if (!(mdic & E1000_MDIC_READY)) { > e_dbg("MDI Read did not complete\n"); > return -E1000_ERR_PHY; > } > if (mdic & E1000_MDIC_ERROR) { > e_dbg("MDI Error\n"); > return -E1000_ERR_PHY; > } > > Unfortunately, errors are not logged if dynamic debug is disabled, > so rebuilding the Linux kernel with `CONFIG_DYNAMIC_DEBUG`, and > > echo "file drivers/net/ethernet/* +p" | sudo tee > /sys/kernel/debug/dynamic_debug/control > > I got the messages below. > > [ 4159.204192] e1000e 0000:00:1f.6 net00: MDI Error > [ 4160.267950] e1000e 0000:00:1f.6 net00: MDI Write did not complete > [ 4160.359855] e1000e 0000:00:1f.6 net00: MDI Error > > Can you please shed a little more light into these errors? Please > find the full log attached. > > > Kind regards, > > Paul > > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/n > et/ethernet/intel/e1000e/phy.c#n206 Strictly as a reference point you may consider trying the out-of-tree driver to see if these behaviors persist. https://sourceforge.net/projects/e1000/