From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 119BDC433EF for ; Mon, 27 Jun 2022 09:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233956AbiF0JRz (ORCPT ); Mon, 27 Jun 2022 05:17:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233938AbiF0JRu (ORCPT ); Mon, 27 Jun 2022 05:17:50 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23144639C for ; Mon, 27 Jun 2022 02:17:40 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id eo8so12112401edb.0 for ; Mon, 27 Jun 2022 02:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=j45LSOHH3JiD4etOLa648Qq9hJpooPqyedr7q+VjXHU=; b=ufwbGIdKNbXPH8Wz04so0lL3KGsbit4ttintNEHvPRPe+Kt4AdOJOOMOUYmCFo1tnu eR14C9G92k19LoxmXRkN/ZJrgPVtIqoxjy5S5Cv41g9b+nRCSuZbV/E1IONtlHLgPxuX lCdNMnCg9xD6MK5wLh3M4U38b3SCxZ2x8++tKsWkfhoBWgfjhLrAAtjC2RAiusWs7vws /i2JY1CLzP7ma+mvGp/Lo66H8GP8SoVFsLo4fNQzttC2xq+bgfYojxKZVXf9ZxQe7Tp2 ZKFJ5Eyuwviit4SZjs4aD5R3T6bKWBgI1JIvBqDHCwlRwx5Eigju0gXmhOV4BgBTnt8Y x6fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=j45LSOHH3JiD4etOLa648Qq9hJpooPqyedr7q+VjXHU=; b=DvmHA8+CpQVaNJrxOqrsDa75YxPt3v8O78KsBtCWjkCqIC42U2TjnQADPyDdKlPui+ gsycniHRffSe9S6SzHIygUVLdp1XfZVRyoI5sSD0KlOSHTFwi4hogX4TbNc23th+JndR 5hrD+DwEHq7QkGLjPQoIP/VdCDbe+OZHLBdA99zDqaTG9GpVI4y6P106A1B8KbmcCqtg ACSgfh1Pfn5nKd3Yl4Ker93CRVE0a10tIo2PhMmZeqHAH804F9gx+uYH9mbLayY0TspG iUZWrX5rHla7hV7vQP5mYpxSIEBVeoYkR3m4qglalWCaCAnDl+rzcLe3srZreWh7/S3p ziVA== X-Gm-Message-State: AJIora8h7L7EeFhRuJHnsICobEcEQk4BrJe4HZXbI3Kd7OGrkciZ03JQ JorzhrOd6Ct+bmA/SCf6X1E+jQ== X-Google-Smtp-Source: AGRyM1sywnG4AoJoUKNejA/e+NFvcRiA0U6+mWnexBl80A39LsB4bnm6VB95gY/41HlbVTxa8ZqdRw== X-Received: by 2002:aa7:d484:0:b0:435:65b0:e2d8 with SMTP id b4-20020aa7d484000000b0043565b0e2d8mr15314344edr.373.1656321458755; Mon, 27 Jun 2022 02:17:38 -0700 (PDT) Received: from [192.168.0.247] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id l2-20020a170906078200b006fe89cafc42sm4840141ejc.172.2022.06.27.02.17.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jun 2022 02:17:38 -0700 (PDT) Message-ID: <227af263-e52e-d2bb-2467-77c6439bad79@linaro.org> Date: Mon, 27 Jun 2022 11:17:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] dt-bindings: i2c: Document RZ/V2M I2C controller Content-Language: en-US To: Phil Edworthy , Rob Herring , Krzysztof Kozlowski Cc: Biju Das , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , Geert Uytterhoeven , "linux-renesas-soc@vger.kernel.org" References: <20220624101736.27217-1-phil.edworthy@renesas.com> <20220624101736.27217-2-phil.edworthy@renesas.com> <2f2b2544-9c53-3a6a-d9c9-375e75b112f3@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/06/2022 09:17, Phil Edworthy wrote: > Hi Krzysztof, > > Thanks for you review. > > On 25 June 2022 21:43 Krzysztof Kozlowski wrote: >> On 24/06/2022 12:17, Phil Edworthy wrote: >>> Document Renesas RZ/V2M (r9a09g011) I2C controller bindings. >>> >>> Signed-off-by: Phil Edworthy >>> Reviewed-by: Biju Das >>> --- >>> .../bindings/i2c/renesas,rzv2m.yaml | 76 +++++++++++++++++++ >>> 1 file changed, 76 insertions(+) >>> create mode 100644 >> Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml >> b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml >>> new file mode 100644 >>> index 000000000000..9049461ad2f4 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml >>> @@ -0,0 +1,76 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/i2c/renesas,rzv2m.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Renesas RZ/V2M I2C Bus Interface >>> + >>> +maintainers: >>> + - Phil Edworthy >>> + >>> +allOf: >>> + - $ref: /schemas/i2c/i2c-controller.yaml# >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - renesas,i2c-r9a09g011 # RZ/V2M >>> + - const: renesas,rzv2m-i2c >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + interrupts: >>> + items: >>> + - description: Data transmission/reception interrupt >>> + - description: Status interrupt >>> + >>> + interrupt-names: >>> + items: >>> + - const: tia >>> + - const: tis >>> + >>> + clock-frequency: >>> + description: >>> + Desired I2C bus clock frequency in Hz. The absence of this >> property >>> + indicates the default frequency 100 kHz. >> >> Instead of last sentence, just add "default: 100000". > Right, I'll also and an enum for this as the HW can only support 100 > or 400kHz. Sure, sounds good. Thank you. Best regards, Krzysztof