From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6227C54EE9 for ; Mon, 19 Sep 2022 13:33:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbiISNdI (ORCPT ); Mon, 19 Sep 2022 09:33:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229964AbiISNc6 (ORCPT ); Mon, 19 Sep 2022 09:32:58 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35E1B21835 for ; Mon, 19 Sep 2022 06:32:57 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id B8264660159F; Mon, 19 Sep 2022 14:32:54 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1663594375; bh=TBhtk3gr4d0sylPaOG83cBfrnCWZRMcFZEocaCMqSfs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OaJ8GPRjLhVosM1A/PUElwHNEgeWvltDbM6oZu8+WuZmcnch01XPp21pn/ewA7V70 P45LJ1m110d2xmCzDAh517/7Pta90saLbYE0c+urvKeMONCZvH8BgM3pJbJARQ7SVM FZBFIfgtevaC0qCGU4ahm5D7/R+0SAMv28D8MJ6NCD8U1s/pB0dZZpLOPhDw7WqDNX QoN8TyOsZsIxjD662CnOZcP5ezoNbJJFsgyVApfT7v8TfJ66vITMJg8/p7RHdLLRZ6 rtI/adJF5CH4FxV/TH9+q6CZHYb9R8AZ6E6Jb5o7qNNklC5cyXo58Xp1tPX+RJVhgl 9E4Ee//hum6kA== Message-ID: <227bce07-37cc-da1d-fc99-065a12cdf3f5@collabora.com> Date: Mon, 19 Sep 2022 15:32:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] drm/mediatek: dsi: Move mtk_dsi_stop() call back to mtk_dsi_poweroff() Content-Language: en-US To: Hsin-Yi Wang , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Cc: Chun-Kuang Hu , kernel@collabora.com, Daniel Vetter , David Airlie , Jitao Shi , Matthias Brugger , Philipp Zabel , Rex-BC Chen , Xinlei Lee , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20220804194325.1596554-1-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 19/09/22 10:40, Hsin-Yi Wang ha scritto: > On Mon, Sep 19, 2022 at 4:39 PM Nícolas F. R. A. Prado > wrote: >> >> As the comment right before the mtk_dsi_stop() call advises, >> mtk_dsi_stop() should only be called after >> mtk_drm_crtc_atomic_disable(). That's because that function calls >> drm_crtc_wait_one_vblank(), which requires the vblank irq to be enabled. >> >> Previously mtk_dsi_stop(), being in mtk_dsi_poweroff() and guarded by a >> refcount, would only be called at the end of >> mtk_drm_crtc_atomic_disable(), through the call to mtk_crtc_ddp_hw_fini(). >> Commit cde7e2e35c28 ("drm/mediatek: Separate poweron/poweroff from >> enable/disable and define new funcs") moved the mtk_dsi_stop() call to >> mtk_output_dsi_disable(), causing it to be called before >> mtk_drm_crtc_atomic_disable(), and consequently generating vblank >> timeout warnings during suspend. >> >> Move the mtk_dsi_stop() call back to mtk_dsi_poweroff() so that we have >> a working vblank irq during mtk_drm_crtc_atomic_disable() and stop >> getting vblank timeout warnings. >> >> Fixes: cde7e2e35c28 ("drm/mediatek: Separate poweron/poweroff from enable/disable and define new funcs") >> Signed-off-by: Nícolas F. R. A. Prado >> > Tested-by: Hsin-Yi Wang > Reviewed-by: AngeloGioacchino Del Regno From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8542BC54EE9 for ; Mon, 19 Sep 2022 13:33:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9AB7A10E65E; Mon, 19 Sep 2022 13:33:02 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0471F10E645 for ; Mon, 19 Sep 2022 13:32:57 +0000 (UTC) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id B8264660159F; Mon, 19 Sep 2022 14:32:54 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1663594375; bh=TBhtk3gr4d0sylPaOG83cBfrnCWZRMcFZEocaCMqSfs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OaJ8GPRjLhVosM1A/PUElwHNEgeWvltDbM6oZu8+WuZmcnch01XPp21pn/ewA7V70 P45LJ1m110d2xmCzDAh517/7Pta90saLbYE0c+urvKeMONCZvH8BgM3pJbJARQ7SVM FZBFIfgtevaC0qCGU4ahm5D7/R+0SAMv28D8MJ6NCD8U1s/pB0dZZpLOPhDw7WqDNX QoN8TyOsZsIxjD662CnOZcP5ezoNbJJFsgyVApfT7v8TfJ66vITMJg8/p7RHdLLRZ6 rtI/adJF5CH4FxV/TH9+q6CZHYb9R8AZ6E6Jb5o7qNNklC5cyXo58Xp1tPX+RJVhgl 9E4Ee//hum6kA== Message-ID: <227bce07-37cc-da1d-fc99-065a12cdf3f5@collabora.com> Date: Mon, 19 Sep 2022 15:32:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] drm/mediatek: dsi: Move mtk_dsi_stop() call back to mtk_dsi_poweroff() Content-Language: en-US To: Hsin-Yi Wang , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= References: <20220804194325.1596554-1-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , Jitao Shi , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rex-BC Chen , linux-mediatek@lists.infradead.org, Matthias Brugger , kernel@collabora.com, linux-arm-kernel@lists.infradead.org, Xinlei Lee Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Il 19/09/22 10:40, Hsin-Yi Wang ha scritto: > On Mon, Sep 19, 2022 at 4:39 PM Nícolas F. R. A. Prado > wrote: >> >> As the comment right before the mtk_dsi_stop() call advises, >> mtk_dsi_stop() should only be called after >> mtk_drm_crtc_atomic_disable(). That's because that function calls >> drm_crtc_wait_one_vblank(), which requires the vblank irq to be enabled. >> >> Previously mtk_dsi_stop(), being in mtk_dsi_poweroff() and guarded by a >> refcount, would only be called at the end of >> mtk_drm_crtc_atomic_disable(), through the call to mtk_crtc_ddp_hw_fini(). >> Commit cde7e2e35c28 ("drm/mediatek: Separate poweron/poweroff from >> enable/disable and define new funcs") moved the mtk_dsi_stop() call to >> mtk_output_dsi_disable(), causing it to be called before >> mtk_drm_crtc_atomic_disable(), and consequently generating vblank >> timeout warnings during suspend. >> >> Move the mtk_dsi_stop() call back to mtk_dsi_poweroff() so that we have >> a working vblank irq during mtk_drm_crtc_atomic_disable() and stop >> getting vblank timeout warnings. >> >> Fixes: cde7e2e35c28 ("drm/mediatek: Separate poweron/poweroff from enable/disable and define new funcs") >> Signed-off-by: Nícolas F. R. A. Prado >> > Tested-by: Hsin-Yi Wang > Reviewed-by: AngeloGioacchino Del Regno From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E887DC54EE9 for ; Mon, 19 Sep 2022 13:34:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IAv5fFwRO8jYXR0WcvwxYrvztiZUvU97DObSQJzT7Iw=; b=txHLaHmUFW/qBK xlzxH84cLtJGa5tBQJLTL0/Qsa/GHXkS8M4FpnC6aDIcg7lfvLhFEfcsRxcEz9xl549edlmaKMTtn vNdKXRX+mrGUZvmSwjIKVDuiuFqSX5gZEjxRCPBxaw6/ObcTWJqunBZvhuC0eh4Cuxw1dArXVAHGp JRfXrFhWYZ39sYOrsRCH5mLxikJaAAqj/Wtxieto5Jq4K0HTxG4ljMNyYA/B8mrFIjqKe1rDxPCQa oxvQJ0cvQapRbtt6Chz88y+ZtedrwahUisJGPi4kUm9Hzdka9sUg0X39DVs4GlYPmedGenfKC2nIB UzzrGzSelK83PccFC4dQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaGtQ-00BshA-Qu; Mon, 19 Sep 2022 13:33:00 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaGtN-00Bsg7-PX; Mon, 19 Sep 2022 13:32:59 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id B8264660159F; Mon, 19 Sep 2022 14:32:54 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1663594375; bh=TBhtk3gr4d0sylPaOG83cBfrnCWZRMcFZEocaCMqSfs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OaJ8GPRjLhVosM1A/PUElwHNEgeWvltDbM6oZu8+WuZmcnch01XPp21pn/ewA7V70 P45LJ1m110d2xmCzDAh517/7Pta90saLbYE0c+urvKeMONCZvH8BgM3pJbJARQ7SVM FZBFIfgtevaC0qCGU4ahm5D7/R+0SAMv28D8MJ6NCD8U1s/pB0dZZpLOPhDw7WqDNX QoN8TyOsZsIxjD662CnOZcP5ezoNbJJFsgyVApfT7v8TfJ66vITMJg8/p7RHdLLRZ6 rtI/adJF5CH4FxV/TH9+q6CZHYb9R8AZ6E6Jb5o7qNNklC5cyXo58Xp1tPX+RJVhgl 9E4Ee//hum6kA== Message-ID: <227bce07-37cc-da1d-fc99-065a12cdf3f5@collabora.com> Date: Mon, 19 Sep 2022 15:32:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] drm/mediatek: dsi: Move mtk_dsi_stop() call back to mtk_dsi_poweroff() Content-Language: en-US To: Hsin-Yi Wang , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Cc: Chun-Kuang Hu , kernel@collabora.com, Daniel Vetter , David Airlie , Jitao Shi , Matthias Brugger , Philipp Zabel , Rex-BC Chen , Xinlei Lee , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20220804194325.1596554-1-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220919_063257_976364_E3932334 X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMTkvMDkvMjIgMTA6NDAsIEhzaW4tWWkgV2FuZyBoYSBzY3JpdHRvOgo+IE9uIE1vbiwgU2Vw IDE5LCAyMDIyIGF0IDQ6MzkgUE0gTsOtY29sYXMgRi4gUi4gQS4gUHJhZG8KPiA8bmZyYXByYWRv QGNvbGxhYm9yYS5jb20+IHdyb3RlOgo+Pgo+PiBBcyB0aGUgY29tbWVudCByaWdodCBiZWZvcmUg dGhlIG10a19kc2lfc3RvcCgpIGNhbGwgYWR2aXNlcywKPj4gbXRrX2RzaV9zdG9wKCkgc2hvdWxk IG9ubHkgYmUgY2FsbGVkIGFmdGVyCj4+IG10a19kcm1fY3J0Y19hdG9taWNfZGlzYWJsZSgpLiBU aGF0J3MgYmVjYXVzZSB0aGF0IGZ1bmN0aW9uIGNhbGxzCj4+IGRybV9jcnRjX3dhaXRfb25lX3Zi bGFuaygpLCB3aGljaCByZXF1aXJlcyB0aGUgdmJsYW5rIGlycSB0byBiZSBlbmFibGVkLgo+Pgo+ PiBQcmV2aW91c2x5IG10a19kc2lfc3RvcCgpLCBiZWluZyBpbiBtdGtfZHNpX3Bvd2Vyb2ZmKCkg YW5kIGd1YXJkZWQgYnkgYQo+PiByZWZjb3VudCwgd291bGQgb25seSBiZSBjYWxsZWQgYXQgdGhl IGVuZCBvZgo+PiBtdGtfZHJtX2NydGNfYXRvbWljX2Rpc2FibGUoKSwgdGhyb3VnaCB0aGUgY2Fs bCB0byBtdGtfY3J0Y19kZHBfaHdfZmluaSgpLgo+PiBDb21taXQgY2RlN2UyZTM1YzI4ICgiZHJt L21lZGlhdGVrOiBTZXBhcmF0ZSBwb3dlcm9uL3Bvd2Vyb2ZmIGZyb20KPj4gZW5hYmxlL2Rpc2Fi bGUgYW5kIGRlZmluZSBuZXcgZnVuY3MiKSBtb3ZlZCB0aGUgbXRrX2RzaV9zdG9wKCkgY2FsbCB0 bwo+PiBtdGtfb3V0cHV0X2RzaV9kaXNhYmxlKCksIGNhdXNpbmcgaXQgdG8gYmUgY2FsbGVkIGJl Zm9yZQo+PiBtdGtfZHJtX2NydGNfYXRvbWljX2Rpc2FibGUoKSwgYW5kIGNvbnNlcXVlbnRseSBn ZW5lcmF0aW5nIHZibGFuawo+PiB0aW1lb3V0IHdhcm5pbmdzIGR1cmluZyBzdXNwZW5kLgo+Pgo+ PiBNb3ZlIHRoZSBtdGtfZHNpX3N0b3AoKSBjYWxsIGJhY2sgdG8gbXRrX2RzaV9wb3dlcm9mZigp IHNvIHRoYXQgd2UgaGF2ZQo+PiBhIHdvcmtpbmcgdmJsYW5rIGlycSBkdXJpbmcgbXRrX2RybV9j cnRjX2F0b21pY19kaXNhYmxlKCkgYW5kIHN0b3AKPj4gZ2V0dGluZyB2YmxhbmsgdGltZW91dCB3 YXJuaW5ncy4KPj4KPj4gRml4ZXM6IGNkZTdlMmUzNWMyOCAoImRybS9tZWRpYXRlazogU2VwYXJh dGUgcG93ZXJvbi9wb3dlcm9mZiBmcm9tIGVuYWJsZS9kaXNhYmxlIGFuZCBkZWZpbmUgbmV3IGZ1 bmNzIikKPj4gU2lnbmVkLW9mZi1ieTogTsOtY29sYXMgRi4gUi4gQS4gUHJhZG8gPG5mcmFwcmFk b0Bjb2xsYWJvcmEuY29tPgo+Pgo+IFRlc3RlZC1ieTogSHNpbi1ZaSBXYW5nIDxoc2lueWlAY2hy b21pdW0ub3JnPgo+IAoKUmV2aWV3ZWQtYnk6IEFuZ2Vsb0dpb2FjY2hpbm8gRGVsIFJlZ25vIDxh bmdlbG9naW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxhYm9yYS5jb20+CgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=