On 05/31/2017 02:12 AM, Denis Kenzior wrote: > It is quite obvious the driver implementation is wrong. Someone was a > bit too copy-paste happy. When this driver was submitted, the query API > was not being exercised, hence this path was never tested. > > I do not know/have the ISI specs, nor do I have any functional ISI > hardware. In effect, the ISI driver code is not maintained. If you > want to fix this, then you will need to figure out what the callback > implementation should look like. Perhaps this RFC version of the > current driver code might be of use, see sec_code_state_resp_cb() in > particular: > https://lists.ofono.org/pipermail/ofono/2010-October/005154.html > > Regards, > -Denis I'm not inclined to find out what any of this is, so it'll just stay broken.