From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/i40e: disable init and driver logs by default Date: Thu, 06 Apr 2017 16:39:28 +0200 Message-ID: <2288626.lNqLql9yzM@xps13> References: <20170406141655.15097-1-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Olivier Matz , "Wu, Jingjing" , "Richardson, Bruce" , "Yigit, Ferruh" To: "Zhang, Helin" Return-path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 3187E1E20 for ; Thu, 6 Apr 2017 16:39:31 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id t20so65581246wra.1 for ; Thu, 06 Apr 2017 07:39:31 -0700 (PDT) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Helin, Thanks for acknowledging. This mail to explain how important it is to configure his mailer. You need to quote the original mail so we can quickly find what you have replied. It is also a problem for patchwork as it creates a new entry: http://dpdk.org/dev/patchwork/patch/23300/ because it thinks it is a new patch. So your ack is not registered in the original patch entry: http://dpdk.org/dev/patchwork/patch/23298/ Please share this explanation, thanks 2017-04-06 14:31, Zhang, Helin: > > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Thursday, April 6, 2017 10:17 PM > To: dev@dpdk.org > Cc: Zhang, Helin ; Wu, Jingjing ; Richardson, Bruce ; Yigit, Ferruh > Subject: [PATCH] net/i40e: disable init and driver logs by default > > Since "net/i40e: use dynamic log type for control logs", the i40e driver is more verbose by default, which could result in testpmd being flooded by log messages in some conditions: > > Checking link statuses... > i40e_dev_handle_aq_msg(): Request 2561 is not supported yet > i40e_dev_handle_aq_msg(): Request 2561 is not supported yet > i40e_dev_handle_aq_msg(): Request 2561 is not supported yet > i40e_dev_handle_aq_msg(): Request 2561 is not supported yet > Port 0 Link Up - speed 40000 Mbps - full-duplex > Port 1 Link Up - speed 40000 Mbps - full-duplex > Done > testpmd> i40e_dev_handle_aq_msg(): Request 4097 is not supported yet > i40e_dev_handle_aq_msg(): Request 4097 is not supported yet > i40e_dev_handle_aq_msg(): Request 4097 is not supported yet > > Fix this by disabling the dynamic logs by default. It is still possible to enable them at runtime. > > Fixes: c143e5a3d9e1 ("net/i40e: use dynamic log type for control logs") > > Signed-off-by: Olivier Matz > Acked-by: Helin Zhang > --- > drivers/net/i40e/i40e_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index cb8bf2b49..86f5669f0 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -12456,8 +12456,8 @@ i40e_init_log(void) { > i40e_logtype_init = rte_log_register("pmd.i40e.init"); > if (i40e_logtype_init >= 0) > - rte_log_set_level(i40e_logtype_init, RTE_LOG_NOTICE); > + rte_log_set_level(i40e_logtype_init, RTE_LOG_EMERG); > i40e_logtype_driver = rte_log_register("pmd.i40e.driver"); > if (i40e_logtype_driver >= 0) > - rte_log_set_level(i40e_logtype_driver, RTE_LOG_NOTICE); > + rte_log_set_level(i40e_logtype_driver, RTE_LOG_EMERG); > } > -- > 2.11.0 >