From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC75FC433B4 for ; Mon, 12 Apr 2021 14:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F1986121F for ; Mon, 12 Apr 2021 14:53:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241953AbhDLOxc (ORCPT ); Mon, 12 Apr 2021 10:53:32 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.54]:30189 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237526AbhDLOx2 (ORCPT ); Mon, 12 Apr 2021 10:53:28 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1618239184; cv=none; d=strato.com; s=strato-dkim-0002; b=cNaINwXxnVghLsF8j67RQfipyarpRrXdjRLv08quawZ1JnEvpU3FVbB/Pj21Wtwwvx JoYkADHZNz21L5PrkjmMvyS5ukFhnB8AFk7RaNraR+/IIfs31Pwc4GMALi5bq9eeABAp SlLKvYtu/X+wCjX0nbqp+aODDll5cIlQmszQbp1YeE8XydI8DqugElJYgb46rr55zLzb 8YX+/f3uG7khdihEBgaTSevSzJUd4WR9ue54KOgNAWNcDzs28vIucZHkXY4bx2yQ0tJi kuD7+ydRmgUmY+D4akNsA2xPuBguQBuThTIxgEwR0ETohCLj3pXAzTKTnWQKxRTxKffc fcGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1618239184; s=strato-dkim-0002; d=strato.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=kBXF27gQ5ambp/CjjnXkp3yDX1JfgJeEl20/GXxeygk=; b=X+qBlBZuU75ynEa3CLTA8pcB8WnxTKHbQOkxS5dCwiEkiPj2+TPUv2aqEfOnkGAvlW JmE4z4cPf75iyXPfX+qPO+0JoBPzd6D2IaOW/OXnK7uB1c2ALx8HMUtbhXyNW884GGCS JVoDyLAotA621XesGluRPGXFc9blhckjWx64QvbTcT0ZtdmIoPLAfQs3KTL5s/XfgyOb Bpc15KV3fviXgV+TGx1YELessi+GQbzLBGbh1nh6IMQqVZU42tyoo6RE0VVFGsq+BODh 9emgcjvz0ytJiwy6j4Y++Bzk+xYdBpuKmb6VAIeDZLCgvyTNExLL0RK+DSjcKfZigB8/ N5AA== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1618239184; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=kBXF27gQ5ambp/CjjnXkp3yDX1JfgJeEl20/GXxeygk=; b=Vlndu1i331aQIWrdU8T6zP7TdERoD9P7I5/w/r3k9BaAuQAj9DuBq9DUf+Nd9D11k+ jYBOW6YpIy+zQt7kwklGf73hsMccpNx8bSZS3uHzWF6wBpR+eD44h+y3xV/WzDxHGWg0 RSZ7/1ls5QBHTuhVRLkzFrcwBN2np1An3zjHsMXwAH0Wc2VQIqAzYeUTQw5N3Dfq60J+ bNlDp1FcRLK8It2k8C8TXK1Jenzp8m+D6y7LB8KR/tC87TVi1dqyQzLDSd7Fg7bnu2A9 jTQm9vAdWdSEJldzz/cH4qLUUxcNPc6kRTvJCW/GzkX5KBLOg3jDH29YoKc66QUhhp+L Yp3Q== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHmMlw47o5n4=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.24.0 DYNA|AUTH) with ESMTPSA id Z028d1x3CEr3K3E (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Mon, 12 Apr 2021 16:53:03 +0200 (CEST) Subject: Re: [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=iso-8859-1 From: "H. Nikolaus Schaller" In-Reply-To: Date: Mon, 12 Apr 2021 16:53:03 +0200 Cc: David Airlie , Daniel Vetter , Sam Ravnborg , od@zcrc.me, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <228D0565-DCFF-4314-A4AA-C58EBAD77D22@goldelico.com> References: <20210323144008.166248-1-paul@crapouillou.net> To: Paul Cercueil X-Mailer: Apple Mail (2.3124) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 12.04.2021 um 16:34 schrieb Paul Cercueil : >=20 > Hi, >=20 > Can I have an ACK for this patch? >=20 > Then I can apply it to drm-misc-next-fixes. >=20 > Cheers, > -Paul >=20 >=20 > Le mar. 23 mars 2021 =E0 14:40, Paul Cercueil a = =E9crit : >> When using a 24-bit panel on a 8-bit serial bus, the pixel clock >> requested by the panel has to be multiplied by 3, since the subpixels >> are shifted sequentially. >> The code (in ingenic_drm_encoder_atomic_check) already computed >> crtc_state->adjusted_mode->crtc_clock accordingly, but clk_set_rate() >> used crtc_state->adjusted_mode->clock instead. >> Fixes: 28ab7d35b6e0 ("drm/ingenic: Properly compute timings when = using a 3x8-bit panel") >> Cc: stable@vger.kernel.org # v5.10 Tested-by: H. Nikolaus Schaller # CI20/jz4780 = (HDMI) and Alpha400/jz4730 (LCD) >> Signed-off-by: Paul Cercueil >> --- >> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c = b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c >> index d60e1eefc9d1..cba68bf52ec5 100644 >> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c >> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c >> @@ -342,7 +342,7 @@ static void ingenic_drm_crtc_atomic_flush(struct = drm_crtc *crtc, >> if (priv->update_clk_rate) { >> mutex_lock(&priv->clk_mutex); >> clk_set_rate(priv->pix_clk, >> - crtc_state->adjusted_mode.clock * 1000); >> + crtc_state->adjusted_mode.crtc_clock * = 1000); >> priv->update_clk_rate =3D false; >> mutex_unlock(&priv->clk_mutex); >> } >> -- >> 2.30.2 >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F501C433B4 for ; Mon, 12 Apr 2021 15:05:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 255F66054E for ; Mon, 12 Apr 2021 15:05:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 255F66054E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goldelico.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 827D06E5D2; Mon, 12 Apr 2021 15:05:08 +0000 (UTC) X-Greylist: delayed 719 seconds by postgrey-1.36 at gabe; Mon, 12 Apr 2021 15:05:06 UTC Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8077D6E5D2 for ; Mon, 12 Apr 2021 15:05:06 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1618239184; cv=none; d=strato.com; s=strato-dkim-0002; b=cNaINwXxnVghLsF8j67RQfipyarpRrXdjRLv08quawZ1JnEvpU3FVbB/Pj21Wtwwvx JoYkADHZNz21L5PrkjmMvyS5ukFhnB8AFk7RaNraR+/IIfs31Pwc4GMALi5bq9eeABAp SlLKvYtu/X+wCjX0nbqp+aODDll5cIlQmszQbp1YeE8XydI8DqugElJYgb46rr55zLzb 8YX+/f3uG7khdihEBgaTSevSzJUd4WR9ue54KOgNAWNcDzs28vIucZHkXY4bx2yQ0tJi kuD7+ydRmgUmY+D4akNsA2xPuBguQBuThTIxgEwR0ETohCLj3pXAzTKTnWQKxRTxKffc fcGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1618239184; s=strato-dkim-0002; d=strato.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=kBXF27gQ5ambp/CjjnXkp3yDX1JfgJeEl20/GXxeygk=; b=X+qBlBZuU75ynEa3CLTA8pcB8WnxTKHbQOkxS5dCwiEkiPj2+TPUv2aqEfOnkGAvlW JmE4z4cPf75iyXPfX+qPO+0JoBPzd6D2IaOW/OXnK7uB1c2ALx8HMUtbhXyNW884GGCS JVoDyLAotA621XesGluRPGXFc9blhckjWx64QvbTcT0ZtdmIoPLAfQs3KTL5s/XfgyOb Bpc15KV3fviXgV+TGx1YELessi+GQbzLBGbh1nh6IMQqVZU42tyoo6RE0VVFGsq+BODh 9emgcjvz0ytJiwy6j4Y++Bzk+xYdBpuKmb6VAIeDZLCgvyTNExLL0RK+DSjcKfZigB8/ N5AA== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1618239184; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=kBXF27gQ5ambp/CjjnXkp3yDX1JfgJeEl20/GXxeygk=; b=Vlndu1i331aQIWrdU8T6zP7TdERoD9P7I5/w/r3k9BaAuQAj9DuBq9DUf+Nd9D11k+ jYBOW6YpIy+zQt7kwklGf73hsMccpNx8bSZS3uHzWF6wBpR+eD44h+y3xV/WzDxHGWg0 RSZ7/1ls5QBHTuhVRLkzFrcwBN2np1An3zjHsMXwAH0Wc2VQIqAzYeUTQw5N3Dfq60J+ bNlDp1FcRLK8It2k8C8TXK1Jenzp8m+D6y7LB8KR/tC87TVi1dqyQzLDSd7Fg7bnu2A9 jTQm9vAdWdSEJldzz/cH4qLUUxcNPc6kRTvJCW/GzkX5KBLOg3jDH29YoKc66QUhhp+L Yp3Q== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHmMlw47o5n4=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.24.0 DYNA|AUTH) with ESMTPSA id Z028d1x3CEr3K3E (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Mon, 12 Apr 2021 16:53:03 +0200 (CEST) Subject: Re: [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: "H. Nikolaus Schaller" In-Reply-To: Date: Mon, 12 Apr 2021 16:53:03 +0200 Message-Id: <228D0565-DCFF-4314-A4AA-C58EBAD77D22@goldelico.com> References: <20210323144008.166248-1-paul@crapouillou.net> To: Paul Cercueil X-Mailer: Apple Mail (2.3124) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, od@zcrc.me, stable@vger.kernel.org, Sam Ravnborg Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Am 12.04.2021 um 16:34 schrieb Paul Cercueil : > = > Hi, > = > Can I have an ACK for this patch? > = > Then I can apply it to drm-misc-next-fixes. > = > Cheers, > -Paul > = > = > Le mar. 23 mars 2021 =E0 14:40, Paul Cercueil a = =E9crit : >> When using a 24-bit panel on a 8-bit serial bus, the pixel clock >> requested by the panel has to be multiplied by 3, since the subpixels >> are shifted sequentially. >> The code (in ingenic_drm_encoder_atomic_check) already computed >> crtc_state->adjusted_mode->crtc_clock accordingly, but clk_set_rate() >> used crtc_state->adjusted_mode->clock instead. >> Fixes: 28ab7d35b6e0 ("drm/ingenic: Properly compute timings when using a= 3x8-bit panel") >> Cc: stable@vger.kernel.org # v5.10 Tested-by: H. Nikolaus Schaller # CI20/jz4780 (HDMI) an= d Alpha400/jz4730 (LCD) >> Signed-off-by: Paul Cercueil >> --- >> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm= /ingenic/ingenic-drm-drv.c >> index d60e1eefc9d1..cba68bf52ec5 100644 >> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c >> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c >> @@ -342,7 +342,7 @@ static void ingenic_drm_crtc_atomic_flush(struct drm= _crtc *crtc, >> if (priv->update_clk_rate) { >> mutex_lock(&priv->clk_mutex); >> clk_set_rate(priv->pix_clk, >> - crtc_state->adjusted_mode.clock * 1000); >> + crtc_state->adjusted_mode.crtc_clock * 1000); >> priv->update_clk_rate =3D false; >> mutex_unlock(&priv->clk_mutex); >> } >> -- >> 2.30.2 > = > = _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel