From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97BD9C433FE for ; Mon, 7 Nov 2022 12:13:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232060AbiKGMNO (ORCPT ); Mon, 7 Nov 2022 07:13:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232021AbiKGMNJ (ORCPT ); Mon, 7 Nov 2022 07:13:09 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D3132BE9; Mon, 7 Nov 2022 04:13:03 -0800 (PST) Received: from [192.168.1.15] (91-154-32-225.elisa-laajakaista.fi [91.154.32.225]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 352D1E7B; Mon, 7 Nov 2022 13:13:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1667823181; bh=RK4hAicLNHkx5IRKVwokvjvKjeVGgLibPk6NdO5V030=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SbSMWifdKrmJfhUvnzIGXFDIT3dnQdshiZ84nmQh0Q7F2LRaWRx0sWMUq8ldPT8Tu Heo2CLiu9ESPuSmvJHvATQsvDSHuKOyTZalpz9EJhQ4QPQXP8O/oaW9ip6UnChbBUA MiWNPwT4FFHHXUaoR7FlB4F18h9jSxBTCykdTL+U= Message-ID: <228da3c5-44b1-153c-c6e6-3bc221209bec@ideasonboard.com> Date: Mon, 7 Nov 2022 14:12:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v4 0/8] i2c-atr and FPDLink Content-Language: en-US To: Luca Ceresoli Cc: devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Hans Verkuil , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Luca Ceresoli , Mark Rutland , Matti Vaittinen , Mauro Carvalho Chehab , Peter Rosin , Rob Herring , Sakari Ailus , Vladimir Zapolskiy , Wolfram Sang , satish.nagireddy@getcruise.com References: <20221101132032.1542416-1-tomi.valkeinen@ideasonboard.com> <20221107124814.19b12473@booty> From: Tomi Valkeinen In-Reply-To: <20221107124814.19b12473@booty> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2022 13:48, Luca Ceresoli wrote: >> In fact, I'm thinking that it might be better to just drop the i2c-atr >> driver, and add the support directly to the FPDlink drivers. But that >> could mean possibly duplicating the same code for other deser/ser >> architectures, so I have kept the i2c-atr driver for now. > > Indeed I think the ROHM serdes chips do have an address translation > feature that works pretty much like the TI ones, and the ATR should be > cleanly reusable across the two brands. The ATR code might be > simplified to just provide helpers for common code maybe, but I'd > rather avoid code duplication. I agree. The reason I'm wondering about this is the fact that the i2c slave side (deser) is in a different IC and driver than the i2c master side and driver (ser). That makes it quite different from the i2c-mux (at least how the i2c-mux exists now). Tomi