All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Ciara Loftus <ciara.loftus@intel.com>, <bpf@vger.kernel.org>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH bpf-next 2/3] samples: bpf: count syscalls in xdpsock
Date: Fri, 2 Oct 2020 22:20:15 -0700	[thread overview]
Message-ID: <2291a6f7-a39f-cc97-5548-9a8029a1f36a@fb.com> (raw)
In-Reply-To: <20201002133612.31536-2-ciara.loftus@intel.com>



On 10/2/20 6:36 AM, Ciara Loftus wrote:
> Categorise and record syscalls issued in the xdpsock sample app. The
> categories recorded are:
> 
>    rx_empty_polls:    polls when the rx ring is empty
>    fill_fail_polls:   polls when failed to get addr from fill ring
>    copy_tx_sendtos:   sendtos issued for tx when copy mode enabled
>    tx_wakeup_sendtos: sendtos issued when tx ring needs waking up
>    opt_polls:         polls issued since the '-p' flag is set
> 
> Print the stats using '-a' on the xdpsock command line.
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>

I am not a xdp expert and cannot really judge whether such additional
stats will be useful or not. Beyond that the patch looks good to me.

Acked-by: Yonghong Song <yhs@fb.com>

  reply	other threads:[~2020-10-03  5:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02 13:36 [PATCH bpf-next 1/3] samples: bpf: split xdpsock stats into new struct Ciara Loftus
2020-10-02 13:36 ` [PATCH bpf-next 2/3] samples: bpf: count syscalls in xdpsock Ciara Loftus
2020-10-03  5:20   ` Yonghong Song [this message]
2020-10-02 13:36 ` [PATCH bpf-next 3/3] samples: bpf: driver interrupt statistics " Ciara Loftus
2020-10-03  5:17 ` [PATCH bpf-next 1/3] samples: bpf: split xdpsock stats into new struct Yonghong Song
2020-10-06 18:50 ` patchwork-bot+bpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2291a6f7-a39f-cc97-5548-9a8029a1f36a@fb.com \
    --to=yhs@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=ciara.loftus@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.