Re: [PATCH BlueZ 4/5] client: Display command even with no description

From: Marcel Holtmann <marcel@holtmann.org>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 4/5] client: Display command even with no description
Date: Wed, 19 Jun 2013 07:08:33 +0200	[thread overview]
Message-ID: <22954997-7A12-45B3-BA58-13F02AFE3184@holtmann.org> (raw)
In-Reply-To: <1371586427-7909-4-git-send-email-lucas.demarchi@profusion.mobi>

Hi Lucas,

> Having no description doesn't mean it's not an available command. So add
> command to the output of "help" command, even if it has no description.
> ---
> client/main.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/client/main.c b/client/main.c
> index b0a66d8..54af807 100644
> --- a/client/main.c
> +++ b/client/main.c
> @@ -1182,10 +1182,9 @@ static void rl_handler(char *input)
> 	printf("Available commands:\n");
> 
> 	for (i = 0; cmd_table[i].cmd; i++) {
> -		if (cmd_table[i].desc)
> -			printf("\t%s %s\t%s\n", cmd_table[i].cmd,
> +		printf("\t%s %s\t%s\n", cmd_table[i].cmd,
> 						cmd_table[i].arg ? : "    ",
> -						cmd_table[i].desc);
> +						cmd_table[i].desc ? : "");

if I remember this correctly, then I was doing it to be able to hide commands from the help output. Mainly commands that are on purpose duplicates.

Regards

Marcel