From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C632C43331 for ; Wed, 23 Dec 2020 21:00:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEFB4224DF for ; Wed, 23 Dec 2020 21:00:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729103AbgLWU7t (ORCPT ); Wed, 23 Dec 2020 15:59:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728898AbgLWU7s (ORCPT ); Wed, 23 Dec 2020 15:59:48 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AE68C061794; Wed, 23 Dec 2020 12:59:08 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id m12so396405lfo.7; Wed, 23 Dec 2020 12:59:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Paa/2Zgj9P95KKc/EM4S7akG+ebzd49b55aHgCq35nI=; b=XibHKH3lzyJ51D/2fdl3IDTxBo+rRPAAso0PTw2bRoWelBOVEL12b7vwet0Ap9n5W/ iHT5gL1JD+4QKml3ZP2aP0n3RBt0RN7ir97YoOWNTIZ2D2FPDYG0Bu1MtIl59JE7bwYj dwB82UnkgMsHeCO1nayJVc0DLP4LtQ0gf4Lomocpe3wkhJRzC22NNd1qM4yBYcMAR9je G94iZSSXqDfiIUFnvAGE74PDAnS0pUxSheRKscYATXlTPxodyK0omHX01vBF9Md28k9L vf+lyl2JX91DHr/gEYGq3R08Fe+EGuPHqDa9SLOJLqi0ncmOusUTwTDaN7y0qYK1D85b A5ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Paa/2Zgj9P95KKc/EM4S7akG+ebzd49b55aHgCq35nI=; b=a8S5FN2lKI2VIxsnfAGL80nvLpi2n78yCpuGBvRWHHTVssJbnT9qAZZIK0kvb7UQZD jUDCqRUDpAIA1FqEyKzV5MHbmSHhklAxkrVkuoOSq6TaOLi2qiMip0DW3nq6Dg6wc4fv 9G9XecSTiTsTnxORuAN+OwUlPcnTqUO33A6DODEk9oMuk1OzlYRAn9xsnhcIs0G1rQMx exLCQzkOtdAOTfTNfZx51O1cz6XaW+Qu6YKdwy7hXPbBgAF0yyjb06aqud7NijGlf8Vl oaSYSpFdsVriJnTXWjCU2eMPup26+NFNIQ//wG8Mim0sKNx5e6YAv5OGLI7FMSL/CGJl ukCQ== X-Gm-Message-State: AOAM531x/+YU3MBLpimsjdn0k+J4l/SBRE9ZKBhX9lYS1vhB84SIrzxZ okezDqr/uADPEBOS1M4YQgdIPS0jrAI= X-Google-Smtp-Source: ABdhPJwgEzvh9ANtO8Hu+EE0UE3MF2J6XaYsYVTo0A5GcIAKl9dNfg1svW44bV8UGc4vRAGfTLm3lQ== X-Received: by 2002:a19:801:: with SMTP id 1mr11053288lfi.113.1608757146318; Wed, 23 Dec 2020 12:59:06 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id p24sm3346902lfo.53.2020.12.23.12.59.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 12:59:05 -0800 (PST) Subject: Re: [PATCH v2 28/48] soc/tegra: Introduce core power domain driver From: Dmitry Osipenko To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood , Ulf Hansson , Mauro Carvalho Chehab , Rob Herring , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Michael Turquette , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-29-digetx@gmail.com> <20201222064029.duuzcsj53rt7xzvt@vireshk-i7> <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> <239642ad-d7e9-364e-80d3-1da67625e247@gmail.com> Message-ID: <2298c089-827c-40a5-3ebe-3a91f3918ad5@gmail.com> Date: Wed, 23 Dec 2020 23:59:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <239642ad-d7e9-364e-80d3-1da67625e247@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 23.12.2020 23:37, Dmitry Osipenko пишет: > 23.12.2020 08:57, Viresh Kumar пишет: >> On 22-12-20, 22:39, Dmitry Osipenko wrote: >>> 22.12.2020 22:21, Dmitry Osipenko пишет: >>>>>> + if (IS_ERR(opp)) { >>>>>> + dev_err(&genpd->dev, "failed to find OPP for level %u: %pe\n", >>>>>> + level, opp); >>>>>> + return PTR_ERR(opp); >>>>>> + } >>>>>> + >>>>>> + err = dev_pm_opp_set_voltage(&genpd->dev, opp); >>>>> IIUC, you implemented this callback because you want to use the voltage triplet >>>>> present in the OPP table ? >>>>> >>>>> And so you are setting the regulator ("power") later in this patch ? >>>> yes >>>> >>>>> I am not in favor of implementing this routine, as it just adds a wrapper above >>>>> the regulator API. What you should be doing rather is get the regulator by >>>>> yourself here (instead of depending on the OPP core). And then you can do >>>>> dev_pm_opp_get_voltage() here and set the voltage yourself. You may want to >>>>> implement a version supporting triplet here though for the same. >>>>> >>>>> And you won't require the sync version of the API as well then. >>>>> >>>> That's what I initially did for this driver. I don't mind to revert back >>>> to the initial variant in v3, it appeared to me that it will be nicer >>>> and cleaner to have OPP API managing everything here. >>> >>> I forgot one important detail (why the initial variant wasn't good).. >>> OPP entries that have unsupportable voltages should be filtered out and >>> OPP core performs the filtering only if regulator is assigned to the OPP >>> table. >>> >>> If regulator is assigned to the OPP table, then we need to use OPP API >>> for driving the regulator, hence that's why I added >>> dev_pm_opp_sync_regulators() and dev_pm_opp_set_voltage(). >>> >>> Perhaps it should be possible to add dev_pm_opp_get_regulator() that >> >> What's wrong with getting the regulator in the driver as well ? Apart from the >> OPP core ? > > The voltage syncing should be done for each consumer regulator > individually [1]. > > Secondly, regulator core doesn't work well today if the same regulator > is requested more than one time for the same device. > >>> will return the OPP table regulator in order to allow driver to use the >>> regulator directly. But I'm not sure whether this is a much better >>> option than the opp_sync_regulators() and opp_set_voltage() APIs. >> >> set_voltage() is still fine as there is some data that the OPP core has, but >> sync_regulator() has nothing to do with OPP core. >> >> And this may lead to more wrapper helpers in the OPP core, which I am afraid of. >> And so even if it is not the best, I would like the OPP core to provide the data >> and not get into this. Ofcourse there is an exception to this, opp_set_rate. >> > > The regulator_sync_voltage() should be invoked only if voltage was > changed previously [1]. > > The OPP core already has the info about whether voltage was changed and > it provides the necessary locking for both set_voltage() and > sync_regulator(). Perhaps I'll need to duplicate that functionality in > the PD driver, instead of making it all generic and re-usable by other > drivers. > > [1] > https://elixir.bootlin.com/linux/v5.10.2/source/drivers/regulator/core.c#L4107 > I just realized that the locking is missing in the v2 patches, something to fix in the next revision :) Still I'm in favor of extending the OPP API with the new common functions. But if you have a strong opinion about that, then I'll try to work around it in the PD driver in v3. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB7CC433E0 for ; Wed, 23 Dec 2020 20:59:14 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D450E2246B for ; Wed, 23 Dec 2020 20:59:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D450E2246B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6B62784F2A; Wed, 23 Dec 2020 20:59:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s91NLdQj6YVZ; Wed, 23 Dec 2020 20:59:12 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2911D85232; Wed, 23 Dec 2020 20:59:12 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 3B4431BF23C for ; Wed, 23 Dec 2020 20:59:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 37ADC85232 for ; Wed, 23 Dec 2020 20:59:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LCga1D_tVxCO for ; Wed, 23 Dec 2020 20:59:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 0F61A84F2A for ; Wed, 23 Dec 2020 20:59:08 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id b26so373902lff.9 for ; Wed, 23 Dec 2020 12:59:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Paa/2Zgj9P95KKc/EM4S7akG+ebzd49b55aHgCq35nI=; b=XibHKH3lzyJ51D/2fdl3IDTxBo+rRPAAso0PTw2bRoWelBOVEL12b7vwet0Ap9n5W/ iHT5gL1JD+4QKml3ZP2aP0n3RBt0RN7ir97YoOWNTIZ2D2FPDYG0Bu1MtIl59JE7bwYj dwB82UnkgMsHeCO1nayJVc0DLP4LtQ0gf4Lomocpe3wkhJRzC22NNd1qM4yBYcMAR9je G94iZSSXqDfiIUFnvAGE74PDAnS0pUxSheRKscYATXlTPxodyK0omHX01vBF9Md28k9L vf+lyl2JX91DHr/gEYGq3R08Fe+EGuPHqDa9SLOJLqi0ncmOusUTwTDaN7y0qYK1D85b A5ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Paa/2Zgj9P95KKc/EM4S7akG+ebzd49b55aHgCq35nI=; b=PhmVda3mOE/9kavJQPU+xn61IAuqoWmD6Ii38JiOQ5xDp+IFs/RpWhb4z+xT0mcCLu 73ep4GzN7J3uLD2FtBhkIXzuweWjC1AzCVmdgiSL7Iimr/37dYsu3+trZR8fgYsXYt8J QipvxmOrk5T4Z6pSpimDM7+LWaPelnTdeO7O2up+zp2179VnmAt4O09iDeKTUpXfWtAo GPbzG6gYUyjDNA75oQapD4uHaxliw0kiYN05+jg/F/DQJPL1yUXeqZjMmJS6S/WXyJOp kZMcDMef16uClt3iZmsJM0/57XJwKrIE+eF+GCGb1IN/W5bSxMgWyLSfg0WxCQDUuPBQ eu4A== X-Gm-Message-State: AOAM530fnyCoYcQEptYanS9eccMdR29CjPvU36hTVwoLxFyL3p0plY4v X0mlpyrrr+xRtzYi+kkdI80= X-Google-Smtp-Source: ABdhPJwgEzvh9ANtO8Hu+EE0UE3MF2J6XaYsYVTo0A5GcIAKl9dNfg1svW44bV8UGc4vRAGfTLm3lQ== X-Received: by 2002:a19:801:: with SMTP id 1mr11053288lfi.113.1608757146318; Wed, 23 Dec 2020 12:59:06 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id p24sm3346902lfo.53.2020.12.23.12.59.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 12:59:05 -0800 (PST) Subject: Re: [PATCH v2 28/48] soc/tegra: Introduce core power domain driver From: Dmitry Osipenko To: Viresh Kumar References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-29-digetx@gmail.com> <20201222064029.duuzcsj53rt7xzvt@vireshk-i7> <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> <239642ad-d7e9-364e-80d3-1da67625e247@gmail.com> Message-ID: <2298c089-827c-40a5-3ebe-3a91f3918ad5@gmail.com> Date: Wed, 23 Dec 2020 23:59:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <239642ad-d7e9-364e-80d3-1da67625e247@gmail.com> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" MjMuMTIuMjAyMCAyMzozNywgRG1pdHJ5IE9zaXBlbmtvINC/0LjRiNC10YI6Cj4gMjMuMTIuMjAy MCAwODo1NywgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4+IE9uIDIyLTEyLTIwLCAyMjozOSwg RG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+Pj4gMjIuMTIuMjAyMCAyMjoyMSwgRG1pdHJ5IE9zaXBl bmtvINC/0LjRiNC10YI6Cj4+Pj4+PiArCWlmIChJU19FUlIob3BwKSkgewo+Pj4+Pj4gKwkJZGV2 X2VycigmZ2VucGQtPmRldiwgImZhaWxlZCB0byBmaW5kIE9QUCBmb3IgbGV2ZWwgJXU6ICVwZVxu IiwKPj4+Pj4+ICsJCQlsZXZlbCwgb3BwKTsKPj4+Pj4+ICsJCXJldHVybiBQVFJfRVJSKG9wcCk7 Cj4+Pj4+PiArCX0KPj4+Pj4+ICsKPj4+Pj4+ICsJZXJyID0gZGV2X3BtX29wcF9zZXRfdm9sdGFn ZSgmZ2VucGQtPmRldiwgb3BwKTsKPj4+Pj4gSUlVQywgeW91IGltcGxlbWVudGVkIHRoaXMgY2Fs bGJhY2sgYmVjYXVzZSB5b3Ugd2FudCB0byB1c2UgdGhlIHZvbHRhZ2UgdHJpcGxldAo+Pj4+PiBw cmVzZW50IGluIHRoZSBPUFAgdGFibGUgPwo+Pj4+Pgo+Pj4+PiBBbmQgc28geW91IGFyZSBzZXR0 aW5nIHRoZSByZWd1bGF0b3IgKCJwb3dlciIpIGxhdGVyIGluIHRoaXMgcGF0Y2ggPwo+Pj4+IHll cwo+Pj4+Cj4+Pj4+IEkgYW0gbm90IGluIGZhdm9yIG9mIGltcGxlbWVudGluZyB0aGlzIHJvdXRp bmUsIGFzIGl0IGp1c3QgYWRkcyBhIHdyYXBwZXIgYWJvdmUKPj4+Pj4gdGhlIHJlZ3VsYXRvciBB UEkuIFdoYXQgeW91IHNob3VsZCBiZSBkb2luZyByYXRoZXIgaXMgZ2V0IHRoZSByZWd1bGF0b3Ig YnkKPj4+Pj4geW91cnNlbGYgaGVyZSAoaW5zdGVhZCBvZiBkZXBlbmRpbmcgb24gdGhlIE9QUCBj b3JlKS4gQW5kIHRoZW4geW91IGNhbiBkbwo+Pj4+PiBkZXZfcG1fb3BwX2dldF92b2x0YWdlKCkg aGVyZSBhbmQgc2V0IHRoZSB2b2x0YWdlIHlvdXJzZWxmLiBZb3UgbWF5IHdhbnQgdG8KPj4+Pj4g aW1wbGVtZW50IGEgdmVyc2lvbiBzdXBwb3J0aW5nIHRyaXBsZXQgaGVyZSB0aG91Z2ggZm9yIHRo ZSBzYW1lLgo+Pj4+Pgo+Pj4+PiBBbmQgeW91IHdvbid0IHJlcXVpcmUgdGhlIHN5bmMgdmVyc2lv biBvZiB0aGUgQVBJIGFzIHdlbGwgdGhlbi4KPj4+Pj4KPj4+PiBUaGF0J3Mgd2hhdCBJIGluaXRp YWxseSBkaWQgZm9yIHRoaXMgZHJpdmVyLiBJIGRvbid0IG1pbmQgdG8gcmV2ZXJ0IGJhY2sKPj4+ PiB0byB0aGUgaW5pdGlhbCB2YXJpYW50IGluIHYzLCBpdCBhcHBlYXJlZCB0byBtZSB0aGF0IGl0 IHdpbGwgYmUgbmljZXIKPj4+PiBhbmQgY2xlYW5lciB0byBoYXZlIE9QUCBBUEkgbWFuYWdpbmcg ZXZlcnl0aGluZyBoZXJlLgo+Pj4KPj4+IEkgZm9yZ290IG9uZSBpbXBvcnRhbnQgZGV0YWlsICh3 aHkgdGhlIGluaXRpYWwgdmFyaWFudCB3YXNuJ3QgZ29vZCkuLgo+Pj4gT1BQIGVudHJpZXMgdGhh dCBoYXZlIHVuc3VwcG9ydGFibGUgdm9sdGFnZXMgc2hvdWxkIGJlIGZpbHRlcmVkIG91dCBhbmQK Pj4+IE9QUCBjb3JlIHBlcmZvcm1zIHRoZSBmaWx0ZXJpbmcgb25seSBpZiByZWd1bGF0b3IgaXMg YXNzaWduZWQgdG8gdGhlIE9QUAo+Pj4gdGFibGUuCj4+Pgo+Pj4gSWYgcmVndWxhdG9yIGlzIGFz c2lnbmVkIHRvIHRoZSBPUFAgdGFibGUsIHRoZW4gd2UgbmVlZCB0byB1c2UgT1BQIEFQSQo+Pj4g Zm9yIGRyaXZpbmcgdGhlIHJlZ3VsYXRvciwgaGVuY2UgdGhhdCdzIHdoeSBJIGFkZGVkCj4+PiBk ZXZfcG1fb3BwX3N5bmNfcmVndWxhdG9ycygpIGFuZCBkZXZfcG1fb3BwX3NldF92b2x0YWdlKCku Cj4+Pgo+Pj4gUGVyaGFwcyBpdCBzaG91bGQgYmUgcG9zc2libGUgdG8gYWRkIGRldl9wbV9vcHBf Z2V0X3JlZ3VsYXRvcigpIHRoYXQKPj4KPj4gV2hhdCdzIHdyb25nIHdpdGggZ2V0dGluZyB0aGUg cmVndWxhdG9yIGluIHRoZSBkcml2ZXIgYXMgd2VsbCA/IEFwYXJ0IGZyb20gdGhlCj4+IE9QUCBj b3JlID8KPiAKPiBUaGUgdm9sdGFnZSBzeW5jaW5nIHNob3VsZCBiZSBkb25lIGZvciBlYWNoIGNv bnN1bWVyIHJlZ3VsYXRvcgo+IGluZGl2aWR1YWxseSBbMV0uCj4gCj4gU2Vjb25kbHksIHJlZ3Vs YXRvciBjb3JlIGRvZXNuJ3Qgd29yayB3ZWxsIHRvZGF5IGlmIHRoZSBzYW1lIHJlZ3VsYXRvcgo+ IGlzIHJlcXVlc3RlZCBtb3JlIHRoYW4gb25lIHRpbWUgZm9yIHRoZSBzYW1lIGRldmljZS4KPiAK Pj4+IHdpbGwgcmV0dXJuIHRoZSBPUFAgdGFibGUgcmVndWxhdG9yIGluIG9yZGVyIHRvIGFsbG93 IGRyaXZlciB0byB1c2UgdGhlCj4+PiByZWd1bGF0b3IgZGlyZWN0bHkuIEJ1dCBJJ20gbm90IHN1 cmUgd2hldGhlciB0aGlzIGlzIGEgbXVjaCBiZXR0ZXIKPj4+IG9wdGlvbiB0aGFuIHRoZSBvcHBf c3luY19yZWd1bGF0b3JzKCkgYW5kIG9wcF9zZXRfdm9sdGFnZSgpIEFQSXMuCj4+Cj4+IHNldF92 b2x0YWdlKCkgaXMgc3RpbGwgZmluZSBhcyB0aGVyZSBpcyBzb21lIGRhdGEgdGhhdCB0aGUgT1BQ IGNvcmUgaGFzLCBidXQKPj4gc3luY19yZWd1bGF0b3IoKSBoYXMgbm90aGluZyB0byBkbyB3aXRo IE9QUCBjb3JlLgo+Pgo+PiBBbmQgdGhpcyBtYXkgbGVhZCB0byBtb3JlIHdyYXBwZXIgaGVscGVy cyBpbiB0aGUgT1BQIGNvcmUsIHdoaWNoIEkgYW0gYWZyYWlkIG9mLgo+PiBBbmQgc28gZXZlbiBp ZiBpdCBpcyBub3QgdGhlIGJlc3QsIEkgd291bGQgbGlrZSB0aGUgT1BQIGNvcmUgdG8gcHJvdmlk ZSB0aGUgZGF0YQo+PiBhbmQgbm90IGdldCBpbnRvIHRoaXMuIE9mY291cnNlIHRoZXJlIGlzIGFu IGV4Y2VwdGlvbiB0byB0aGlzLCBvcHBfc2V0X3JhdGUuCj4+Cj4gCj4gVGhlIHJlZ3VsYXRvcl9z eW5jX3ZvbHRhZ2UoKSBzaG91bGQgYmUgaW52b2tlZCBvbmx5IGlmIHZvbHRhZ2Ugd2FzCj4gY2hh bmdlZCBwcmV2aW91c2x5IFsxXS4KPiAKPiBUaGUgT1BQIGNvcmUgYWxyZWFkeSBoYXMgdGhlIGlu Zm8gYWJvdXQgd2hldGhlciB2b2x0YWdlIHdhcyBjaGFuZ2VkIGFuZAo+IGl0IHByb3ZpZGVzIHRo ZSBuZWNlc3NhcnkgbG9ja2luZyBmb3IgYm90aCBzZXRfdm9sdGFnZSgpIGFuZAo+IHN5bmNfcmVn dWxhdG9yKCkuIFBlcmhhcHMgSSdsbCBuZWVkIHRvIGR1cGxpY2F0ZSB0aGF0IGZ1bmN0aW9uYWxp dHkgaW4KPiB0aGUgUEQgZHJpdmVyLCBpbnN0ZWFkIG9mIG1ha2luZyBpdCBhbGwgZ2VuZXJpYyBh bmQgcmUtdXNhYmxlIGJ5IG90aGVyCj4gZHJpdmVycy4KPiAKPiBbMV0KPiBodHRwczovL2VsaXhp ci5ib290bGluLmNvbS9saW51eC92NS4xMC4yL3NvdXJjZS9kcml2ZXJzL3JlZ3VsYXRvci9jb3Jl LmMjTDQxMDcKPiAKCkkganVzdCByZWFsaXplZCB0aGF0IHRoZSBsb2NraW5nIGlzIG1pc3Npbmcg aW4gdGhlIHYyIHBhdGNoZXMsIHNvbWV0aGluZwp0byBmaXggaW4gdGhlIG5leHQgcmV2aXNpb24g OikKClN0aWxsIEknbSBpbiBmYXZvciBvZiBleHRlbmRpbmcgdGhlIE9QUCBBUEkgd2l0aCB0aGUg bmV3IGNvbW1vbgpmdW5jdGlvbnMuIEJ1dCBpZiB5b3UgaGF2ZSBhIHN0cm9uZyBvcGluaW9uIGFi b3V0IHRoYXQsIHRoZW4gSSdsbCB0cnkgdG8Kd29yayBhcm91bmQgaXQgaW4gdGhlIFBEIGRyaXZl ciBpbiB2My4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZGV2ZWwgbWFpbGluZyBsaXN0CmRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2Ry aXZlcmRldi5saW51eGRyaXZlcnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2 LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45E48C433DB for ; Fri, 25 Dec 2020 09:43:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14BCC230FF for ; Fri, 25 Dec 2020 09:43:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14BCC230FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DE6989C17; Fri, 25 Dec 2020 09:42:14 +0000 (UTC) Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by gabe.freedesktop.org (Postfix) with ESMTPS id DFD6F89F0A for ; Wed, 23 Dec 2020 20:59:07 +0000 (UTC) Received: by mail-lf1-x12b.google.com with SMTP id b26so373903lff.9 for ; Wed, 23 Dec 2020 12:59:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Paa/2Zgj9P95KKc/EM4S7akG+ebzd49b55aHgCq35nI=; b=XibHKH3lzyJ51D/2fdl3IDTxBo+rRPAAso0PTw2bRoWelBOVEL12b7vwet0Ap9n5W/ iHT5gL1JD+4QKml3ZP2aP0n3RBt0RN7ir97YoOWNTIZ2D2FPDYG0Bu1MtIl59JE7bwYj dwB82UnkgMsHeCO1nayJVc0DLP4LtQ0gf4Lomocpe3wkhJRzC22NNd1qM4yBYcMAR9je G94iZSSXqDfiIUFnvAGE74PDAnS0pUxSheRKscYATXlTPxodyK0omHX01vBF9Md28k9L vf+lyl2JX91DHr/gEYGq3R08Fe+EGuPHqDa9SLOJLqi0ncmOusUTwTDaN7y0qYK1D85b A5ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Paa/2Zgj9P95KKc/EM4S7akG+ebzd49b55aHgCq35nI=; b=N+kSRUF8C+Cj6zqhOgC/ZTmG1j/NqtRFoYpZRYmuXPDtRAew1c3RZKsOQtV0SQ8i5J r9Zp8j4Op83Fi6QNUrQLYqXcT6Pel6BXmmMDgkXtHFJnwnNBh+MOTPN6MmXG4/jxFg6/ yN5/us99OeZecupKdq8RJgYzi1pzZ++BT8KvhFyek1tKHXv0mujPPkuyfCC557t8REQP RMH2akoEcBN6U6fgfLmn4HndGr8hv6PPExocE9iw6Nveo5KgvWnvv/o9qVTyt027uPqO Ye3ZP5nadrNNDtZwsvi2w2lb4U+V4Mba13rva38/7JorR+jKeSOnOz0eF1CrEnlMGVRZ YPNA== X-Gm-Message-State: AOAM530d1nWWCSLX8SfTfn0IlPIe1KrQGNwCkN9N6bIKujR+H3UFLpCp RKCShIMGiqMCvbPL3aPAN2Q= X-Google-Smtp-Source: ABdhPJwgEzvh9ANtO8Hu+EE0UE3MF2J6XaYsYVTo0A5GcIAKl9dNfg1svW44bV8UGc4vRAGfTLm3lQ== X-Received: by 2002:a19:801:: with SMTP id 1mr11053288lfi.113.1608757146318; Wed, 23 Dec 2020 12:59:06 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id p24sm3346902lfo.53.2020.12.23.12.59.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 12:59:05 -0800 (PST) Subject: Re: [PATCH v2 28/48] soc/tegra: Introduce core power domain driver From: Dmitry Osipenko To: Viresh Kumar References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-29-digetx@gmail.com> <20201222064029.duuzcsj53rt7xzvt@vireshk-i7> <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> <239642ad-d7e9-364e-80d3-1da67625e247@gmail.com> Message-ID: <2298c089-827c-40a5-3ebe-3a91f3918ad5@gmail.com> Date: Wed, 23 Dec 2020 23:59:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <239642ad-d7e9-364e-80d3-1da67625e247@gmail.com> Content-Language: en-US X-Mailman-Approved-At: Fri, 25 Dec 2020 09:42:09 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MjMuMTIuMjAyMCAyMzozNywgRG1pdHJ5IE9zaXBlbmtvINC/0LjRiNC10YI6Cj4gMjMuMTIuMjAy MCAwODo1NywgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4+IE9uIDIyLTEyLTIwLCAyMjozOSwg RG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+Pj4gMjIuMTIuMjAyMCAyMjoyMSwgRG1pdHJ5IE9zaXBl bmtvINC/0LjRiNC10YI6Cj4+Pj4+PiArCWlmIChJU19FUlIob3BwKSkgewo+Pj4+Pj4gKwkJZGV2 X2VycigmZ2VucGQtPmRldiwgImZhaWxlZCB0byBmaW5kIE9QUCBmb3IgbGV2ZWwgJXU6ICVwZVxu IiwKPj4+Pj4+ICsJCQlsZXZlbCwgb3BwKTsKPj4+Pj4+ICsJCXJldHVybiBQVFJfRVJSKG9wcCk7 Cj4+Pj4+PiArCX0KPj4+Pj4+ICsKPj4+Pj4+ICsJZXJyID0gZGV2X3BtX29wcF9zZXRfdm9sdGFn ZSgmZ2VucGQtPmRldiwgb3BwKTsKPj4+Pj4gSUlVQywgeW91IGltcGxlbWVudGVkIHRoaXMgY2Fs bGJhY2sgYmVjYXVzZSB5b3Ugd2FudCB0byB1c2UgdGhlIHZvbHRhZ2UgdHJpcGxldAo+Pj4+PiBw cmVzZW50IGluIHRoZSBPUFAgdGFibGUgPwo+Pj4+Pgo+Pj4+PiBBbmQgc28geW91IGFyZSBzZXR0 aW5nIHRoZSByZWd1bGF0b3IgKCJwb3dlciIpIGxhdGVyIGluIHRoaXMgcGF0Y2ggPwo+Pj4+IHll cwo+Pj4+Cj4+Pj4+IEkgYW0gbm90IGluIGZhdm9yIG9mIGltcGxlbWVudGluZyB0aGlzIHJvdXRp bmUsIGFzIGl0IGp1c3QgYWRkcyBhIHdyYXBwZXIgYWJvdmUKPj4+Pj4gdGhlIHJlZ3VsYXRvciBB UEkuIFdoYXQgeW91IHNob3VsZCBiZSBkb2luZyByYXRoZXIgaXMgZ2V0IHRoZSByZWd1bGF0b3Ig YnkKPj4+Pj4geW91cnNlbGYgaGVyZSAoaW5zdGVhZCBvZiBkZXBlbmRpbmcgb24gdGhlIE9QUCBj b3JlKS4gQW5kIHRoZW4geW91IGNhbiBkbwo+Pj4+PiBkZXZfcG1fb3BwX2dldF92b2x0YWdlKCkg aGVyZSBhbmQgc2V0IHRoZSB2b2x0YWdlIHlvdXJzZWxmLiBZb3UgbWF5IHdhbnQgdG8KPj4+Pj4g aW1wbGVtZW50IGEgdmVyc2lvbiBzdXBwb3J0aW5nIHRyaXBsZXQgaGVyZSB0aG91Z2ggZm9yIHRo ZSBzYW1lLgo+Pj4+Pgo+Pj4+PiBBbmQgeW91IHdvbid0IHJlcXVpcmUgdGhlIHN5bmMgdmVyc2lv biBvZiB0aGUgQVBJIGFzIHdlbGwgdGhlbi4KPj4+Pj4KPj4+PiBUaGF0J3Mgd2hhdCBJIGluaXRp YWxseSBkaWQgZm9yIHRoaXMgZHJpdmVyLiBJIGRvbid0IG1pbmQgdG8gcmV2ZXJ0IGJhY2sKPj4+ PiB0byB0aGUgaW5pdGlhbCB2YXJpYW50IGluIHYzLCBpdCBhcHBlYXJlZCB0byBtZSB0aGF0IGl0 IHdpbGwgYmUgbmljZXIKPj4+PiBhbmQgY2xlYW5lciB0byBoYXZlIE9QUCBBUEkgbWFuYWdpbmcg ZXZlcnl0aGluZyBoZXJlLgo+Pj4KPj4+IEkgZm9yZ290IG9uZSBpbXBvcnRhbnQgZGV0YWlsICh3 aHkgdGhlIGluaXRpYWwgdmFyaWFudCB3YXNuJ3QgZ29vZCkuLgo+Pj4gT1BQIGVudHJpZXMgdGhh dCBoYXZlIHVuc3VwcG9ydGFibGUgdm9sdGFnZXMgc2hvdWxkIGJlIGZpbHRlcmVkIG91dCBhbmQK Pj4+IE9QUCBjb3JlIHBlcmZvcm1zIHRoZSBmaWx0ZXJpbmcgb25seSBpZiByZWd1bGF0b3IgaXMg YXNzaWduZWQgdG8gdGhlIE9QUAo+Pj4gdGFibGUuCj4+Pgo+Pj4gSWYgcmVndWxhdG9yIGlzIGFz c2lnbmVkIHRvIHRoZSBPUFAgdGFibGUsIHRoZW4gd2UgbmVlZCB0byB1c2UgT1BQIEFQSQo+Pj4g Zm9yIGRyaXZpbmcgdGhlIHJlZ3VsYXRvciwgaGVuY2UgdGhhdCdzIHdoeSBJIGFkZGVkCj4+PiBk ZXZfcG1fb3BwX3N5bmNfcmVndWxhdG9ycygpIGFuZCBkZXZfcG1fb3BwX3NldF92b2x0YWdlKCku Cj4+Pgo+Pj4gUGVyaGFwcyBpdCBzaG91bGQgYmUgcG9zc2libGUgdG8gYWRkIGRldl9wbV9vcHBf Z2V0X3JlZ3VsYXRvcigpIHRoYXQKPj4KPj4gV2hhdCdzIHdyb25nIHdpdGggZ2V0dGluZyB0aGUg cmVndWxhdG9yIGluIHRoZSBkcml2ZXIgYXMgd2VsbCA/IEFwYXJ0IGZyb20gdGhlCj4+IE9QUCBj b3JlID8KPiAKPiBUaGUgdm9sdGFnZSBzeW5jaW5nIHNob3VsZCBiZSBkb25lIGZvciBlYWNoIGNv bnN1bWVyIHJlZ3VsYXRvcgo+IGluZGl2aWR1YWxseSBbMV0uCj4gCj4gU2Vjb25kbHksIHJlZ3Vs YXRvciBjb3JlIGRvZXNuJ3Qgd29yayB3ZWxsIHRvZGF5IGlmIHRoZSBzYW1lIHJlZ3VsYXRvcgo+ IGlzIHJlcXVlc3RlZCBtb3JlIHRoYW4gb25lIHRpbWUgZm9yIHRoZSBzYW1lIGRldmljZS4KPiAK Pj4+IHdpbGwgcmV0dXJuIHRoZSBPUFAgdGFibGUgcmVndWxhdG9yIGluIG9yZGVyIHRvIGFsbG93 IGRyaXZlciB0byB1c2UgdGhlCj4+PiByZWd1bGF0b3IgZGlyZWN0bHkuIEJ1dCBJJ20gbm90IHN1 cmUgd2hldGhlciB0aGlzIGlzIGEgbXVjaCBiZXR0ZXIKPj4+IG9wdGlvbiB0aGFuIHRoZSBvcHBf c3luY19yZWd1bGF0b3JzKCkgYW5kIG9wcF9zZXRfdm9sdGFnZSgpIEFQSXMuCj4+Cj4+IHNldF92 b2x0YWdlKCkgaXMgc3RpbGwgZmluZSBhcyB0aGVyZSBpcyBzb21lIGRhdGEgdGhhdCB0aGUgT1BQ IGNvcmUgaGFzLCBidXQKPj4gc3luY19yZWd1bGF0b3IoKSBoYXMgbm90aGluZyB0byBkbyB3aXRo IE9QUCBjb3JlLgo+Pgo+PiBBbmQgdGhpcyBtYXkgbGVhZCB0byBtb3JlIHdyYXBwZXIgaGVscGVy cyBpbiB0aGUgT1BQIGNvcmUsIHdoaWNoIEkgYW0gYWZyYWlkIG9mLgo+PiBBbmQgc28gZXZlbiBp ZiBpdCBpcyBub3QgdGhlIGJlc3QsIEkgd291bGQgbGlrZSB0aGUgT1BQIGNvcmUgdG8gcHJvdmlk ZSB0aGUgZGF0YQo+PiBhbmQgbm90IGdldCBpbnRvIHRoaXMuIE9mY291cnNlIHRoZXJlIGlzIGFu IGV4Y2VwdGlvbiB0byB0aGlzLCBvcHBfc2V0X3JhdGUuCj4+Cj4gCj4gVGhlIHJlZ3VsYXRvcl9z eW5jX3ZvbHRhZ2UoKSBzaG91bGQgYmUgaW52b2tlZCBvbmx5IGlmIHZvbHRhZ2Ugd2FzCj4gY2hh bmdlZCBwcmV2aW91c2x5IFsxXS4KPiAKPiBUaGUgT1BQIGNvcmUgYWxyZWFkeSBoYXMgdGhlIGlu Zm8gYWJvdXQgd2hldGhlciB2b2x0YWdlIHdhcyBjaGFuZ2VkIGFuZAo+IGl0IHByb3ZpZGVzIHRo ZSBuZWNlc3NhcnkgbG9ja2luZyBmb3IgYm90aCBzZXRfdm9sdGFnZSgpIGFuZAo+IHN5bmNfcmVn dWxhdG9yKCkuIFBlcmhhcHMgSSdsbCBuZWVkIHRvIGR1cGxpY2F0ZSB0aGF0IGZ1bmN0aW9uYWxp dHkgaW4KPiB0aGUgUEQgZHJpdmVyLCBpbnN0ZWFkIG9mIG1ha2luZyBpdCBhbGwgZ2VuZXJpYyBh bmQgcmUtdXNhYmxlIGJ5IG90aGVyCj4gZHJpdmVycy4KPiAKPiBbMV0KPiBodHRwczovL2VsaXhp ci5ib290bGluLmNvbS9saW51eC92NS4xMC4yL3NvdXJjZS9kcml2ZXJzL3JlZ3VsYXRvci9jb3Jl LmMjTDQxMDcKPiAKCkkganVzdCByZWFsaXplZCB0aGF0IHRoZSBsb2NraW5nIGlzIG1pc3Npbmcg aW4gdGhlIHYyIHBhdGNoZXMsIHNvbWV0aGluZwp0byBmaXggaW4gdGhlIG5leHQgcmV2aXNpb24g OikKClN0aWxsIEknbSBpbiBmYXZvciBvZiBleHRlbmRpbmcgdGhlIE9QUCBBUEkgd2l0aCB0aGUg bmV3IGNvbW1vbgpmdW5jdGlvbnMuIEJ1dCBpZiB5b3UgaGF2ZSBhIHN0cm9uZyBvcGluaW9uIGFi b3V0IHRoYXQsIHRoZW4gSSdsbCB0cnkgdG8Kd29yayBhcm91bmQgaXQgaW4gdGhlIFBEIGRyaXZl ciBpbiB2My4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==