From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0TY1-0000u6-9d for qemu-devel@nongnu.org; Fri, 06 Oct 2017 10:24:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0TXx-0008A0-AI for qemu-devel@nongnu.org; Fri, 06 Oct 2017 10:24:17 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:55396) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0TXx-00088z-4m for qemu-devel@nongnu.org; Fri, 06 Oct 2017 10:24:13 -0400 From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <22999.37385.529283.864427@mariner.uk.xensource.com> Date: Fri, 6 Oct 2017 15:24:09 +0100 In-Reply-To: References: <1507133891-26013-1-git-send-email-ian.jackson@eu.citrix.com> <1507133891-26013-8-git-send-email-ian.jackson@eu.citrix.com> Subject: Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Juergen Gross , Stefano Stabellini , Ross Lagerwall , Anthony PERARD , "open list:X86" , xen-devel@nongnu.org Peter Maydell writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option"): > On 4 October 2017 at 17:18, Ian Jackson wrote: > > static void change_process_uid(void) > > { > > - if (user_pwd) { > > - if (setgid(user_pwd->pw_gid) < 0) { > > + if (user_pwd || user_uid != (uid_t)-1) { > > + if (setgid(user_pwd ? user_pwd->pw_gid : user_gid) < 0) { > > fprintf(stderr, "Failed to setgid(%d)\n", user_pwd->pw_gid); > > If you're changing the gid we pass to setgid() I think you should > also change the value we tell the user we tried to use in the > error message, or it could be rather confusing. Thanks for the review. Sorry about the mess here. I have fixed all these problems. Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option Date: Fri, 6 Oct 2017 15:24:09 +0100 Message-ID: <22999.37385.529283.864427@mariner.uk.xensource.com> References: <1507133891-26013-1-git-send-email-ian.jackson@eu.citrix.com> <1507133891-26013-8-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0TXz-0004mb-Sc for xen-devel@lists.xenproject.org; Fri, 06 Oct 2017 14:24:15 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Peter Maydell Cc: Juergen Gross , Stefano Stabellini , QEMU Developers , Ross Lagerwall , Anthony PERARD , "open list:X86" , xen-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org UGV0ZXIgTWF5ZGVsbCB3cml0ZXMgKCJSZTogW1FlbXUtZGV2ZWxdIFtQQVRDSCA3LzhdIG9zLXBv c2l4OiBQcm92aWRlIG5ldyAtcnVuYXNpZCBvcHRpb24iKToKPiBPbiA0IE9jdG9iZXIgMjAxNyBh dCAxNzoxOCwgSWFuIEphY2tzb24gPGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+IHdyb3RlOgo+ ID4gIHN0YXRpYyB2b2lkIGNoYW5nZV9wcm9jZXNzX3VpZCh2b2lkKQo+ID4gIHsKPiA+IC0gICAg aWYgKHVzZXJfcHdkKSB7Cj4gPiAtICAgICAgICBpZiAoc2V0Z2lkKHVzZXJfcHdkLT5wd19naWQp IDwgMCkgewo+ID4gKyAgICBpZiAodXNlcl9wd2QgfHwgdXNlcl91aWQgIT0gKHVpZF90KS0xKSB7 Cj4gPiArICAgICAgICBpZiAoc2V0Z2lkKHVzZXJfcHdkID8gdXNlcl9wd2QtPnB3X2dpZCA6IHVz ZXJfZ2lkKSA8IDApIHsKPiA+ICAgICAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIkZhaWxlZCB0 byBzZXRnaWQoJWQpXG4iLCB1c2VyX3B3ZC0+cHdfZ2lkKTsKPiAKPiBJZiB5b3UncmUgY2hhbmdp bmcgdGhlIGdpZCB3ZSBwYXNzIHRvIHNldGdpZCgpIEkgdGhpbmsgeW91IHNob3VsZAo+IGFsc28g Y2hhbmdlIHRoZSB2YWx1ZSB3ZSB0ZWxsIHRoZSB1c2VyIHdlIHRyaWVkIHRvIHVzZSBpbiB0aGUK PiBlcnJvciBtZXNzYWdlLCBvciBpdCBjb3VsZCBiZSByYXRoZXIgY29uZnVzaW5nLgoKVGhhbmtz IGZvciB0aGUgcmV2aWV3LiAgU29ycnkgYWJvdXQgdGhlIG1lc3MgaGVyZS4gIEkgaGF2ZSBmaXhl ZCBhbGwKdGhlc2UgcHJvYmxlbXMuCgpJYW4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0 cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK