From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0TYK-00015W-Pe for qemu-devel@nongnu.org; Fri, 06 Oct 2017 10:24:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0TYG-00008k-RN for qemu-devel@nongnu.org; Fri, 06 Oct 2017 10:24:36 -0400 Received: from smtp.citrix.com ([66.165.176.89]:46369) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0TYG-00007o-KO for qemu-devel@nongnu.org; Fri, 06 Oct 2017 10:24:32 -0400 From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <22999.37405.481769.589894@mariner.uk.xensource.com> Date: Fri, 6 Oct 2017 15:24:29 +0100 In-Reply-To: <5e5b3443-eb6f-de15-2cd6-35b5c9cf084a@citrix.com> References: <1507133891-26013-1-git-send-email-ian.jackson@eu.citrix.com> <1507133891-26013-8-git-send-email-ian.jackson@eu.citrix.com> <5e5b3443-eb6f-de15-2cd6-35b5c9cf084a@citrix.com> Subject: Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ross Lagerwall Cc: qemu-devel@nongnu.org, Anthony PERARD , xen-devel@lists.xenproject.org, Juergen Gross , Stefano Stabellini , xen-devel@nongnu.org Ross Lagerwall writes ("Re: [PATCH 7/8] os-posix: Provide new -runasid option"): > On 10/04/2017 05:18 PM, Ian Jackson wrote: > > - if (setuid(user_pwd->pw_uid) < 0) { > > + if (setuid(user_pwd ? user_pwd->pw_uid : user_gid) < 0) { > > fprintf(stderr, "Failed to setuid(%d)\n", user_pwd->pw_uid); > > exit(1); > > } > > This last one should be user_uid, not user_gid. Thanks, fixed. Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH 7/8] os-posix: Provide new -runasid option Date: Fri, 6 Oct 2017 15:24:29 +0100 Message-ID: <22999.37405.481769.589894@mariner.uk.xensource.com> References: <1507133891-26013-1-git-send-email-ian.jackson@eu.citrix.com> <1507133891-26013-8-git-send-email-ian.jackson@eu.citrix.com> <5e5b3443-eb6f-de15-2cd6-35b5c9cf084a@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0TYL-0004pV-CY for xen-devel@lists.xenproject.org; Fri, 06 Oct 2017 14:24:37 +0000 In-Reply-To: <5e5b3443-eb6f-de15-2cd6-35b5c9cf084a@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ross Lagerwall Cc: Juergen Gross , Stefano Stabellini , qemu-devel@nongnu.org, Anthony PERARD , xen-devel@lists.xenproject.org, xen-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org Um9zcyBMYWdlcndhbGwgd3JpdGVzICgiUmU6IFtQQVRDSCA3LzhdIG9zLXBvc2l4OiBQcm92aWRl IG5ldyAtcnVuYXNpZCBvcHRpb24iKToKPiBPbiAxMC8wNC8yMDE3IDA1OjE4IFBNLCBJYW4gSmFj a3NvbiB3cm90ZToKPiA+IC0gICAgICAgIGlmIChzZXR1aWQodXNlcl9wd2QtPnB3X3VpZCkgPCAw KSB7Cj4gPiArICAgICAgICBpZiAoc2V0dWlkKHVzZXJfcHdkID8gdXNlcl9wd2QtPnB3X3VpZCA6 IHVzZXJfZ2lkKSA8IDApIHsKPiA+ICAgICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJGYWls ZWQgdG8gc2V0dWlkKCVkKVxuIiwgdXNlcl9wd2QtPnB3X3VpZCk7Cj4gPiAgICAgICAgICAgICAg IGV4aXQoMSk7Cj4gPiAgICAgICAgICAgfQo+IAo+IFRoaXMgbGFzdCBvbmUgc2hvdWxkIGJlIHVz ZXJfdWlkLCBub3QgdXNlcl9naWQuCgpUaGFua3MsIGZpeGVkLgoKSWFuLgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlz dApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVs Cg==