From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F026C433F5 for ; Thu, 28 Apr 2022 14:09:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348009AbiD1OM5 (ORCPT ); Thu, 28 Apr 2022 10:12:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230047AbiD1OM4 (ORCPT ); Thu, 28 Apr 2022 10:12:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 70EEF27CCD for ; Thu, 28 Apr 2022 07:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651154981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VU/g/6adn+3HZiPBUlaLXpCnn/ytwolQHw+K+XFjUgY=; b=BZ4UWh0oGkwUTHDk6qcj1TJFqnhNmK2BhlGxgnTi36xVLg1YCxB7l1ZMD3zlaiu+1TK/Vw V63osOU3X20cAxlhDpMlwfscoEHvJ9rIgBeXl6kXGyjzRt2UVWaFr4hFcNlNvQssHwBNgb a/+ZL/cz13EiZti9HZSe9m4uHoPvlUg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-124-5eaKoKVXPliRlAHaUGjScw-1; Thu, 28 Apr 2022 10:09:40 -0400 X-MC-Unique: 5eaKoKVXPliRlAHaUGjScw-1 Received: by mail-wm1-f69.google.com with SMTP id l33-20020a05600c1d2100b00394059572d6so1537211wms.8 for ; Thu, 28 Apr 2022 07:09:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=VU/g/6adn+3HZiPBUlaLXpCnn/ytwolQHw+K+XFjUgY=; b=RIFURED9pSHvgVFrNioEkAoUhiPKWZZb6A20fsANoMfoMv7ZaMoP/v8QqxwbpGIRg7 MCzpvILc3syOE/gL8dSJBAtpk2i0FzhawPt6119tYkQdev0vLq1WpIgplYxqta0eXyKK CfyylEuSVXsSdY5uSR9TfWS7EW4rZMC7w5td5rAybyiF6gUyun2+MLg9qsP+j08/h84f cZvREnzEgu4A+lAJUzn2czL0dWzpZbXRVBEzEnberIiqqQ5Jbkxl7QRxnFEQkHiiMM3S NPnvLlVGSsxrLLG7NxFMgYZYQjndrN+um24t1IvzKuFWeJFyd2B7YODnpEhCCi33U001 JV7A== X-Gm-Message-State: AOAM533+okPNr4kSyFied8nVH5EQpg4S8FRzVDToNPbatgmxRs709uAv wtHqpfBfdXP0J3mvo9VpmUe+fnH5LUrSb22ARkeUul2ZWzk7pAAasdrzSOKjO3SnzoNUq/UcJvI KBhAgsd+00lOV8kR/YB2j/zaF X-Received: by 2002:adf:ee4c:0:b0:20a:e668:b939 with SMTP id w12-20020adfee4c000000b0020ae668b939mr10770717wro.523.1651154978799; Thu, 28 Apr 2022 07:09:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYEXrCDh17OVyVJrMHReMDh2nx5QQA/qJmvMcJgS06lVB9a+h1o00gnmRaDcGh7EL9Au5MCg== X-Received: by 2002:adf:ee4c:0:b0:20a:e668:b939 with SMTP id w12-20020adfee4c000000b0020ae668b939mr10770703wro.523.1651154978621; Thu, 28 Apr 2022 07:09:38 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-96-13.dyn.eolo.it. [146.241.96.13]) by smtp.gmail.com with ESMTPSA id v6-20020adfa1c6000000b0020add25571bsm9855395wrv.42.2022.04.28.07.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 07:09:38 -0700 (PDT) Message-ID: <229c169ccf8fdbf7fc826901982f1f15e86f3d17.camel@redhat.com> Subject: Re: [PATCH net-next 02/11] udp/ipv6: refactor udpv6_sendmsg udplite checks From: Paolo Abeni To: Pavel Begunkov , netdev@vger.kernel.org, "David S . Miller" , Jakub Kicinski Cc: David Ahern , Eric Dumazet , linux-kernel@vger.kernel.org Date: Thu, 28 Apr 2022 16:09:37 +0200 In-Reply-To: <33dfdf2119c86e35062f783d405bedec2fde2b4c.1651071843.git.asml.silence@gmail.com> References: <33dfdf2119c86e35062f783d405bedec2fde2b4c.1651071843.git.asml.silence@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-04-28 at 11:56 +0100, Pavel Begunkov wrote: > Don't save a IS_UDPLITE() result in advance but do when it's really > needed, so it doesn't store/load it from the stack. Same for resolving > the getfrag callback pointer. It's quite unclear to me if this change brings really any performance benefit. The end results will depend a lot on the optimization performed by the compiler, and IMHO the code looks better before this modifications. Paolo