Re: [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_flip: Set duration for subtest from command line

From: "Kahola, Mika" <mika.kahola@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_flip: Set duration for subtest from command line
Date: Thu, 8 Nov 2018 12:45:00 +0000	[thread overview]
Message-ID: <229f90f5e6f91f2dd597e3e6a3f039816648f85b.camel@intel.com> (raw)
In-Reply-To: <0e4681c0-c84d-f6c1-2a4a-d251b28fa103@linux.intel.com>

On Thu, 2018-11-08 at 12:47 +0100, Maarten Lankhorst wrote:
> Op 09-08-18 om 12:12 schreef Mika Kahola:
> > To reduce the execution time of kms_flip test on CI, let's move
> > subtest
> > duration parameter as command line option. The default subtest
> > duration
> > is 3 seconds for test that require jitter computation and for the
> > rest
> > of the subtests are run only once.
> > 
> > v2: Run each subtest only once (default action)
> > v3: Reduces default timeout for tests that require jitter
> > computation (Ville)
> > 
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> 
> I think this is the wrong approach. What we really want to do is kill
> tests from kms_flip
> instead and move them to separate places.
> 
> Killing off all the interruptible tests would save 50% of the time.
> So all we have to do is
> making sure that we have tests that test the missing ioctl's in in
> kms_atomic_interruptible,
> and we would save 50% of the time.
kms_atomic_interruptible would probably be more logical place for
interrupt tests. I agree that it would reduce the execution time of the
kms_flip test but in the end of the day we still need to run those
interruptible tests and therefore we would end up increasing the
execution time of the kms_atomic_interruptible test.

Do you feel that we could have overall reduction in test execution if
we move these interruptible tests out from kms_flip? Maybe kms_flip
readability would improve and therefore worth the effort?
> 
> After that we have to get rid of the unrelated tests to make the code
> more readable..
> nonexisting-fb, dpms-vs-vblank-race, modeset-vs-vblank-race and bo-
> too-big would be
> better off in a separate testcase.
> 
> Same for bad-tiling, but I already had a patch for that.
> https://patchwork.freedesktop.org/patch/259361/
> 
> This would clean up kms_flip a lot, and make the test more readable.
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev