Re: [PATCH 0/1] Additional license wrangling functionality

[Koen Kooi <koen@dominion.thruhere.net>]

Op 13 jul 2011, om 16:06 heeft Cliff Brake het volgende geschreven:

> Many thanks for implementing these improvements!
> 
> The manifest file for core-image-minimal is attached.
> 
> A few thoughts after testing this ...
> 
> I like the way the license information is being cleaned up in the recipes.
> 
> In the past, I have collected licenses by using the following
> procedure directly on a device:
> 
> cd /usr/lib/opkg/info
> grep License *
> 
> In the past (OE Classic build from a year ago or so), the Control file
> in a packaged looked like:
> 
> Package: libc6
> Version: 2.9-r37.3.6
> Description: GNU C Library
> Section: libs
> Priority: required
> Maintainer: Angstrom Developers <angstrom-distro-devel@linuxtogo.org>
> License: LGPL
> Architecture: armv5te
> OE: glibc
> Homepage: http://www.gnu.org/software/libc/libc.html
> Depends: update-rc.d, libcidn1
> Source: ...
> 
> Now, in OE core they look like this:
> 
> Package: libc6
> Version: 2.13-r6+svnr14157
> Description: Embedded GLIBC (GNU C Library)
> Embedded GLIBC (EGLIBC) is a variant of the GNU C Library (GLIBC) that is
> designed to work well on embedded systems. EGLIBC strives to be source
> and binary compatible with GLIBC. EGLIBC's goals include reduced
> footprint, configurable components, better support for cross-compilation
> and cross-testing.
> Section: libs
> Priority: optional
> Maintainer: OE-Core Developers <openembedded-core@lists.openembedded.org>
> Architecture: i586
> OE: eglibc
> Homepage: http://www.eglibc.org/home
> Provides: glibc
> Source:  ...
> 
> Why is the License field no longer included in the control file?
> 
> One of the biggest issues with the current license mechanism is the
> license directory seems to only populated at recipe build time, not at
> image rootfs generation.  Therefore, you have to do a clean build to
> get a list of licenses.  It seems like it would be more optimal if the
> License information was stored in the packages (as it was in the
> past), and then extracted from each package during the rootfs phase.
> The license manifest could then be created similar to the way the
> testlab stuff is done in OE:
> 
> http://cgit.openembedded.org/cgit.cgi/meta-openembedded/tree/meta-oe/classes/testlab.bbclass

I ported bits of that to narcissus to generate a manifest, have a look at:

http://git.angstrom-distribution.org/cgi-bin/cgit.cgi/narcissus/tree/scripts/extract-metadata.sh
http://git.angstrom-distribution.org/cgi-bin/cgit.cgi/narcissus/tree/scripts/assemble-image.sh#n275

Narcissus will generate a html page that looks like the manifest we use internally in TI to get things approved by the opensource reviewboard, so if things look strange, that's why :)

The angstrom autobuilders log a subset of testlab into a git repo: http://git.angstrom-distribution.org/cgi-bin/cgit.cgi/testlab/log/?h=yocto

regards,

Koen