Re: [PATCH] x86/mm: add select HAVE_ARCH_HUGE_VMALLOC in Kconfig

From: Song Liu <songliubraving@fb.com>
To: LKML <linux-kernel@vger.kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"Linux Memory Management List" <linux-mm@kvack.org>,
	Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH] x86/mm: add select HAVE_ARCH_HUGE_VMALLOC in Kconfig
Date: Tue, 24 Aug 2021 16:35:34 +0000	[thread overview]
Message-ID: <22FE49E7-85C9-440C-8EA7-4651B08B6495@fb.com> (raw)
In-Reply-To: <20210818212148.3927001-1-songliubraving@fb.com>

> On Aug 18, 2021, at 2:21 PM, Song Liu <songliubraving@fb.com> wrote:
> 
> Add "select HAVE_ARCH_HUGE_VMALLOC if HAVE_ARCH_HUGE_VMAP", so that huge
> vmalloc is enabled for X86_64 || X86_PAE.
> 
> Signed-off-by: Song Liu <songliubraving@fb.com>

Ping...

Does this change make sense? In my tests on Intel CPU, vmalloc will not 
return 2MB page without this change. 

Thanks,
Song  

> ---
> arch/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index a68bf2db0d3ea..6344c572555e0 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -154,6 +154,7 @@ config X86
> 	select HAVE_ACPI_APEI_NMI		if ACPI
> 	select HAVE_ALIGNED_STRUCT_PAGE		if SLUB
> 	select HAVE_ARCH_AUDITSYSCALL
> +	select HAVE_ARCH_HUGE_VMALLOC		if HAVE_ARCH_HUGE_VMAP
> 	select HAVE_ARCH_HUGE_VMAP		if X86_64 || X86_PAE
> 	select HAVE_ARCH_JUMP_LABEL
> 	select HAVE_ARCH_JUMP_LABEL_RELATIVE
> -- 
> 2.30.2
> 