From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kKDqV-0004tO-8T for mharc-grub-devel@gnu.org; Mon, 21 Sep 2020 00:54:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKDqT-0004tH-0s for grub-devel@gnu.org; Mon, 21 Sep 2020 00:54:33 -0400 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:41700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKDqQ-0001Bg-VH for grub-devel@gnu.org; Mon, 21 Sep 2020 00:54:32 -0400 Received: by mail-pg1-x544.google.com with SMTP id y1so7967083pgk.8 for ; Sun, 20 Sep 2020 21:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:message-id:subject:mime-version :content-transfer-encoding; bh=yURLcS1ngrZ07Gf8RjJBUcl8YOJiKe1RKCCgoJTPsws=; b=xIutLqHeBSzPoRG9E3asyVIMuA8oID1x0tURVqywtmNgibG60uGDdDMEYOkhZ/BkNo mRBxT+Kvi3O31prjryGmoNChhkqgIUENJizAFwgwBJGdgDATJR9P5GKPst/eH5v5pQLk 3U2DJ8kIHgdbBp6aL7aBZCWUxim8TR9LkBDPxua3P2wyGps4olPGxzfKyOuEXvKYU2tQ EsE0Vqp57YSDbVHQ3ffrT1VvIXiF5Y3i1cEq8HC80cAOioZ/cwiEWicKFjMj0i+FdNR7 WDIPsfh2xo5ocRnckB0q0LrVFKFQw13lK0tecO64vxuvusJXtsIeFHXeIuvwNgoTqE41 NlZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:subject:mime-version :content-transfer-encoding; bh=yURLcS1ngrZ07Gf8RjJBUcl8YOJiKe1RKCCgoJTPsws=; b=E18rNPMU3kEJq1W8ZD3aUHpdg4iLXUHN1otLgfalznaLycGCqautpEtupgwTtWuBV7 uT7OQBw5ivRqOT+7RWG2on/wXsmoo3Ny18n+rZbBZc14x3av22foyCyl/19T9h6++8s1 mQK+QtkWPBkbprs9fbqix/9TbvSL4/oZPb6g0Smt5dc3jtgIO+jI+Es+wm7LzBArdNFD V8INR4GH/AOBn5BT73L29RiA4sOghuolZL9Z7Sr6NxCq8jW87AzmITUe+WzVqev+7vMA nrdlKbQ/q3jqYo1JkC8IJLebN0OWCbW9jF5UUOFTV0oYXs5ESc/oEQNgrPaA3oE/XOcm cs8A== X-Gm-Message-State: AOAM533tvZJ9IMmeMi5YDu27+wkyeM6vCvdQJ+uPtFPwsEYfgScUFJr8 xbOXVfI/RaY6AKEnm6LTo40tWw== X-Google-Smtp-Source: ABdhPJxXoDcRaSx0ypQc0z7kdZaU7mI+o0HgP/rdrD1PvvWDnq+130ati0qhp54YLTKx7SmRX+Z+Og== X-Received: by 2002:a17:902:b48f:b029:d1:e5f9:9f6 with SMTP id y15-20020a170902b48fb02900d1e5f909f6mr26404388plr.66.1600664068712; Sun, 20 Sep 2020 21:54:28 -0700 (PDT) Received: from [127.0.0.1] ([172.58.46.198]) by smtp.gmail.com with ESMTPSA id t3sm9011861pje.43.2020.09.20.21.54.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Sep 2020 21:54:28 -0700 (PDT) Date: Mon, 21 Sep 2020 04:54:26 +0000 (UTC) From: Glenn Washburn To: Patrick Steinhardt Cc: grub-devel@gnu.org, Denis GNUtoo Carikli , Daniel Kiper Message-ID: <22ad8064-9aef-43ee-8a17-b1f37a4dad2a@efficientek.com> Subject: Re: [PATCH v3 0/9] Cryptodisk fixes for v2.06 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <22ad8064-9aef-43ee-8a17-b1f37a4dad2a@efficientek.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::544; envelope-from=development@efficientek.com; helo=mail-pg1-x544.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 04:54:33 -0000 Sep 17, 2020 8:14:40 AM Patrick Steinhardt : > On Mon, Sep 07, 2020 at 05:27:27PM +0200, Patrick Steinhardt wrote: >> this is the third version of this patchset, collecting various fixes for >> LUKS2/cryptodisk for the upcoming release of GRUB v2.06. >> >> Besides my Reviewed-by tag, the only thing that changed is the final >> patch by Glenn. Quoting him: >> >>> The main difference with this patch is that sector_size is renamed to >>> log_sector_size, grub has enough inaccurate or misleading names. >>> Additionally, rename LOG_SECTOR_SIZE to LUKS_LOG_SECTOR_SIZE and >>> CRYPT_LOG_SECTOR_SIZE to GRUB_CRYPTODISK_IV_LOG_SIZE and moved to >>> cryptodisk.h.=C2=A0 Also a comment was reworded for clarity. > > A subset of these patches has been applied by Daniel, leaving us at > (rearranged for better readability): > >> Glenn Washburn (6): >> cryptodisk: Fix incorrect calculation of start sector >> cryptodisk: Unregister cryptomount command when removing module > > Both were picked. > >> luks2: Fix use of incorrect index and some error messages >> luks2: grub_cryptodisk_t->total_length is the max number of device >> native sectors >> cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain' >> cryptodisk: Properly handle non-512 byte sized sectors > > These weren't yet and got some feedback. > >> Patrick Steinhardt (3): >> json: Remove invalid typedef redefinition >> luks: Fix out-of-bounds copy of UUID >> luks2: Improve error reporting when decrypting/verifying key > > All three of these have been applied. > > @Glenn: seeing that all of my patches have been applied, do you want to > take over your remaining four patches again? That'd probably make the > process easier for both of us. Sure, I can do that. I've been traveling for the last several weeks with li= ttle connectivity and limited time, which is why I haven't been active in a= ddressing the responses on this thread. Thanks for helping move this forwar= d