From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 07/16] net/axgbe: add interrupt handler for
 autonegotiation
Date: Fri, 8 Dec 2017 13:06:15 -0800
Message-ID: <22ae1f40-1498-f87e-0371-f35b048e59af@intel.com>
References: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com>
 <1512047472-118050-7-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Ravi Kumar <Ravi1.kumar@amd.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id A27DEE5D
 for <dev@dpdk.org>; Fri,  8 Dec 2017 22:06:16 +0100 (CET)
In-Reply-To: <1512047472-118050-7-git-send-email-Ravi1.kumar@amd.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/30/2017 5:11 AM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>

<...>

> +static void
> +axgbe_dev_interrupt_handler(void *param)
> +{
> +	struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
> +	struct axgbe_port *pdata = dev->data->dev_private;
> +
> +	pdata->phy_if.an_isr(pdata);
> +
> +	rte_intr_enable(&pdata->pci_dev->intr_handle);

This is already inside the interrupt handler, shouldn't interrupts needs to be
enabled somewhere else to reach this point at first place.

And I have seen a few drivers does the same but do we need to call
rte_intr_enable() in interrupt handler? Will interrupts disabled after each fire?

<...>