From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkFfi-00058M-4U for qemu-devel@nongnu.org; Tue, 22 Aug 2017 16:21:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkFff-0003Ya-03 for qemu-devel@nongnu.org; Tue, 22 Aug 2017 16:21:10 -0400 References: <1815e11378b48532e902e0138a58557c297c3eb2.1503249785.git.balaton@eik.bme.hu> <088c08f0-d4cd-e1c2-6715-3aeb33b7f4b9@redhat.com> From: John Snow Message-ID: <22b8feef-4fd8-88fa-a5ad-a294c5749be4@redhat.com> Date: Tue, 22 Aug 2017 16:21:03 -0400 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/15] hw/ide: Emulate SiI3112 SATA controller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Francois Revol , Alexander Graf , David Gibson , Peter Maydell On 08/22/2017 04:15 PM, BALATON Zoltan wrote: > On Tue, 22 Aug 2017, John Snow wrote: >> On 08/22/2017 07:08 AM, BALATON Zoltan wrote: >>> On Mon, 21 Aug 2017, John Snow wrote: >> >> Sure, but be advised that if the device causes problems outside of this >> use case and there's nobody willing or able to review it, that it may >> get removed again. >> >> I don't have a lot of free time to go through the register list point by >> point and make sure this is implemented correctly either, but if this >> helps your work I'm OK not holding it up. > > No problem, of course if a bug is reported I'll try to fix it or if I > can't it's OK to remove it again. I just hope it gets more testing and > maybe others could contribute fixes if it's in the main line. > Yep, just a "warning"! Thanks, it looks sane enough to me in general, If you have instructions for installing and testing a machine using this advice I'd like to check it out later this week and I'll sign off on the re-spin. (As a side-note; do we offer hardware support lists as part of canonical QEMU releases? It would be nice to annotate this device as something that is "experimental" instead of "supported" such that it would reflect its work-in-progress nature. I keep asking about this every now and again, but with the recent deprecations and removals from QEMU perhaps it's time to ask again if we can start codifying things down to the exact device...) --js