From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fETRz-00086e-DK for qemu-devel@nongnu.org; Fri, 04 May 2018 01:40:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fETRw-0003tS-9d for qemu-devel@nongnu.org; Fri, 04 May 2018 01:40:11 -0400 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:35877) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fETRv-0003r5-V5 for qemu-devel@nongnu.org; Fri, 04 May 2018 01:40:08 -0400 Received: by mail-wr0-x243.google.com with SMTP id f2-v6so7924246wrm.3 for ; Thu, 03 May 2018 22:40:07 -0700 (PDT) References: <1525376963-79623-1-git-send-email-mst@redhat.com> <1525376963-79623-43-git-send-email-mst@redhat.com> From: Marcel Apfelbaum Message-ID: <22bacd67-52c5-ed3b-d582-1024f576b88e@gmail.com> Date: Fri, 4 May 2018 08:40:01 +0300 MIME-Version: 1.0 In-Reply-To: <1525376963-79623-43-git-send-email-mst@redhat.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 42/67] tcg: use include "tcg.h" consistently List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, Eduardo Habkost , Peter Crosthwaite , Stefan Weil , Stefan Hajnoczi , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson On 05/03/2018 10:51 PM, Michael S. Tsirkin wrote: > Some places include tcg.h, others tcg/tcg.h. > Let's be consistent. > > Signed-off-by: Michael S. Tsirkin > --- > include/exec/translator.h | 2 +- > trace/mem.h | 2 +- > accel/stubs/tcg-stub.c | 2 +- > accel/tcg/cputlb.c | 2 +- > accel/tcg/translator.c | 2 +- > disas/tci.c | 2 +- > hw/i386/kvmvapic.c | 2 +- > tcg/tcg-common.c | 2 +- > tcg/tci.c | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/include/exec/translator.h b/include/exec/translator.h > index e2dc2a0..a915953 100644 > --- a/include/exec/translator.h > +++ b/include/exec/translator.h > @@ -20,7 +20,7 @@ > > > #include "exec/exec-all.h" > -#include "tcg/tcg.h" > +#include "tcg.h" > > > /** > diff --git a/trace/mem.h b/trace/mem.h > index 9c88bcb..39a1e21 100644 > --- a/trace/mem.h > +++ b/trace/mem.h > @@ -10,7 +10,7 @@ > #ifndef TRACE__MEM_H > #define TRACE__MEM_H > > -#include "tcg/tcg.h" > +#include "tcg.h" > > > /** > diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c > index ee575a8..ab2a372b 100644 > --- a/accel/stubs/tcg-stub.c > +++ b/accel/stubs/tcg-stub.c > @@ -13,7 +13,7 @@ > #include "qemu/osdep.h" > #include "qemu-common.h" > #include "cpu.h" > -#include "tcg/tcg.h" > +#include "tcg.h" > #include "exec/cpu-common.h" > #include "exec/exec-all.h" > > diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c > index 0543903..d295d14 100644 > --- a/accel/tcg/cputlb.c > +++ b/accel/tcg/cputlb.c > @@ -27,7 +27,7 @@ > #include "exec/cputlb.h" > #include "exec/memory-internal.h" > #include "exec/ram_addr.h" > -#include "tcg/tcg.h" > +#include "tcg.h" > #include "qemu/error-report.h" > #include "exec/log.h" > #include "exec/helper-proto.h" > diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c > index 23c6602..01480b9 100644 > --- a/accel/tcg/translator.c > +++ b/accel/tcg/translator.c > @@ -11,7 +11,7 @@ > #include "qemu-common.h" > #include "qemu/error-report.h" > #include "cpu.h" > -#include "tcg/tcg.h" > +#include "tcg.h" > #include "tcg/tcg-op.h" > #include "exec/exec-all.h" > #include "exec/gen-icount.h" > diff --git a/disas/tci.c b/disas/tci.c > index 1cdf5ee..7408a56 100644 > --- a/disas/tci.c > +++ b/disas/tci.c > @@ -20,7 +20,7 @@ > #include "qemu/osdep.h" > #include "qemu-common.h" > #include "disas/bfd.h" > -#include "tcg/tcg.h" > +#include "tcg.h" > > /* Disassemble TCI bytecode. */ > int print_insn_tci(bfd_vma addr, disassemble_info *info) > diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c > index fc962c5..23aef34 100644 > --- a/hw/i386/kvmvapic.c > +++ b/hw/i386/kvmvapic.c > @@ -18,7 +18,7 @@ > #include "sysemu/kvm.h" > #include "hw/i386/apic_internal.h" > #include "hw/sysbus.h" > -#include "tcg/tcg.h" > +#include "tcg.h" > > #define VAPIC_IO_PORT 0x7e > > diff --git a/tcg/tcg-common.c b/tcg/tcg-common.c > index 2f139de..d80cbec 100644 > --- a/tcg/tcg-common.c > +++ b/tcg/tcg-common.c > @@ -25,7 +25,7 @@ > #include "qemu/osdep.h" > #include "qemu-common.h" > #include "exec/cpu-common.h" > -#include "tcg/tcg.h" > +#include "tcg.h" > > #if defined(CONFIG_TCG_INTERPRETER) > uintptr_t tci_tb_ptr; > diff --git a/tcg/tci.c b/tcg/tci.c > index 33edca1..2d11dc6 100644 > --- a/tcg/tci.c > +++ b/tcg/tci.c > @@ -28,7 +28,7 @@ > #endif > > #include "qemu-common.h" > -#include "tcg/tcg.h" /* MAX_OPC_PARAM_IARGS */ > +#include "tcg.h" /* MAX_OPC_PARAM_IARGS */ > #include "exec/cpu_ldst.h" > #include "tcg-op.h" > Reviewed-by: Marcel Apfelbaum Thanks, Marcel